| Message ID | 1394455761-19226-1-git-send-email-rogerq@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 03/10/2014 02:49 PM, Roger Quadros wrote: > USB_DPLL must be initialized and locked at boot so that > USB modules can work. > > Program USB_DLL_M2 output to half rate as well. > > Patch depends on > https://www.mail-archive.com/linux-omap@vger.kernel.org/msg101300.html > > CC: Mike Turquette <mturquette@linaro.org> > CC: Tero Kristo <t-kristo@ti.com> > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > arch/arm/boot/dts/dra7.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index 597979b..f376923 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -815,3 +815,11 @@ > }; > > /include/ "dra7xx-clocks.dtsi" > + > +&dpll_usb_ck { > + default-rate = <960000000>; > +}; > + > +&dpll_usb_m2_ck { > + default-rate = <480000000>; > +}; > You can add these directly under the dra7xx-clocks.dtsi file as well, as I don't think anybody needs to modify these. And the properties can be added directly under the nodes themselves. However, this patch can't be acked yet as we have no feedback from Mike for the default-rate proposal. -Tero
On 03/10/2014 03:28 PM, Tero Kristo wrote: > On 03/10/2014 02:49 PM, Roger Quadros wrote: >> USB_DPLL must be initialized and locked at boot so that >> USB modules can work. >> >> Program USB_DLL_M2 output to half rate as well. >> >> Patch depends on >> https://www.mail-archive.com/linux-omap@vger.kernel.org/msg101300.html >> >> CC: Mike Turquette <mturquette@linaro.org> >> CC: Tero Kristo <t-kristo@ti.com> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> arch/arm/boot/dts/dra7.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index 597979b..f376923 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -815,3 +815,11 @@ >> }; >> >> /include/ "dra7xx-clocks.dtsi" >> + >> +&dpll_usb_ck { >> + default-rate = <960000000>; >> +}; >> + >> +&dpll_usb_m2_ck { >> + default-rate = <480000000>; >> +}; >> > > You can add these directly under the dra7xx-clocks.dtsi file as well, as I don't think anybody needs to modify these. And the properties can be added directly under the nodes themselves. > > However, this patch can't be acked yet as we have no feedback from Mike for the default-rate proposal. OK. I'll wait for the "default-rate" patch to be approved first and then revise this patch based on your suggestion. Thanks for the review. cheers, -roger
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 597979b..f376923 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi @@ -815,3 +815,11 @@ }; /include/ "dra7xx-clocks.dtsi" + +&dpll_usb_ck { + default-rate = <960000000>; +}; + +&dpll_usb_m2_ck { + default-rate = <480000000>; +};
USB_DPLL must be initialized and locked at boot so that USB modules can work. Program USB_DLL_M2 output to half rate as well. Patch depends on https://www.mail-archive.com/linux-omap@vger.kernel.org/msg101300.html CC: Mike Turquette <mturquette@linaro.org> CC: Tero Kristo <t-kristo@ti.com> Signed-off-by: Roger Quadros <rogerq@ti.com> --- arch/arm/boot/dts/dra7.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)