diff mbox

[nfs-utils] tools: use install -m instead of --mode

Message ID 1393621584-15467-1-git-send-email-aaro.koskinen@iki.fi (mailing list archive)
State New, archived
Headers show

Commit Message

Aaro Koskinen Feb. 28, 2014, 9:06 p.m. UTC
Use install -m instead of--mode for better compatibility.
E.g. busybox's install doesn't support the long option.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
 tools/mountstats/Makefile.am | 2 +-
 tools/nfs-iostat/Makefile.am | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Steve Dickson March 11, 2014, 6:08 p.m. UTC | #1
On 02/28/2014 04:06 PM, Aaro Koskinen wrote:
> Use install -m instead of--mode for better compatibility.
> E.g. busybox's install doesn't support the long option.
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Committed...

steved.

> ---
>  tools/mountstats/Makefile.am | 2 +-
>  tools/nfs-iostat/Makefile.am | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/mountstats/Makefile.am b/tools/mountstats/Makefile.am
> index ca617a2..c2e9f99 100644
> --- a/tools/mountstats/Makefile.am
> +++ b/tools/mountstats/Makefile.am
> @@ -8,6 +8,6 @@ EXTRA_DIST	= $(man8_MANS) $(PYTHON_FILES)
>  all-local: $(PYTHON_FILES)
>  
>  install-data-hook:
> -	$(INSTALL) --mode 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
> +	$(INSTALL) -m 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
>  
>  MAINTAINERCLEANFILES=Makefile.in
> diff --git a/tools/nfs-iostat/Makefile.am b/tools/nfs-iostat/Makefile.am
> index 30f4054..3ae0f29 100644
> --- a/tools/nfs-iostat/Makefile.am
> +++ b/tools/nfs-iostat/Makefile.am
> @@ -8,6 +8,6 @@ EXTRA_DIST	= $(man8_MANS) $(PYTHON_FILES)
>  all-local: $(PYTHON_FILES)
>  
>  install-data-hook:
> -	$(INSTALL) --mode 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
> +	$(INSTALL) -m 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
>  
>  MAINTAINERCLEANFILES=Makefile.in
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tools/mountstats/Makefile.am b/tools/mountstats/Makefile.am
index ca617a2..c2e9f99 100644
--- a/tools/mountstats/Makefile.am
+++ b/tools/mountstats/Makefile.am
@@ -8,6 +8,6 @@  EXTRA_DIST	= $(man8_MANS) $(PYTHON_FILES)
 all-local: $(PYTHON_FILES)
 
 install-data-hook:
-	$(INSTALL) --mode 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
+	$(INSTALL) -m 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
 
 MAINTAINERCLEANFILES=Makefile.in
diff --git a/tools/nfs-iostat/Makefile.am b/tools/nfs-iostat/Makefile.am
index 30f4054..3ae0f29 100644
--- a/tools/nfs-iostat/Makefile.am
+++ b/tools/nfs-iostat/Makefile.am
@@ -8,6 +8,6 @@  EXTRA_DIST	= $(man8_MANS) $(PYTHON_FILES)
 all-local: $(PYTHON_FILES)
 
 install-data-hook:
-	$(INSTALL) --mode 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
+	$(INSTALL) -m 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
 
 MAINTAINERCLEANFILES=Makefile.in