| Message ID | 20140312134322.GA28005@localhost.localdomain (mailing list archive) |
|---|---|
| State | Under Review, archived |
| Headers | show |
On Wed, Mar 12, 2014 at 03:43:24PM +0200, Rakesh Pandit wrote: > While formatting multiple devics (and user doesn't specify -M) if one > of them has block count or size less then 1 GiB, mkfs doesn't tell > user, on which one mixed metadata/data was forced. This patch updates > message to print device name. I think we should fix the constraints what devices can be used together, mixing small and large ones works, but I don't think it's the usecase I'd recommend. And I'm not sure the mixed profile was intended for multiple devices at all. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 12, 2014 at 05:36:14PM +0100, David Sterba wrote: > On Wed, Mar 12, 2014 at 03:43:24PM +0200, Rakesh Pandit wrote: > > While formatting multiple devics (and user doesn't specify -M) if one > > of them has block count or size less then 1 GiB, mkfs doesn't tell > > user, on which one mixed metadata/data was forced. This patch updates > > message to print device name. > > I think we should fix the constraints what devices can be used together, > mixing small and large ones works, but I don't think it's the usecase > I'd recommend. And I'm not sure the mixed profile was intended for > multiple devices at all. Yes makes sense, thanks for review. regards, -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/mkfs.c b/mkfs.c index 2dc90c2..621c869 100644 --- a/mkfs.c +++ b/mkfs.c @@ -1372,7 +1372,8 @@ int main(int ac, char **av) ssd = is_ssd(file); if (is_vol_small(file)) { - printf("SMALL VOLUME: forcing mixed metadata/data groups\n"); + printf("SMALL VOLUME %s: forcing mixed metadata/data groups\n", + file); mixed = 1; } diff --git a/utils.c b/utils.c index 37ec6e5..00dde0f 100644 --- a/utils.c +++ b/utils.c @@ -597,7 +597,7 @@ int btrfs_prepare_device(int fd, char *file, int zero_end, u64 *block_count_ret, zero_end = 1; if (block_count < 1024 * 1024 * 1024 && !(*mixed)) { - printf("SMALL VOLUME: forcing mixed metadata/data groups\n"); + printf("SMALL VOLUME %s: forcing mixed metadata/data groups\n", file); *mixed = 1; }
While formatting multiple devics (and user doesn't specify -M) if one of them has block count or size less then 1 GiB, mkfs doesn't tell user, on which one mixed metadata/data was forced. This patch updates message to print device name. Signed-off-by: Rakesh Pandit <rakesh@tuxera.com> --- mkfs.c | 3 ++- utils.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)