| Message ID | 20140317154644.15065deb@endymion.delvare (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Monday, March 17, 2014 03:46:44 PM Jean Delvare wrote: > From: Jean Delvare <jdelvare@suse.de> > Subject: ACPI: fix ACPI_VIDEO dependencies > > ACPI_VIDEO stopped depending on VIDEO_OUTPUT_CONTROL over 3 years ago > (see commit 677bd810, "ACPI video: remove output switching control".) > So it's about time to remove the Kconfig dependency between these two > options. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Len Brown <lenb@kernel.org> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Do you want me to take this series? > --- > It would be great if this patch could go upstream quickly, as > system-wide cleanups depend on it. > > drivers/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-3.14-rc7.orig/drivers/acpi/Kconfig 2014-01-20 03:40:07.000000000 +0100 > +++ linux-3.14-rc7/drivers/acpi/Kconfig 2014-03-17 14:13:33.312716554 +0100 > @@ -115,7 +115,7 @@ config ACPI_BUTTON > > config ACPI_VIDEO > tristate "Video" > - depends on X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL > + depends on X86 && BACKLIGHT_CLASS_DEVICE > depends on INPUT > select THERMAL > help > > >
Hi Rafael, On Wed, 19 Mar 2014 02:26:52 +0100, Rafael J. Wysocki wrote: > On Monday, March 17, 2014 03:46:44 PM Jean Delvare wrote: > > From: Jean Delvare <jdelvare@suse.de> > > Subject: ACPI: fix ACPI_VIDEO dependencies > > > > ACPI_VIDEO stopped depending on VIDEO_OUTPUT_CONTROL over 3 years ago > > (see commit 677bd810, "ACPI video: remove output switching control".) > > So it's about time to remove the Kconfig dependency between these two > > options. > > > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > > Cc: Zhang Rui <rui.zhang@intel.com> > > Cc: Len Brown <lenb@kernel.org> > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > Do you want me to take this series? If other maintainers are OK with it, yes, I think that would be the easiest way. Thanks for proposing. All these patches depend on each other and must be applied in the right order, so pushing them through different trees would be slow at best, and risky. Also, thinking about it, I wonder if the first 3 patches of the series could go to longterm kernel series? While they do not fix any build breakage nor run-time bug, without them everyone (on x86 at least) is forced to build dead code. This is kind of frustrating. They are simple and obvious enough that hopefully there won't be any objection. Thanks,
On Wednesday, March 19, 2014 07:51:45 AM Jean Delvare wrote: > Hi Rafael, > > On Wed, 19 Mar 2014 02:26:52 +0100, Rafael J. Wysocki wrote: > > On Monday, March 17, 2014 03:46:44 PM Jean Delvare wrote: > > > From: Jean Delvare <jdelvare@suse.de> > > > Subject: ACPI: fix ACPI_VIDEO dependencies > > > > > > ACPI_VIDEO stopped depending on VIDEO_OUTPUT_CONTROL over 3 years ago > > > (see commit 677bd810, "ACPI video: remove output switching control".) > > > So it's about time to remove the Kconfig dependency between these two > > > options. > > > > > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > > > Cc: Zhang Rui <rui.zhang@intel.com> > > > Cc: Len Brown <lenb@kernel.org> > > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > > > Do you want me to take this series? > > If other maintainers are OK with it, yes, I think that would be the > easiest way. Thanks for proposing. All these patches depend on each > other and must be applied in the right order, so pushing them through > different trees would be slow at best, and risky. OK, I'll queue them up for 3.15 then, as I haven't seen any objections. > Also, thinking about it, I wonder if the first 3 patches of the series > could go to longterm kernel series? While they do not fix any build > breakage nor run-time bug, without them everyone (on x86 at least) is > forced to build dead code. This is kind of frustrating. They are simple > and obvious enough that hopefully there won't be any objection. I think it'll be best if you request the -stable people to pick up those commits once they have reached the Linus' tree. Thanks, Rafael
On Wed, 19 Mar 2014 14:10:53 +0100, Rafael J. Wysocki wrote: > On Wednesday, March 19, 2014 07:51:45 AM Jean Delvare wrote: > > Hi Rafael, > > > > On Wed, 19 Mar 2014 02:26:52 +0100, Rafael J. Wysocki wrote: > > > On Monday, March 17, 2014 03:46:44 PM Jean Delvare wrote: > > > > From: Jean Delvare <jdelvare@suse.de> > > > > Subject: ACPI: fix ACPI_VIDEO dependencies > > > > > > > > ACPI_VIDEO stopped depending on VIDEO_OUTPUT_CONTROL over 3 years ago > > > > (see commit 677bd810, "ACPI video: remove output switching control".) > > > > So it's about time to remove the Kconfig dependency between these two > > > > options. > > > > > > > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > > > > Cc: Zhang Rui <rui.zhang@intel.com> > > > > Cc: Len Brown <lenb@kernel.org> > > > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > > > > > Do you want me to take this series? > > > > If other maintainers are OK with it, yes, I think that would be the > > easiest way. Thanks for proposing. All these patches depend on each > > other and must be applied in the right order, so pushing them through > > different trees would be slow at best, and risky. > > OK, I'll queue them up for 3.15 then, as I haven't seen any objections. Thank you :-) > > Also, thinking about it, I wonder if the first 3 patches of the series > > could go to longterm kernel series? While they do not fix any build > > breakage nor run-time bug, without them everyone (on x86 at least) is > > forced to build dead code. This is kind of frustrating. They are simple > > and obvious enough that hopefully there won't be any objection. > > I think it'll be best if you request the -stable people to pick > up those commits once they have reached the Linus' tree. Sure, I can do that. Thanks,
--- linux-3.14-rc7.orig/drivers/acpi/Kconfig 2014-01-20 03:40:07.000000000 +0100 +++ linux-3.14-rc7/drivers/acpi/Kconfig 2014-03-17 14:13:33.312716554 +0100 @@ -115,7 +115,7 @@ config ACPI_BUTTON config ACPI_VIDEO tristate "Video" - depends on X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL + depends on X86 && BACKLIGHT_CLASS_DEVICE depends on INPUT select THERMAL help