diff mbox

[26/62] ARM: mvebu: don't select CONFIG_NEON

Message ID 1395257399-359545-27-git-send-email-arnd@arndb.de (mailing list archive)
State New, archived
Headers show

Commit Message

Arnd Bergmann March 19, 2014, 7:29 p.m. UTC
CONFIG_NEON is meant to be user-selectable. Turning it on
unconditionally means we can't build a smaller kernel when
we don't need it, and causes build errors if CONFIG_VFP
is not also enabled.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
 arch/arm/mach-mvebu/Kconfig | 2 --
 1 file changed, 2 deletions(-)

Comments

Jason Cooper March 19, 2014, 7:37 p.m. UTC | #1
On Wed, Mar 19, 2014 at 08:29:23PM +0100, Arnd Bergmann wrote:
> CONFIG_NEON is meant to be user-selectable. Turning it on
> unconditionally means we can't build a smaller kernel when
> we don't need it, and causes build errors if CONFIG_VFP
> is not also enabled.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
>  arch/arm/mach-mvebu/Kconfig | 2 --
>  1 file changed, 2 deletions(-)

Acked-by: Jason Cooper <jason@lakedaemon.net>

Gregory, Thomas, Ezequiel,

Care to spin a patch adding NEON to mvebu_v7_defconfig?  (If you want
it)

thx,

Jason.
Gregory CLEMENT March 19, 2014, 9:33 p.m. UTC | #2
On 19/03/2014 20:37, Jason Cooper wrote:
> On Wed, Mar 19, 2014 at 08:29:23PM +0100, Arnd Bergmann wrote:
>> CONFIG_NEON is meant to be user-selectable. Turning it on
>> unconditionally means we can't build a smaller kernel when
>> we don't need it, and causes build errors if CONFIG_VFP
>> is not also enabled.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Cc: Jason Cooper <jason@lakedaemon.net>
>> Cc: Andrew Lunn <andrew@lunn.ch>
>> Cc: Gregory Clement <gregory.clement@free-electrons.com>
>> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>> ---
>>  arch/arm/mach-mvebu/Kconfig | 2 --
>>  1 file changed, 2 deletions(-)
> 
> Acked-by: Jason Cooper <jason@lakedaemon.net>


Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>


> 
> Gregory, Thomas, Ezequiel,
> 
> Care to spin a patch adding NEON to mvebu_v7_defconfig?  (If you want
> it)

I will send a patch in a couple of minute. I'd like that it was applied
on the same release that this patch if possible.


Thanks,

Gregory


> 
> thx,
> 
> Jason.
>
diff mbox

Patch

diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
index 485513cb..b24a082 100644
--- a/arch/arm/mach-mvebu/Kconfig
+++ b/arch/arm/mach-mvebu/Kconfig
@@ -39,7 +39,6 @@  config MACH_ARMADA_375
 	select ARMADA_375_CLK
 	select CPU_V7
 	select MACH_MVEBU_V7
-	select NEON
 	select PINCTRL_ARMADA_375
 	help
 	  Say 'Y' here if you want your kernel to support boards based
@@ -53,7 +52,6 @@  config MACH_ARMADA_38X
 	select ARMADA_38X_CLK
 	select CPU_V7
 	select MACH_MVEBU_V7
-	select NEON
 	select PINCTRL_ARMADA_38X
 	help
 	  Say 'Y' here if you want your kernel to support boards based