| Message ID | 9835622.nRa3VdL61G@amdc1032 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Mar 25, 2014 at 08:10:27PM +0100, Bartlomiej Zolnierkiewicz wrote: > Limit sata_rcar host driver to ARCH_SHMOBILE as Renesas R-Car SATA > support is specific to Renesas SoCs and the driver to work requires > suitable device tree node (or platform device) to be defined. > > Cc: Simon Horman <horms@verge.net.au> > Cc: Magnus Damm <magnus.damm@gmail.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > drivers/ata/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > Index: b/drivers/ata/Kconfig > =================================================================== > --- a/drivers/ata/Kconfig 2014-03-25 19:52:31.952327027 +0100 > +++ b/drivers/ata/Kconfig 2014-03-25 19:57:21.104322097 +0100 > @@ -298,6 +298,7 @@ config SATA_PROMISE > > config SATA_RCAR > tristate "Renesas R-Car SATA support" > + depends on ARCH_SHMOBILE COMPILE_TEST?
On Tue, Mar 25, 2014 at 03:13:24PM -0400, Tejun Heo wrote: > On Tue, Mar 25, 2014 at 08:10:27PM +0100, Bartlomiej Zolnierkiewicz wrote: > > Limit sata_rcar host driver to ARCH_SHMOBILE as Renesas R-Car SATA > > support is specific to Renesas SoCs and the driver to work requires > > suitable device tree node (or platform device) to be defined. > > > > Cc: Simon Horman <horms@verge.net.au> > > Cc: Magnus Damm <magnus.damm@gmail.com> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > --- > > drivers/ata/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > Index: b/drivers/ata/Kconfig > > =================================================================== > > --- a/drivers/ata/Kconfig 2014-03-25 19:52:31.952327027 +0100 > > +++ b/drivers/ata/Kconfig 2014-03-25 19:57:21.104322097 +0100 > > @@ -298,6 +298,7 @@ config SATA_PROMISE > > > > config SATA_RCAR > > tristate "Renesas R-Car SATA support" > > + depends on ARCH_SHMOBILE > > COMPILE_TEST? I think the following would make sense: depends on ARCH_SHMOBILE || COMPILE_TEST
Index: b/drivers/ata/Kconfig =================================================================== --- a/drivers/ata/Kconfig 2014-03-25 19:52:31.952327027 +0100 +++ b/drivers/ata/Kconfig 2014-03-25 19:57:21.104322097 +0100 @@ -298,6 +298,7 @@ config SATA_PROMISE config SATA_RCAR tristate "Renesas R-Car SATA support" + depends on ARCH_SHMOBILE help This option enables support for Renesas R-Car Serial ATA.
Limit sata_rcar host driver to ARCH_SHMOBILE as Renesas R-Car SATA support is specific to Renesas SoCs and the driver to work requires suitable device tree node (or platform device) to be defined. Cc: Simon Horman <horms@verge.net.au> Cc: Magnus Damm <magnus.damm@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- drivers/ata/Kconfig | 1 + 1 file changed, 1 insertion(+)