| Message ID | 1396029548-10928-4-git-send-email-b.brezillon.dev@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dear Boris BREZILLON, On Fri, 28 Mar 2014 18:59:01 +0100, Boris BREZILLON wrote: > +config OLD_IRQ_AT91 > + bool > + default false I don't think "default false" is a valid Kconfig construct. It could be "default n", but that's useless since "default n" is the default behavior. So I believe you can simply get rid of that line. Thomas
On Saturday 29 March 2014 10:06:39 Thomas Petazzoni wrote: > Dear Boris BREZILLON, > > On Fri, 28 Mar 2014 18:59:01 +0100, Boris BREZILLON wrote: > > > +config OLD_IRQ_AT91 > > + bool > > + default false > > I don't think "default false" is a valid Kconfig construct. It could be > "default n", but that's useless since "default n" is the default > behavior. So I believe you can simply get rid of that line. I think the above is syntactically correct, but it would be highly confusing in anyone ever does config false def_bool y ;-) Aside from that, these three have completely identical meaning: config OLD_IRQ_AT91 bool config OLD_IRQ_AT91 def_bool n config OLD_IRQ_AT91 bool default n Arnd
Le 29/03/2014 10:12, Arnd Bergmann a écrit : > On Saturday 29 March 2014 10:06:39 Thomas Petazzoni wrote: >> Dear Boris BREZILLON, >> >> On Fri, 28 Mar 2014 18:59:01 +0100, Boris BREZILLON wrote: >> >>> +config OLD_IRQ_AT91 >>> + bool >>> + default false >> I don't think "default false" is a valid Kconfig construct. It could be >> "default n", but that's useless since "default n" is the default >> behavior. So I believe you can simply get rid of that line. I'll fix it for the next version. > I think the above is syntactically correct, but it would be highly confusing in > anyone ever does > > config false > def_bool y > > ;-) > > Aside from that, these three have completely identical meaning: > > config OLD_IRQ_AT91 > bool > > config OLD_IRQ_AT91 > def_bool n > > config OLD_IRQ_AT91 > bool > default n > > Arnd > > Thanks for the detailled explanation :-). Best Regards, Boris
diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig index 4f0e800..4f0b3e0 100644 --- a/arch/arm/mach-at91/Kconfig +++ b/arch/arm/mach-at91/Kconfig @@ -28,6 +28,10 @@ config OLD_CLK_AT91 bool default AT91_PMC_UNIT && AT91_USE_OLD_CLK +config OLD_IRQ_AT91 + bool + default false + config AT91_SAM9_ALT_RESET bool default !ARCH_AT91X40 @@ -189,6 +193,7 @@ config MACH_AT91RM9200_DT bool "Atmel AT91RM9200 Evaluation Kits with device-tree support" depends on SOC_AT91RM9200 select USE_OF + select OLD_IRQ_AT91 help Select this if you want to experiment device-tree with an Atmel RM9200 Evaluation Kit. @@ -197,6 +202,7 @@ config MACH_AT91SAM9_DT bool "Atmel AT91SAM Evaluation Kits with device-tree support" depends on SOC_AT91SAM9 select USE_OF + select OLD_IRQ_AT91 help Select this if you want to experiment device-tree with an Atmel Evaluation Kit. @@ -205,6 +211,7 @@ config MACH_SAMA5_DT bool "Atmel SAMA5 Evaluation Kits with device-tree support" depends on SOC_SAMA5 select USE_OF + select OLD_IRQ_AT91 select PHYLIB if NETDEVICES help Select this if you want to experiment device-tree with diff --git a/arch/arm/mach-at91/Kconfig.non_dt b/arch/arm/mach-at91/Kconfig.non_dt index 1f73e9b..75b582e 100644 --- a/arch/arm/mach-at91/Kconfig.non_dt +++ b/arch/arm/mach-at91/Kconfig.non_dt @@ -13,31 +13,37 @@ config ARCH_AT91RM9200 bool "AT91RM9200" select SOC_AT91RM9200 select AT91_USE_OLD_CLK + select OLD_IRQ_AT91 config ARCH_AT91SAM9260 bool "AT91SAM9260 or AT91SAM9XE or AT91SAM9G20" select SOC_AT91SAM9260 select AT91_USE_OLD_CLK + select OLD_IRQ_AT91 config ARCH_AT91SAM9261 bool "AT91SAM9261 or AT91SAM9G10" select SOC_AT91SAM9261 select AT91_USE_OLD_CLK + select OLD_IRQ_AT91 config ARCH_AT91SAM9263 bool "AT91SAM9263" select SOC_AT91SAM9263 select AT91_USE_OLD_CLK + select OLD_IRQ_AT91 config ARCH_AT91SAM9RL bool "AT91SAM9RL" select SOC_AT91SAM9RL select AT91_USE_OLD_CLK + select OLD_IRQ_AT91 config ARCH_AT91SAM9G45 bool "AT91SAM9G45" select SOC_AT91SAM9G45 select AT91_USE_OLD_CLK + select OLD_IRQ_AT91 config ARCH_AT91X40 bool "AT91x40" @@ -45,6 +51,7 @@ config ARCH_AT91X40 select ARCH_USES_GETTIMEOFFSET select MULTI_IRQ_HANDLER select SPARSE_IRQ + select OLD_IRQ_AT91 endchoice diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile index 78e9cec..d972fd6 100644 --- a/arch/arm/mach-at91/Makefile +++ b/arch/arm/mach-at91/Makefile @@ -2,11 +2,12 @@ # Makefile for the linux kernel. # -obj-y := irq.o gpio.o setup.o sysirq_mask.o +obj-y := gpio.o setup.o sysirq_mask.o obj-m := obj-n := obj- := +obj-$(CONFIG_OLD_IRQ_AT91) += irq.o obj-$(CONFIG_OLD_CLK_AT91) += clock.o obj-$(CONFIG_AT91_SAM9_ALT_RESET) += at91sam9_alt_reset.o obj-$(CONFIG_AT91_SAM9G45_RESET) += at91sam9g45_reset.o
Introduce a new Kconfig option OLD_IRQ_AT91 to prepare migration to the new AIC driver. Enable this option for all supported at91 SoCs (both dt and non-dt boards). Signed-off-by: Boris BREZILLON <b.brezillon.dev@gmail.com> --- arch/arm/mach-at91/Kconfig | 7 +++++++ arch/arm/mach-at91/Kconfig.non_dt | 7 +++++++ arch/arm/mach-at91/Makefile | 3 ++- 3 files changed, 16 insertions(+), 1 deletion(-)