diff mbox

spi: omap-100k: Fix memory leak

Message ID 1396076617.1937.1.camel@phoenix (mailing list archive)
State Accepted
Commit d1c18caace25aa8b6fcfe4dc78e96a031f1eab2d
Headers show

Commit Message

Axel Lin March 29, 2014, 7:03 a.m. UTC 
The memory allocated for cs is not freed anywhere.
Convert to use devm_kzalloc to fix the memory leak.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/spi/spi-omap-100k.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown March 29, 2014, 10:01 a.m. UTC | #1 
On Sat, Mar 29, 2014 at 03:03:37PM +0800, Axel Lin wrote:
> The memory allocated for cs is not freed anywhere.
> Convert to use devm_kzalloc to fix the memory leak.

Applied, thanks.
diff mbox

Patch

diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c
index c9e2282..e7ffcde 100644
--- a/drivers/spi/spi-omap-100k.c
+++ b/drivers/spi/spi-omap-100k.c
@@ -283,7 +283,7 @@  static int omap1_spi100k_setup(struct spi_device *spi)
 	spi100k = spi_master_get_devdata(spi->master);
 
 	if (!cs) {
-		cs = kzalloc(sizeof(*cs), GFP_KERNEL);
+		cs = devm_kzalloc(&spi->dev, sizeof(*cs), GFP_KERNEL);
 		if (!cs)
 			return -ENOMEM;
 		cs->base = spi100k->base + spi->chip_select * 0x14;