diff mbox

[8/9] ARM: shmobile: lager.dts: add usbphy reference

Message ID 1394128887-4197-9-git-send-email-ben.dooks@codethink.co.uk (mailing list archive)
State Changes Requested
Headers show

Commit Message

Ben Dooks March 6, 2014, 6:01 p.m. UTC
Enable the usbphy node so that the phy driver is available.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Reviewed-by: Ian Molton <ian.molton@codethink.co.uk>
---
Cc: linux-sh@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: Simon Horman <horms@verge.net.au>
---
 arch/arm/boot/dts/r8a7790-lager.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Sergei Shtylyov March 30, 2014, 7:28 p.m. UTC | #1
Hello.

On 03/06/2014 09:01 PM, Ben Dooks wrote:

> Enable the usbphy node so that the phy driver is available.

> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> Reviewed-by: Ian Molton <ian.molton@codethink.co.uk>
> ---
> Cc: linux-sh@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Simon Horman <horms@verge.net.au>
> ---
>   arch/arm/boot/dts/r8a7790-lager.dts | 4 ++++
>   1 file changed, 4 insertions(+)

> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index fd6851f..63d58d6 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -246,3 +246,7 @@
>   	pinctrl-0 = <&usb2_pins>;
>   	pinctrl-names = "default";
>   };
> +
> +&usbphy {
> +	status = "okay";
> +};

    I don't see why we need this patch. Why not make USB PHY always enabled?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ben Dooks March 30, 2014, 7:51 p.m. UTC | #2
On 30/03/14 20:28, Sergei Shtylyov wrote:
> Hello.
>
> On 03/06/2014 09:01 PM, Ben Dooks wrote:
>
>> Enable the usbphy node so that the phy driver is available.
>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> Reviewed-by: Ian Molton <ian.molton@codethink.co.uk>
>> ---
>> Cc: linux-sh@vger.kernel.org
>> Cc: devicetree@vger.kernel.org
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Cc: Simon Horman <horms@verge.net.au>
>> ---
>>   arch/arm/boot/dts/r8a7790-lager.dts | 4 ++++
>>   1 file changed, 4 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
>> b/arch/arm/boot/dts/r8a7790-lager.dts
>> index fd6851f..63d58d6 100644
>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>> @@ -246,3 +246,7 @@
>>       pinctrl-0 = <&usb2_pins>;
>>       pinctrl-names = "default";
>>   };
>> +
>> +&usbphy {
>> +    status = "okay";
>> +};
>
>     I don't see why we need this patch. Why not make USB PHY always
> enabled?

I have a current setup where we do not want the kernel to try
and probe the phy device.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index fd6851f..63d58d6 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -246,3 +246,7 @@ 
 	pinctrl-0 = <&usb2_pins>;
 	pinctrl-names = "default";
 };
+
+&usbphy {
+	status = "okay";
+};