| Message ID | 20140401142046.14d4bb8c@endymion.delvare (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
---------- Forwarded message ---------- From: Jean Delvare <jdelvare@suse.de> Date: 2014-04-01 20:20 GMT+08:00 Subject: [PATCH] Input: w90p910_ts - depend on ARCH_W90X900 To: linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org ??? Wan ZongShun <mcuos.com@gmail.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com> The w90p910_ts touchscreen driver is heavily architecture dependent, so there is no point in letting it be built on other architectures than it was written for. All other W90P910/W90X900 drivers already have that dependency, so it makes things more consistent and configuration easier. Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Wan ZongShun <mcuos.com@gmail.com> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/touchscreen/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-3.14-rc8.orig/drivers/input/touchscreen/Kconfig 2014-02-09 16:53:02.945634113 +0100 +++ linux-3.14-rc8/drivers/input/touchscreen/Kconfig 2014-04-01 14:10:08.936933702 +0200 @@ -867,7 +867,7 @@ config TOUCHSCREEN_TSC2007 config TOUCHSCREEN_W90X900 tristate "W90P910 touchscreen driver" - depends on HAVE_CLK + depends on ARCH_W90X900 help Say Y here if you have a W90P910 based touchscreen. Sure, your idea is reasonable. Acked-by Wan Zongshun <mcuos.com@gmail.com> -- Jean Delvare SUSE L3 Support
On Tue, Apr 01, 2014 at 09:17:03PM +0800, Wan ZongShun wrote: > ---------- Forwarded message ---------- > From: Jean Delvare <jdelvare@suse.de> > Date: 2014-04-01 20:20 GMT+08:00 > Subject: [PATCH] Input: w90p910_ts - depend on ARCH_W90X900 > To: linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org > ??? Wan ZongShun <mcuos.com@gmail.com>, Dmitry Torokhov > <dmitry.torokhov@gmail.com> > > > The w90p910_ts touchscreen driver is heavily architecture dependent, > so there is no point in letting it be built on other architectures > than it was written for. > > All other W90P910/W90X900 drivers already have that dependency, so it > makes things more consistent and configuration easier. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Wan ZongShun <mcuos.com@gmail.com> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > drivers/input/touchscreen/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-3.14-rc8.orig/drivers/input/touchscreen/Kconfig > 2014-02-09 16:53:02.945634113 +0100 > +++ linux-3.14-rc8/drivers/input/touchscreen/Kconfig 2014-04-01 > 14:10:08.936933702 +0200 > @@ -867,7 +867,7 @@ config TOUCHSCREEN_TSC2007 > > config TOUCHSCREEN_W90X900 > tristate "W90P910 touchscreen driver" > - depends on HAVE_CLK > + depends on ARCH_W90X900 > help > Say Y here if you have a W90P910 based touchscreen. > > Sure, your idea is reasonable. > > Acked-by Wan Zongshun <mcuos.com@gmail.com> Applied, thank you.
--- linux-3.14-rc8.orig/drivers/input/touchscreen/Kconfig 2014-02-09 16:53:02.945634113 +0100 +++ linux-3.14-rc8/drivers/input/touchscreen/Kconfig 2014-04-01 14:10:08.936933702 +0200 @@ -867,7 +867,7 @@ config TOUCHSCREEN_TSC2007 config TOUCHSCREEN_W90X900 tristate "W90P910 touchscreen driver" - depends on HAVE_CLK + depends on ARCH_W90X900 help Say Y here if you have a W90P910 based touchscreen.
The w90p910_ts touchscreen driver is heavily architecture dependent, so there is no point in letting it be built on other architectures than it was written for. All other W90P910/W90X900 drivers already have that dependency, so it makes things more consistent and configuration easier. Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Wan ZongShun <mcuos.com@gmail.com> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/touchscreen/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)