| Message ID | 1396618417-9560-1-git-send-email-gautam.vivek@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Apr 4, 2014 at 7:03 PM, Vivek Gautam <gautamvivek1987@gmail.com> wrote: > Patch : 14982e3 USB: OHCI: Properly handle ohci-exynos suspend > has already removed 'ohci_hcd' settings from exynos glue layer > as a part of streamlining the ohci controller's suspend. > So we don't need the locks for 'ohci_hcd' anymore. > > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > Cc: Manjunath Goudar <csmanjuvijay@gmail.com> > Cc: Alan Stern <stern@rowland.harvard.edu> > --- Please ignore this patch, WIP, got sent by mistake :-( Sorry for spamming. > drivers/usb/host/ohci-exynos.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c > index 68588d8..7f5e779 100644 > --- a/drivers/usb/host/ohci-exynos.c > +++ b/drivers/usb/host/ohci-exynos.c > @@ -199,8 +199,6 @@ static int exynos_ohci_suspend(struct device *dev) > if (rc) > return rc; > > - spin_lock_irqsave(&ohci->lock, flags); > - > if (exynos_ohci->otg) > exynos_ohci->otg->set_host(exynos_ohci->otg, &hcd->self); > > @@ -208,8 +206,6 @@ static int exynos_ohci_suspend(struct device *dev) > > clk_disable_unprepare(exynos_ohci->clk); > > - spin_unlock_irqrestore(&ohci->lock, flags); > - > return 0; > } > > -- > 1.7.10.4 >
diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 68588d8..7f5e779 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -199,8 +199,6 @@ static int exynos_ohci_suspend(struct device *dev) if (rc) return rc; - spin_lock_irqsave(&ohci->lock, flags); - if (exynos_ohci->otg) exynos_ohci->otg->set_host(exynos_ohci->otg, &hcd->self); @@ -208,8 +206,6 @@ static int exynos_ohci_suspend(struct device *dev) clk_disable_unprepare(exynos_ohci->clk); - spin_unlock_irqrestore(&ohci->lock, flags); - return 0; }
Patch : 14982e3 USB: OHCI: Properly handle ohci-exynos suspend has already removed 'ohci_hcd' settings from exynos glue layer as a part of streamlining the ohci controller's suspend. So we don't need the locks for 'ohci_hcd' anymore. Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> Cc: Manjunath Goudar <csmanjuvijay@gmail.com> Cc: Alan Stern <stern@rowland.harvard.edu> --- drivers/usb/host/ohci-exynos.c | 4 ---- 1 file changed, 4 deletions(-)