| Message ID | 1398147855-9868-4-git-send-email-tianyu.lan@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Tue, Apr 22, 2014 at 02:24:09PM +0800, Lan Tianyu wrote: > There is already acpi_bus_get_private_data() to get ACPI handle data > which is associated with acpi_bus_private_data_handler(). This patch > is to add acpi_bus_attach_private_data() to make a pair and facilitate > to attach and get data to/from ACPI handle. > > Signed-off-by: Lan Tianyu <tianyu.lan@intel.com> > --- > drivers/acpi/bus.c | 18 +++++++++++++++++- > include/acpi/acpi_bus.h | 1 + > 2 files changed, 18 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > index e7e5844..4ed8d48 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -132,6 +132,22 @@ void acpi_bus_private_data_handler(acpi_handle handle, > } > EXPORT_SYMBOL(acpi_bus_private_data_handler); > > +int acpi_bus_attach_private_data(acpi_handle handle, void *data) > +{ > + acpi_status status; > + > + status = acpi_attach_data(handle, > + acpi_bus_private_data_handler, data); > + if (ACPI_FAILURE(status)) { > + ACPI_ERROR((AE_INFO, "Error attaching device[%p] data\n", > + handle)); > + return -ENODEV; > + } > + > + return 0; > +} > +EXPORT_SYMBOL(acpi_bus_attach_private_data); When I added GPIO operation region support, Rafael mentioned that we might want to add this private data to the struct acpi_device instead. Either way, looks good to me, Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index e7e5844..4ed8d48 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -132,6 +132,22 @@ void acpi_bus_private_data_handler(acpi_handle handle, } EXPORT_SYMBOL(acpi_bus_private_data_handler); +int acpi_bus_attach_private_data(acpi_handle handle, void *data) +{ + acpi_status status; + + status = acpi_attach_data(handle, + acpi_bus_private_data_handler, data); + if (ACPI_FAILURE(status)) { + ACPI_ERROR((AE_INFO, "Error attaching device[%p] data\n", + handle)); + return -ENODEV; + } + + return 0; +} +EXPORT_SYMBOL(acpi_bus_attach_private_data); + int acpi_bus_get_private_data(acpi_handle handle, void **data) { acpi_status status; @@ -141,7 +157,7 @@ int acpi_bus_get_private_data(acpi_handle handle, void **data) status = acpi_get_data(handle, acpi_bus_private_data_handler, data); if (ACPI_FAILURE(status) || !*data) { - ACPI_DEBUG_PRINT((ACPI_DB_INFO, "No context for object [%p]\n", + ACPI_ERROR((AE_INFO, "No context for object [%p]\n", handle)); return -ENODEV; } diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index 84a2e29..a1f6fec 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h @@ -406,6 +406,7 @@ extern struct kobject *acpi_kobj; extern int acpi_bus_generate_netlink_event(const char*, const char*, u8, int); void acpi_bus_private_data_handler(acpi_handle, void *); int acpi_bus_get_private_data(acpi_handle, void **); +int acpi_bus_attach_private_data(acpi_handle, void *); void acpi_bus_no_hotplug(acpi_handle handle); extern int acpi_notifier_call_chain(struct acpi_device *, u32, u32); extern int register_acpi_notifier(struct notifier_block *);
There is already acpi_bus_get_private_data() to get ACPI handle data which is associated with acpi_bus_private_data_handler(). This patch is to add acpi_bus_attach_private_data() to make a pair and facilitate to attach and get data to/from ACPI handle. Signed-off-by: Lan Tianyu <tianyu.lan@intel.com> --- drivers/acpi/bus.c | 18 +++++++++++++++++- include/acpi/acpi_bus.h | 1 + 2 files changed, 18 insertions(+), 1 deletion(-)