diff mbox

[v2] drm/exynos: remove DRIVER_HAVE_IRQ feature

Message ID 1397263192-8470-1-git-send-email-jy0922.shim@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Joonyoung Shim April 12, 2014, 12:39 a.m. UTC
Exynos drm driver cannot support DRIVER_HAVE_IRQ feature because it uses
driver specific one instead of routine of drm framework to
install/uninstall irq handler.

Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
Changelog from v1:
 - Keep below code
	drm_dev->irq_enabled = true;

 drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Daniel Kurtz April 22, 2014, 4:33 p.m. UTC | #1
On Sat, Apr 12, 2014 at 8:39 AM, Joonyoung Shim <jy0922.shim@samsung.com>wrote:

> Exynos drm driver cannot support DRIVER_HAVE_IRQ feature because it uses
> driver specific one instead of routine of drm framework to
> install/uninstall irq handler.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>

Reviewed-by: Daniel Kurtz <djkurtz@chormium.org>


> ---
> Changelog from v1:
>  - Keep below code
>         drm_dev->irq_enabled = true;
>
>  drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index 2d27ba2..027e32d 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -323,8 +323,7 @@ static const struct file_operations
> exynos_drm_driver_fops = {
>  };
>
>  static struct drm_driver exynos_drm_driver = {
> -       .driver_features        = DRIVER_HAVE_IRQ | DRIVER_MODESET |
> -                                       DRIVER_GEM | DRIVER_PRIME,
> +       .driver_features        = DRIVER_MODESET | DRIVER_GEM |
> DRIVER_PRIME,
>         .load                   = exynos_drm_load,
>         .unload                 = exynos_drm_unload,
>         .suspend                = exynos_drm_suspend,
> --
> 1.8.1.2
>
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index 2d27ba2..027e32d 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -323,8 +323,7 @@  static const struct file_operations exynos_drm_driver_fops = {
 };
 
 static struct drm_driver exynos_drm_driver = {
-	.driver_features	= DRIVER_HAVE_IRQ | DRIVER_MODESET |
-					DRIVER_GEM | DRIVER_PRIME,
+	.driver_features	= DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME,
 	.load			= exynos_drm_load,
 	.unload			= exynos_drm_unload,
 	.suspend		= exynos_drm_suspend,