| Message ID | 1397832181-5153-3-git-send-email-t.figa@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Tomasz, On 18 April 2014 20:12, Tomasz Figa <t.figa@samsung.com> wrote: > When CPU topology is specified in device tree, cpu_logical_map() does > not return core ID anymore, but rather full MPIDR value. This breaks > existing calculation of PMU register offsets on Exynos SoCs. > > This patch fixes the problem by adjusting the code to use only core ID > bits of the value returned by cpu_logical_map() to allow CPU topology to > be specified in device tree on Exynos SoCs. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > --- > arch/arm/mach-exynos/hotplug.c | 10 ++++++---- > arch/arm/mach-exynos/platsmp.c | 31 ++++++++++++++++++------------- > 2 files changed, 24 insertions(+), 17 deletions(-) > > diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c > index 7e0f31a..8a5f07d 100644 > --- a/arch/arm/mach-exynos/hotplug.c > +++ b/arch/arm/mach-exynos/hotplug.c > @@ -92,11 +92,13 @@ static inline void cpu_leave_lowpower(void) > > static inline void platform_do_lowpower(unsigned int cpu, int *spurious) > { > + u32 mpidr = cpu_logical_map(cpu); > + u32 core_id = MPIDR_AFFINITY_LEVEL(mpidr, 0); > + > for (;;) { > > - /* make cpu1 to be turned off at next WFI command */ > - if (cpu == 1) > - __raw_writel(0, S5P_ARM_CORE_CONFIGURATION(1)); I think this macro is not yet in ML code. > + /* Turn the CPU off on next WFI instruction. */ > + __raw_writel(0, S5P_ARM_CORE_CONFIGURATION(core_id)); > > /* > * here's the WFI > @@ -106,7 +108,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) > : > : "memory", "cc"); > > - if (pen_release == cpu_logical_map(cpu)) { > + if (pen_release == core_id) { > /* > * OK, proper wakeup, we're done > */ > diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c > index 7b7de4b..e08b2c5 100644 > --- a/arch/arm/mach-exynos/platsmp.c > +++ b/arch/arm/mach-exynos/platsmp.c > @@ -89,7 +89,9 @@ static void exynos_secondary_init(unsigned int cpu) > static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle) > { > unsigned long timeout; > - unsigned long phys_cpu = cpu_logical_map(cpu); > + u32 mpidr = cpu_logical_map(cpu); > + u32 core_id = MPIDR_AFFINITY_LEVEL(mpidr, 0); > + u32 reg; > > /* > * Set synchronisation state between this boot processor > @@ -102,19 +104,20 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle) > * the holding pen - release it, then wait for it to flag > * that it has been released by resetting pen_release. > * > - * Note that "pen_release" is the hardware CPU ID, whereas > + * Note that "pen_release" is the hardware CPU core ID, whereas > * "cpu" is Linux's internal ID. > */ > - write_pen_release(phys_cpu); > + write_pen_release(core_id); > > - if (!(__raw_readl(S5P_ARM_CORE_STATUS(1)) & S5P_CORE_LOCAL_PWR_EN)) { > + reg = __raw_readl(S5P_ARM_CORE_STATUS(core_id)); > + if (!(reg & S5P_CORE_LOCAL_PWR_EN)) { > __raw_writel(S5P_CORE_LOCAL_PWR_EN, > - S5P_ARM_CORE_CONFIGURATION(1)); > + S5P_ARM_CORE_CONFIGURATION(core_id)); > > timeout = 10; > > /* wait max 10 ms until cpu1 is on */ > - while ((__raw_readl(S5P_ARM_CORE_STATUS(1)) > + while ((__raw_readl(S5P_ARM_CORE_STATUS(core_id)) > & S5P_CORE_LOCAL_PWR_EN) != S5P_CORE_LOCAL_PWR_EN) { > if (timeout-- == 0) > break; > @@ -146,10 +149,10 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle) > * Try to set boot address using firmware first > * and fall back to boot register if it fails. > */ > - if (call_firmware_op(set_cpu_boot_addr, phys_cpu, boot_addr)) > - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu)); > + if (call_firmware_op(set_cpu_boot_addr, core_id, boot_addr)) > + __raw_writel(boot_addr, cpu_boot_reg(core_id)); > > - call_firmware_op(cpu_boot, phys_cpu); > + call_firmware_op(cpu_boot, core_id); > > arch_send_wakeup_ipi_mask(cpumask_of(cpu)); > > @@ -215,14 +218,16 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus) > * boot register if it fails. > */ > for (i = 1; i < max_cpus; ++i) { > - unsigned long phys_cpu; > unsigned long boot_addr; > + u32 mpidr; > + u32 core_id; > > - phys_cpu = cpu_logical_map(i); > + mpidr = cpu_logical_map(i); > + core_id = MPIDR_AFFINITY_LEVEL(mpidr, 0); > boot_addr = virt_to_phys(exynos4_secondary_startup); > > - if (call_firmware_op(set_cpu_boot_addr, phys_cpu, boot_addr)) > - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu)); > + if (call_firmware_op(set_cpu_boot_addr, core_id, boot_addr)) > + __raw_writel(boot_addr, cpu_boot_reg(core_id)); > } > } > > -- > 1.9.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Chander, On 20.04.2014 09:23, Chander Kashyap wrote: > Hi Tomasz, > > > On 18 April 2014 20:12, Tomasz Figa <t.figa@samsung.com> wrote: >> When CPU topology is specified in device tree, cpu_logical_map() does >> not return core ID anymore, but rather full MPIDR value. This breaks >> existing calculation of PMU register offsets on Exynos SoCs. >> >> This patch fixes the problem by adjusting the code to use only core ID >> bits of the value returned by cpu_logical_map() to allow CPU topology to >> be specified in device tree on Exynos SoCs. >> >> Signed-off-by: Tomasz Figa <t.figa@samsung.com> >> --- >> arch/arm/mach-exynos/hotplug.c | 10 ++++++---- >> arch/arm/mach-exynos/platsmp.c | 31 ++++++++++++++++++------------- >> 2 files changed, 24 insertions(+), 17 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c >> index 7e0f31a..8a5f07d 100644 >> --- a/arch/arm/mach-exynos/hotplug.c >> +++ b/arch/arm/mach-exynos/hotplug.c >> @@ -92,11 +92,13 @@ static inline void cpu_leave_lowpower(void) >> >> static inline void platform_do_lowpower(unsigned int cpu, int *spurious) >> { >> + u32 mpidr = cpu_logical_map(cpu); >> + u32 core_id = MPIDR_AFFINITY_LEVEL(mpidr, 0); >> + >> for (;;) { >> >> - /* make cpu1 to be turned off at next WFI command */ >> - if (cpu == 1) >> - __raw_writel(0, S5P_ARM_CORE_CONFIGURATION(1)); > > I think this macro is not yet in ML code. What do you mean? The S5P_ARM_CORE_CONFIGURATION() macro is being added by patch 1/4. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c index 7e0f31a..8a5f07d 100644 --- a/arch/arm/mach-exynos/hotplug.c +++ b/arch/arm/mach-exynos/hotplug.c @@ -92,11 +92,13 @@ static inline void cpu_leave_lowpower(void) static inline void platform_do_lowpower(unsigned int cpu, int *spurious) { + u32 mpidr = cpu_logical_map(cpu); + u32 core_id = MPIDR_AFFINITY_LEVEL(mpidr, 0); + for (;;) { - /* make cpu1 to be turned off at next WFI command */ - if (cpu == 1) - __raw_writel(0, S5P_ARM_CORE_CONFIGURATION(1)); + /* Turn the CPU off on next WFI instruction. */ + __raw_writel(0, S5P_ARM_CORE_CONFIGURATION(core_id)); /* * here's the WFI @@ -106,7 +108,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) : : "memory", "cc"); - if (pen_release == cpu_logical_map(cpu)) { + if (pen_release == core_id) { /* * OK, proper wakeup, we're done */ diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c index 7b7de4b..e08b2c5 100644 --- a/arch/arm/mach-exynos/platsmp.c +++ b/arch/arm/mach-exynos/platsmp.c @@ -89,7 +89,9 @@ static void exynos_secondary_init(unsigned int cpu) static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle) { unsigned long timeout; - unsigned long phys_cpu = cpu_logical_map(cpu); + u32 mpidr = cpu_logical_map(cpu); + u32 core_id = MPIDR_AFFINITY_LEVEL(mpidr, 0); + u32 reg; /* * Set synchronisation state between this boot processor @@ -102,19 +104,20 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle) * the holding pen - release it, then wait for it to flag * that it has been released by resetting pen_release. * - * Note that "pen_release" is the hardware CPU ID, whereas + * Note that "pen_release" is the hardware CPU core ID, whereas * "cpu" is Linux's internal ID. */ - write_pen_release(phys_cpu); + write_pen_release(core_id); - if (!(__raw_readl(S5P_ARM_CORE_STATUS(1)) & S5P_CORE_LOCAL_PWR_EN)) { + reg = __raw_readl(S5P_ARM_CORE_STATUS(core_id)); + if (!(reg & S5P_CORE_LOCAL_PWR_EN)) { __raw_writel(S5P_CORE_LOCAL_PWR_EN, - S5P_ARM_CORE_CONFIGURATION(1)); + S5P_ARM_CORE_CONFIGURATION(core_id)); timeout = 10; /* wait max 10 ms until cpu1 is on */ - while ((__raw_readl(S5P_ARM_CORE_STATUS(1)) + while ((__raw_readl(S5P_ARM_CORE_STATUS(core_id)) & S5P_CORE_LOCAL_PWR_EN) != S5P_CORE_LOCAL_PWR_EN) { if (timeout-- == 0) break; @@ -146,10 +149,10 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle) * Try to set boot address using firmware first * and fall back to boot register if it fails. */ - if (call_firmware_op(set_cpu_boot_addr, phys_cpu, boot_addr)) - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu)); + if (call_firmware_op(set_cpu_boot_addr, core_id, boot_addr)) + __raw_writel(boot_addr, cpu_boot_reg(core_id)); - call_firmware_op(cpu_boot, phys_cpu); + call_firmware_op(cpu_boot, core_id); arch_send_wakeup_ipi_mask(cpumask_of(cpu)); @@ -215,14 +218,16 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus) * boot register if it fails. */ for (i = 1; i < max_cpus; ++i) { - unsigned long phys_cpu; unsigned long boot_addr; + u32 mpidr; + u32 core_id; - phys_cpu = cpu_logical_map(i); + mpidr = cpu_logical_map(i); + core_id = MPIDR_AFFINITY_LEVEL(mpidr, 0); boot_addr = virt_to_phys(exynos4_secondary_startup); - if (call_firmware_op(set_cpu_boot_addr, phys_cpu, boot_addr)) - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu)); + if (call_firmware_op(set_cpu_boot_addr, core_id, boot_addr)) + __raw_writel(boot_addr, cpu_boot_reg(core_id)); } }
When CPU topology is specified in device tree, cpu_logical_map() does not return core ID anymore, but rather full MPIDR value. This breaks existing calculation of PMU register offsets on Exynos SoCs. This patch fixes the problem by adjusting the code to use only core ID bits of the value returned by cpu_logical_map() to allow CPU topology to be specified in device tree on Exynos SoCs. Signed-off-by: Tomasz Figa <t.figa@samsung.com> --- arch/arm/mach-exynos/hotplug.c | 10 ++++++---- arch/arm/mach-exynos/platsmp.c | 31 ++++++++++++++++++------------- 2 files changed, 24 insertions(+), 17 deletions(-)