| Message ID | 1398487933-5683-7-git-send-email-shc_work@mail.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 26-04-2014 8:52, Alexander Shiyan wrote: > This patch reduce node name for FEC. Otherwise, the name for PHY > is composed incorrectly. > Before: > fec 1002b000.ethernet eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.etherne:00, irq=-1) > After: > fec 1002b000.fec eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.fec-1:00, irq=-1) > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > --- > arch/arm/boot/dts/imx27.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > index a75555c..377339e 100644 > --- a/arch/arm/boot/dts/imx27.dtsi > +++ b/arch/arm/boot/dts/imx27.dtsi > @@ -497,7 +497,7 @@ > clocks = <&clks 38>; > }; > > - fec: ethernet@1002b000 { > + fec: fec@1002b000 { The "ethernet" name complies to the ePAPR standard. Don't change it, please. WBR, Sergei
Sat, 26 Apr 2014 20:32:18 +0400 ?? Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>: > Hello. > > On 26-04-2014 8:52, Alexander Shiyan wrote: > > > This patch reduce node name for FEC. Otherwise, the name for PHY > > is composed incorrectly. > > > Before: > > fec 1002b000.ethernet eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.etherne:00, irq=-1) > > > After: > > fec 1002b000.fec eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.fec-1:00, irq=-1) > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > > --- > > arch/arm/boot/dts/imx27.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > > index a75555c..377339e 100644 > > --- a/arch/arm/boot/dts/imx27.dtsi > > +++ b/arch/arm/boot/dts/imx27.dtsi > > @@ -497,7 +497,7 @@ > > clocks = <&clks 38>; > > }; > > > > - fec: ethernet@1002b000 { > > + fec: fec@1002b000 { > > The "ethernet" name complies to the ePAPR standard. Don't change it, please. So this is ok? mii_bus:phy_addr=1002b000.etherne:00 ---
Hello. On 26-04-2014 20:39, Alexander Shiyan wrote: >>> This patch reduce node name for FEC. Otherwise, the name for PHY >>> is composed incorrectly. >>> Before: >>> fec 1002b000.ethernet eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.etherne:00, irq=-1) >>> After: >>> fec 1002b000.fec eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.fec-1:00, irq=-1) >>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru> >>> --- >>> arch/arm/boot/dts/imx27.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi >>> index a75555c..377339e 100644 >>> --- a/arch/arm/boot/dts/imx27.dtsi >>> +++ b/arch/arm/boot/dts/imx27.dtsi >>> @@ -497,7 +497,7 @@ >>> clocks = <&clks 38>; >>> }; >>> >>> - fec: ethernet@1002b000 { >>> + fec: fec@1002b000 { >> The "ethernet" name complies to the ePAPR standard. Don't change it, please. > So this is ok? > mii_bus:phy_addr=1002b000.etherne:00 Why not? :-) WBR, Sergei
Sat, 26 Apr 2014 20:54:11 +0400 ?? Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>: > Hello. > > On 26-04-2014 20:39, Alexander Shiyan wrote: > > >>> This patch reduce node name for FEC. Otherwise, the name for PHY > >>> is composed incorrectly. > > >>> Before: > >>> fec 1002b000.ethernet eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.etherne:00, irq=-1) > > >>> After: > >>> fec 1002b000.fec eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.fec-1:00, irq=-1) > > >>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > >>> --- > >>> arch/arm/boot/dts/imx27.dtsi | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi > >>> index a75555c..377339e 100644 > >>> --- a/arch/arm/boot/dts/imx27.dtsi > >>> +++ b/arch/arm/boot/dts/imx27.dtsi > >>> @@ -497,7 +497,7 @@ > >>> clocks = <&clks 38>; > >>> }; > >>> > >>> - fec: ethernet@1002b000 { > >>> + fec: fec@1002b000 { > > >> The "ethernet" name complies to the ePAPR standard. Don't change it, please. > > > So this is ok? > > mii_bus:phy_addr=1002b000.etherne:00 > > Why not? :-) OK if so. Shawn, please skip this one patch if all other looks OK. ---
diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi index a75555c..377339e 100644 --- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -497,7 +497,7 @@ clocks = <&clks 38>; }; - fec: ethernet@1002b000 { + fec: fec@1002b000 { compatible = "fsl,imx27-fec"; reg = <0x1002b000 0x4000>; interrupts = <50>;
This patch reduce node name for FEC. Otherwise, the name for PHY is composed incorrectly. Before: fec 1002b000.ethernet eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.etherne:00, irq=-1) After: fec 1002b000.fec eth0: Freescale FEC PHY driver [Generic PHY] (mii_bus:phy_addr=1002b000.fec-1:00, irq=-1) Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- arch/arm/boot/dts/imx27.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)