| Message ID | 20140428150300.GB19879@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Il 28/04/2014 17:03, Oleg Nesterov ha scritto: > async_pf_execute() passes tsk == current to gup(), this is doesn't > hurt but unnecessary and misleading. "tsk" is only used to account > the number of faults and current is the random workqueue thread. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> > --- > virt/kvm/async_pf.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/virt/kvm/async_pf.c b/virt/kvm/async_pf.c > index 0ced4f3..62f4223 100644 > --- a/virt/kvm/async_pf.c > +++ b/virt/kvm/async_pf.c > @@ -81,7 +81,7 @@ static void async_pf_execute(struct work_struct *work) > might_sleep(); > > down_read(&mm->mmap_sem); > - get_user_pages(current, mm, addr, 1, 1, 0, NULL, NULL); > + get_user_pages(NULL, mm, addr, 1, 1, 0, NULL, NULL); > up_read(&mm->mmap_sem); > kvm_async_page_present_sync(vcpu, apf); > > Thanks, added a Suggested-by for Andrea and applied together with 1/2 to kvm/queue. (Actually, I'm back from a longish vacation and I have a pretty large queue, so I haven't even compile tested these for now. Once I get round to at least smoke-test them, I'll really push to kvm/queue). Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/virt/kvm/async_pf.c b/virt/kvm/async_pf.c index 0ced4f3..62f4223 100644 --- a/virt/kvm/async_pf.c +++ b/virt/kvm/async_pf.c @@ -81,7 +81,7 @@ static void async_pf_execute(struct work_struct *work) might_sleep(); down_read(&mm->mmap_sem); - get_user_pages(current, mm, addr, 1, 1, 0, NULL, NULL); + get_user_pages(NULL, mm, addr, 1, 1, 0, NULL, NULL); up_read(&mm->mmap_sem); kvm_async_page_present_sync(vcpu, apf);
async_pf_execute() passes tsk == current to gup(), this is doesn't hurt but unnecessary and misleading. "tsk" is only used to account the number of faults and current is the random workqueue thread. Signed-off-by: Oleg Nesterov <oleg@redhat.com> --- virt/kvm/async_pf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)