| Message ID | 1398770316-19715-2-git-send-email-kaixu.xia@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a2915d4fefd41efeb76124dadf7a9cb78bff24ad |
| Headers | show |
On Tue, 29 Apr 2014, Xia Kaixu wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Building ARM randconfig got into a situation where CONFIG_INPUT > is turned off and SND_SOC_ALL_CODECS is turned on, which failed > for two codecs trying to use the input subsystem. Some other > drivers also select one of these codecs and consequently need an > explicit dependency added. I assume you mean the CS42L52 instead of the L51. INPUT is used for a BEEP Generator but when I disable CONFIG_INPUT I do not get an error. Is there any information available on what the error is? > > Appending to the dependency list seems the easiest way out, > since this is not a practical limitation. If anyone really > needs to build these codecs for a kernel with no input support, > a more sophisticated solution can be implemented. > It shouldn't build the BEEP code without CONFIG_INPUT enabled as you can use the CODEC without the BEEP enabled. I believe the WM8962 is done the same way. Thanks, Brian
On Tue, Apr 29, 2014 at 07:18:22PM +0800, Xia Kaixu wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Building ARM randconfig got into a situation where CONFIG_INPUT > is turned off and SND_SOC_ALL_CODECS is turned on, which failed > for two codecs trying to use the input subsystem. Some other Applied, but... > Cc: Mark Brown <broonie@kernel.org> > Cc: Liam Girdwood <lrg@slimlogic.co.uk> > Cc: Ben Dooks <ben-linux@fluff.org> > Cc: Kukjin Kim <kgene.kim@samsung.com> > Cc: Sangbeom Kim <sbkim73@samsung.com> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Timur Tabi <timur@tabi.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-input@vger.kernel.org > Cc: alsa-devel@alsa-project.org ...please don't include noise like this in patch submissions, especially with such long lists (which still manage to miss the driver maintainers concerned).
On Tue, Apr 29, 2014 at 09:31:30PM -0500, Brian Austin wrote: > I assume you mean the CS42L52 instead of the L51. INPUT is used for a BEEP > Generator but when I disable CONFIG_INPUT I do not get an error. Is there > any information available on what the error is? I suspect it's ASoC built in and INPUT build as a module.
> On Apr 30, 2014, at 20:31, "Mark Brown" <broonie@kernel.org> wrote: > >> On Tue, Apr 29, 2014 at 09:31:30PM -0500, Brian Austin wrote: >> >> I assume you mean the CS42L52 instead of the L51. INPUT is used for a BEEP >> Generator but when I disable CONFIG_INPUT I do not get an error. Is there >> any information available on what the error is? > > I suspect it's ASoC built in and INPUT build as a module. Ok, I'll try that next. Doesn't IS_ENABLED cover that?
On Apr 30, 2014, at 8:54 PM, Austin, Brian <Brian.Austin@cirrus.com> wrote: > > >> On Apr 30, 2014, at 20:31, "Mark Brown" <broonie@kernel.org> wrote: >> >>> On Tue, Apr 29, 2014 at 09:31:30PM -0500, Brian Austin wrote: >>> >>> I assume you mean the CS42L52 instead of the L51. INPUT is used for a BEEP >>> Generator but when I disable CONFIG_INPUT I do not get an error. Is there >>> any information available on what the error is? >> >> I suspect it's ASoC built in and INPUT build as a module. > Ok, I'll try that next. > Doesn't IS_ENABLED cover that? Apparently not. I would like to come up with a better solution than making INPUT a requirement. I just need some time. In the meantime I suppose it’s OK to apply it?
On Thu, May 01, 2014 at 02:16:27AM +0000, Austin, Brian wrote: > Apparently not. > I would like to come up with a better solution than making INPUT a requirement. I just need some time. > In the meantime I suppose it’s OK to apply it? Yeah. Realistically it's probably not going to ever be a practical problem - the number of systems with audio but no input is likely to be very close to zero.
> On Apr 30, 2014, at 22:28, "Mark Brown" <broonie@kernel.org> wrote: > >> On Thu, May 01, 2014 at 02:16:27AM +0000, Austin, Brian wrote: >> >> Apparently not. >> I would like to come up with a better solution than making INPUT a requirement. I just need some time. >> In the meantime I suppose it’s OK to apply it? > > Yeah. Realistically it's probably not going to ever be a practical > problem - the number of systems with audio but no input is likely to be > very close to zero. Yeah, I'm just gonna go ahead and remove the #if's from the drivers then since it's required
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index f0e8401..d4260d3 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -40,7 +40,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_ALC5632 if I2C select SND_SOC_CQ0093VC if MFD_DAVINCI_VOICECODEC select SND_SOC_CS42L51 if I2C - select SND_SOC_CS42L52 if I2C + select SND_SOC_CS42L52 if I2C && INPUT select SND_SOC_CS42L73 if I2C select SND_SOC_CS4270 if I2C select SND_SOC_CS4271 if SND_SOC_I2C_AND_SPI @@ -127,7 +127,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_WM8955 if I2C select SND_SOC_WM8960 if I2C select SND_SOC_WM8961 if I2C - select SND_SOC_WM8962 if I2C + select SND_SOC_WM8962 if I2C && INPUT select SND_SOC_WM8971 if I2C select SND_SOC_WM8974 if I2C select SND_SOC_WM8978 if I2C @@ -282,7 +282,7 @@ config SND_SOC_CS42L51 config SND_SOC_CS42L52 tristate "Cirrus Logic CS42L52 CODEC" - depends on I2C + depends on I2C && INPUT config SND_SOC_CS42L73 tristate "Cirrus Logic CS42L73 CODEC" @@ -598,7 +598,7 @@ config SND_SOC_WM8961 config SND_SOC_WM8962 tristate "Wolfson Microelectronics WM8962 CODEC" - depends on I2C + depends on I2C && INPUT config SND_SOC_WM8971 tristate diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 338a916..f4069d0 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -187,7 +187,7 @@ config SND_SOC_EUKREA_TLV320 config SND_SOC_IMX_WM8962 tristate "SoC Audio support for i.MX boards with wm8962" - depends on OF && I2C + depends on OF && I2C && INPUT select SND_SOC_WM8962 select SND_SOC_IMX_PCM_DMA select SND_SOC_IMX_AUDMUX diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig index f2e2891..14568be 100644 --- a/sound/soc/samsung/Kconfig +++ b/sound/soc/samsung/Kconfig @@ -204,7 +204,7 @@ config SND_SOC_SPEYSIDE config SND_SOC_TOBERMORY tristate "Audio support for Wolfson Tobermory" - depends on SND_SOC_SAMSUNG && MACH_WLF_CRAGG_6410 + depends on SND_SOC_SAMSUNG && MACH_WLF_CRAGG_6410 && INPUT select SND_SAMSUNG_I2S select SND_SOC_WM8962