| Message ID | 200907232056.51064.elendil@planet.nl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>>>> "Sam" == Sam Ravnborg <sam@ravnborg.org> writes:
Sam> On Thu, Jul 23, 2009 at 08:56:50PM +0200, Frans Pop wrote:
Sam> The above change is correct. But I really wonder if the original
Sam> code was correct? Do we really only want to use the -mtune
Sam> options for this specific gcc version? If this is indeed the
Sam> case this deserves a comment explaning this.
I suspect it should be all compilers after this one. -mtune=mckinley didn't
work very well in the early gcc 3 compilers and didn't exist in
version 2.
--
Dr Peter Chubb http://www.gelato.unsw.edu.au peterc@gelato.unsw.edu.au
http://www.ertos.nicta.com.au ERTOS within National ICT Australia
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 24 July 2009, Peter Chubb wrote: > >>>>> "Sam" == Sam Ravnborg <sam@ravnborg.org> writes: > Sam> The above change is correct. But I really wonder if the original > Sam> code was correct? Do we really only want to use the -mtune > Sam> options for this specific gcc version? If this is indeed the > Sam> case this deserves a comment explaning this. > > I suspect it should be all compilers after this one. -mtune=mckinley > didn't work very well in the early gcc 3 compilers and didn't exist in > version 2. How would you like to handle that? As it is essentially a separate issue, my suggestion would be: apply my patch as is and then (if needed) commit a separate patch to fix the incorrect comparisons on top. Cheers, FJP -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/ia64/Makefile b/arch/ia64/Makefile index 58a7e46..2bf6107 100644 --- a/arch/ia64/Makefile +++ b/arch/ia64/Makefile @@ -41,10 +41,8 @@ $(error Sorry, you need a newer version of the assember, one that is built from ftp://ftp.hpl.hp.com/pub/linux-ia64/gas-030124.tar.gz) endif -ifeq ($(call cc-version),0304) - cflags-$(CONFIG_ITANIUM) += -mtune=merced - cflags-$(CONFIG_MCKINLEY) += -mtune=mckinley -endif +cflags-$(CONFIG_ITANIUM) += $(call cc-ifversion, -eq, 0304, -mtune=merced) +cflags-$(CONFIG_MCKINLEY) += $(call cc-ifversion, -eq, 0304, -mtune=mckinley) KBUILD_CFLAGS += $(cflags-y) head-y := arch/ia64/kernel/head.o arch/ia64/kernel/init_task.o
Signed-off-by: Frans Pop <elendil@planet.nl> --- Change was suggested by Sam Ravnborg; see http://lkml.org/lkml/2009/7/18/15. Untested. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html