| Message ID | 1398054547-5834-1-git-send-email-wenyou.yang@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On 21/04/2014 at 12:29:07 +0800, Wenyou Yang wrote : > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > --- > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 42 +++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > index ce13755..57cdd83 100644 > --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > @@ -48,6 +48,48 @@ > > i2c1: i2c@f0018000 { > status = "okay"; > + > + pmic: act8865@5b { > + compatible = "active-semi,act8865"; > + reg = <0x5b>; > + status = "okay"; > + > + regulators { > + vcc_1v8_reg: DCDC_REG1 { > + regulator-name = "VCC_1V8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + > + vcc_1v2_reg: DCDC_REG2 { > + regulator-name = "VCC_1V2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-always-on; > + }; > + > + vcc_3v3_reg: DCDC_REG3 { > + regulator-name = "VCC_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vddfuse_reg: LDO_REG1 { > + regulator-name = "FUSE_2V5"; > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <2500000>; > + }; > + > + vddana_reg: LDO_REG2 { > + regulator-name = "VDDANA"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; I'm pretty sure that one is not always on as you actually have to configure it to get any voltage. Are you sure you want to set the regulator-always-on property here ? > + }; > + }; > + }; > }; > > macb0: ethernet@f0028000 { > -- > 1.7.9.5 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 21/04/2014 at 11:54:43 +0200, Alexandre Belloni wrote : > Hi, > > On 21/04/2014 at 12:29:07 +0800, Wenyou Yang wrote : > > + > > + vddana_reg: LDO_REG2 { > > + regulator-name = "VDDANA"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > I'm pretty sure that one is not always on as you actually have to > configure it to get any voltage. Are you sure you want to set the > regulator-always-on property here ? > Just to clarify my though, wouldn't it be better to make the ADC driver handle that regulator instead of using regulator-always-on ?
Hi, > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com] > Sent: Monday, April 21, 2014 8:22 PM > To: Yang, Wenyou > Cc: devicetree@vger.kernel.org; Ferre, Nicolas; linux- > kernel@vger.kernel.org; robh+dt@kernel.org; broonie@kernel.org; linux- > arm-kernel@lists.infradead.org > Subject: Re: [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator > device node > > On 21/04/2014 at 11:54:43 +0200, Alexandre Belloni wrote : > > Hi, > > > > On 21/04/2014 at 12:29:07 +0800, Wenyou Yang wrote : > > > + > > > + vddana_reg: LDO_REG2 { > > > + regulator-name = "VDDANA"; > > > + regulator-min-microvolt = > <3300000>; > > > + regulator-max-microvolt = > <3300000>; > > > + regulator-always-on; > > > > I'm pretty sure that one is not always on as you actually have to > > configure it to get any voltage. Are you sure you want to set the > > regulator-always-on property here ? > > > > Just to clarify my though, wouldn't it be better to make the ADC driver > handle that regulator instead of using regulator-always-on ? Yes, you are right. It should not use regulator-always-on property for this regulator. It is ADC driver and ISI driver to handle it(The ISI takes PCK for clock). I will send new version patch. Thanks > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering http://free- > electrons.com Best Regards, Wenyou Yang
On 22/04/2014 03:37, Yang, Wenyou : > Hi, > >> -----Original Message----- >> From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com] >> Sent: Monday, April 21, 2014 8:22 PM >> To: Yang, Wenyou >> Cc: devicetree@vger.kernel.org; Ferre, Nicolas; linux- >> kernel@vger.kernel.org; robh+dt@kernel.org; broonie@kernel.org; linux- >> arm-kernel@lists.infradead.org >> Subject: Re: [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator >> device node >> >> On 21/04/2014 at 11:54:43 +0200, Alexandre Belloni wrote : >>> Hi, >>> >>> On 21/04/2014 at 12:29:07 +0800, Wenyou Yang wrote : >>>> + >>>> + vddana_reg: LDO_REG2 { >>>> + regulator-name = "VDDANA"; >>>> + regulator-min-microvolt = >> <3300000>; >>>> + regulator-max-microvolt = >> <3300000>; >>>> + regulator-always-on; >>> >>> I'm pretty sure that one is not always on as you actually have to >>> configure it to get any voltage. Are you sure you want to set the >>> regulator-always-on property here ? >>> >> >> Just to clarify my though, wouldn't it be better to make the ADC driver >> handle that regulator instead of using regulator-always-on ? > Yes, you are right. > It should not use regulator-always-on property for this regulator. > It is ADC driver and ISI driver to handle it(The ISI takes PCK for clock). Hi Wenyou and Alexandre, After talking to our system engineers, it not usual to avoid to power the VDDANA rail. In fact it will prevent you to use all the pads that are powered by VDDANA: PD20-PD31. Moreover, even if you do not activate the ADC output on these lines you won't be able to use them as plain GPIO... (Cf. package and pinout section of the datasheet). As the ADVREF pin of the SoC is connected to the VDDANA on this board (even if this default configuration can be modified with a soldering iron), we have to note that we may consume a little bit more power. But still, I would recommend to keep the "regulator-always-on" property on this node. Do you agree and allow me to take your first revision of the patch? Bye,
> -----Original Message----- > From: Ferre, Nicolas > Sent: Friday, May 09, 2014 11:31 PM > To: Yang, Wenyou; Alexandre Belloni > Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > robh+dt@kernel.org; broonie@kernel.org; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator > device node > > On 22/04/2014 03:37, Yang, Wenyou : > > Hi, > > > >> -----Original Message----- > >> From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com] > >> Sent: Monday, April 21, 2014 8:22 PM > >> To: Yang, Wenyou > >> Cc: devicetree@vger.kernel.org; Ferre, Nicolas; linux- > >> kernel@vger.kernel.org; robh+dt@kernel.org; broonie@kernel.org; > >> linux- arm-kernel@lists.infradead.org > >> Subject: Re: [PATCH] ARM: dts: at91-sama5d3_xplained: add the > >> regulator device node > >> > >> On 21/04/2014 at 11:54:43 +0200, Alexandre Belloni wrote : > >>> Hi, > >>> > >>> On 21/04/2014 at 12:29:07 +0800, Wenyou Yang wrote : > >>>> + > >>>> + vddana_reg: LDO_REG2 { > >>>> + regulator-name = > "VDDANA"; > >>>> + regulator-min-microvolt > = > >> <3300000>; > >>>> + regulator-max-microvolt > = > >> <3300000>; > >>>> + regulator-always-on; > >>> > >>> I'm pretty sure that one is not always on as you actually have to > >>> configure it to get any voltage. Are you sure you want to set the > >>> regulator-always-on property here ? > >>> > >> > >> Just to clarify my though, wouldn't it be better to make the ADC > >> driver handle that regulator instead of using regulator-always-on ? > > Yes, you are right. > > It should not use regulator-always-on property for this regulator. > > It is ADC driver and ISI driver to handle it(The ISI takes PCK for > clock). > > Hi Wenyou and Alexandre, > > After talking to our system engineers, it not usual to avoid to power > the VDDANA rail. In fact it will prevent you to use all the pads that > are powered by VDDANA: PD20-PD31. Moreover, even if you do not activate > the ADC output on these lines you won't be able to use them as plain > GPIO... (Cf. package and pinout section of the datasheet). > > As the ADVREF pin of the SoC is connected to the VDDANA on this board > (even if this default configuration can be modified with a soldering > iron), we have to note that we may consume a little bit more power. > > But still, I would recommend to keep the "regulator-always-on" property > on this node. Do you agree and allow me to take your first revision of > the patch? I agree. > > > Bye, > -- > Nicolas Ferre Best Regards, Wenyou Yang
On 21/04/2014 06:29, Wenyou Yang : > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Stacked on the at91-3.16-dt2 branch. Thanks, bye, > --- > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 42 +++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > index ce13755..57cdd83 100644 > --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > @@ -48,6 +48,48 @@ > > i2c1: i2c@f0018000 { > status = "okay"; > + > + pmic: act8865@5b { > + compatible = "active-semi,act8865"; > + reg = <0x5b>; > + status = "okay"; > + > + regulators { > + vcc_1v8_reg: DCDC_REG1 { > + regulator-name = "VCC_1V8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + > + vcc_1v2_reg: DCDC_REG2 { > + regulator-name = "VCC_1V2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-always-on; > + }; > + > + vcc_3v3_reg: DCDC_REG3 { > + regulator-name = "VCC_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vddfuse_reg: LDO_REG1 { > + regulator-name = "FUSE_2V5"; > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <2500000>; > + }; > + > + vddana_reg: LDO_REG2 { > + regulator-name = "VDDANA"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + }; > + }; > }; > > macb0: ethernet@f0028000 { >
diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts index ce13755..57cdd83 100644 --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts @@ -48,6 +48,48 @@ i2c1: i2c@f0018000 { status = "okay"; + + pmic: act8865@5b { + compatible = "active-semi,act8865"; + reg = <0x5b>; + status = "okay"; + + regulators { + vcc_1v8_reg: DCDC_REG1 { + regulator-name = "VCC_1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + + vcc_1v2_reg: DCDC_REG2 { + regulator-name = "VCC_1V2"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + }; + + vcc_3v3_reg: DCDC_REG3 { + regulator-name = "VCC_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vddfuse_reg: LDO_REG1 { + regulator-name = "FUSE_2V5"; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; + }; + + vddana_reg: LDO_REG2 { + regulator-name = "VDDANA"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + }; + }; }; macb0: ethernet@f0028000 {
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 42 +++++++++++++++++++++++++++ 1 file changed, 42 insertions(+)