| Message ID | 4525493.CM3akEXMYf@wuerfel (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Friday, May 09, 2014 8:36 PM, Arnd Bergmann wrote: > > As we are preparing to enable multiplatform support on EXYNOS, > we can no longer include mach/*.h or plat/*.h headers from device > drivers. > > The s5p-sss driver was just enabled for EXYNOS when it used to > be used only on s5pv210, and it includes two samsung platform > specific header files for historic reasons. Fortunately, it no > longer actually needs them, so we can remove the #includes and > avoid the problem > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com> > Cc: Tomasz Figa <t.figa@samsung.com> > Cc: <linux-samsung-soc@vger.kernel.org> > Cc: Vladimir Zapolskiy <vz@mleia.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> I checked that these machine specific headers are unnecessary. Thanks! Reviewed-by: Jingoo Han <jg1.han@samsung.com> Best regards, Jingoo Han > --- > Please apply on top of the other s5p-sss patches > > diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c > index 47c568e..4197ad9 100644 > --- a/drivers/crypto/s5p-sss.c > +++ b/drivers/crypto/s5p-sss.c > @@ -30,9 +30,6 @@ > #include <crypto/aes.h> > #include <crypto/ctr.h> > > -#include <plat/cpu.h> > -#include <mach/dma.h> > - > #define _SBF(s, v) ((v) << (s)) > #define _BIT(b) _SBF(b, 1) > > > -- -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 12, 2014 at 11:31:05AM +0900, Jingoo Han wrote: > On Friday, May 09, 2014 8:36 PM, Arnd Bergmann wrote: > > > > As we are preparing to enable multiplatform support on EXYNOS, > > we can no longer include mach/*.h or plat/*.h headers from device > > drivers. > > > > The s5p-sss driver was just enabled for EXYNOS when it used to > > be used only on s5pv210, and it includes two samsung platform > > specific header files for historic reasons. Fortunately, it no > > longer actually needs them, so we can remove the #includes and > > avoid the problem > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com> > > Cc: Tomasz Figa <t.figa@samsung.com> > > Cc: <linux-samsung-soc@vger.kernel.org> > > Cc: Vladimir Zapolskiy <vz@mleia.com> > > Cc: Herbert Xu <herbert@gondor.apana.org.au> > > I checked that these machine specific headers are > unnecessary. Thanks! > > Reviewed-by: Jingoo Han <jg1.han@samsung.com> Patch applied. Thanks!
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index 47c568e..4197ad9 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -30,9 +30,6 @@ #include <crypto/aes.h> #include <crypto/ctr.h> -#include <plat/cpu.h> -#include <mach/dma.h> - #define _SBF(s, v) ((v) << (s)) #define _BIT(b) _SBF(b, 1)
As we are preparing to enable multiplatform support on EXYNOS, we can no longer include mach/*.h or plat/*.h headers from device drivers. The s5p-sss driver was just enabled for EXYNOS when it used to be used only on s5pv210, and it includes two samsung platform specific header files for historic reasons. Fortunately, it no longer actually needs them, so we can remove the #includes and avoid the problem Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com> Cc: Tomasz Figa <t.figa@samsung.com> Cc: <linux-samsung-soc@vger.kernel.org> Cc: Vladimir Zapolskiy <vz@mleia.com> Cc: Herbert Xu <herbert@gondor.apana.org.au> --- Please apply on top of the other s5p-sss patches -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html