| Message ID | 1400055865.31197.4.camel@x220 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Wed, 14 May 2014 10:24:25 +0200 ?? Paul Bolle <pebolle@tiscali.nl>: > Support for ARM710 CPUs was removed in v3.5. Now remove the last code > depending on its Kconfig macro. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > First submitted in March 2103. Still untested. Please note that > cpu_arm7_data_abort was also removed in v3.5. Russell usually apply such patches via the tracker. http://www.arm.linux.org.uk/developer/patches/ ---
On Wed, 2014-05-14 at 12:48 +0400, Alexander Shiyan wrote: > Russell usually apply such patches via the tracker. > > http://www.arm.linux.org.uk/developer/patches/ And that page tells me Please note: this is not a patch review system; please submit all patches to the linux-arm-kernel mailing list for community review prior to submission here. I've not been notified that my patch was added to that tracker, so it is appropriate to resend. Paul Bolle
On Wednesday 14 May 2014 10:24:25 Paul Bolle wrote: > Support for ARM710 CPUs was removed in v3.5. Now remove the last code > depending on its Kconfig macro. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > First submitted in March 2103. Still untested. Please note that > cpu_arm7_data_abort was also removed in v3.5. > 'git grep -i arm710' tells me that there is also some arm710 specific code in arch/arm/mm/proc-arm720.S that we may want to remove along with this. The DT binding should probably remain untouched though, I think it's correct to document the string. Arnd
On Wed, 2014-05-14 at 11:17 +0200, Arnd Bergmann wrote: > 'git grep -i arm710' tells me that there is also some arm710 > specific code in arch/arm/mm/proc-arm720.S that we may want to > remove along with this. > > The DT binding should probably remain untouched though, I think it's > correct to document the string. That seems to be cpu_arm710_name, __arm710_setup, and everything called by __arm710_setup. Cleaning that up (as a separate patch) appears to be trivial. If I do that it would be (sort of educated) guesswork. But I don't mind doing it. What do you prefer? Paul Bolle
On Wednesday 14 May 2014 11:25:50 Paul Bolle wrote: > On Wed, 2014-05-14 at 11:17 +0200, Arnd Bergmann wrote: > > 'git grep -i arm710' tells me that there is also some arm710 > > specific code in arch/arm/mm/proc-arm720.S that we may want to > > remove along with this. > > > > The DT binding should probably remain untouched though, I think it's > > correct to document the string. > > That seems to be cpu_arm710_name, __arm710_setup, and everything called > by __arm710_setup. Cleaning that up (as a separate patch) appears to be > trivial. If I do that it would be (sort of educated) guesswork. But I > don't mind doing it. What do you prefer? I think that would be great. For the first patch, please add Acked-by: Arnd Bergmann <arnd@arndb.de> Once the second patch is reviewed, please add them both to Russell's patch tracker. Arnd
On Wed, 2014-05-14 at 11:28 +0200, Arnd Bergmann wrote: > On Wednesday 14 May 2014 11:25:50 Paul Bolle wrote: > > On Wed, 2014-05-14 at 11:17 +0200, Arnd Bergmann wrote: > > > 'git grep -i arm710' tells me that there is also some arm710 > > > specific code in arch/arm/mm/proc-arm720.S that we may want to > > > remove along with this. > > > > > > The DT binding should probably remain untouched though, I think it's > > > correct to document the string. > > > > That seems to be cpu_arm710_name, __arm710_setup, and everything called > > by __arm710_setup. Cleaning that up (as a separate patch) appears to be > > trivial. If I do that it would be (sort of educated) guesswork. But I > > don't mind doing it. What do you prefer? > > I think that would be great. For the first patch, please add > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > Once the second patch is reviewed, please add them both to Russell's > patch tracker. Well, at least that second patch triggered a nice conversation. So I should now add the first patch (with your ACK) to the tracker? Paul Bolle
On Friday 23 May 2014 11:07:54 Paul Bolle wrote: > On Wed, 2014-05-14 at 11:28 +0200, Arnd Bergmann wrote: > > On Wednesday 14 May 2014 11:25:50 Paul Bolle wrote: > > > On Wed, 2014-05-14 at 11:17 +0200, Arnd Bergmann wrote: > > > > 'git grep -i arm710' tells me that there is also some arm710 > > > > specific code in arch/arm/mm/proc-arm720.S that we may want to > > > > remove along with this. > > > > > > > > The DT binding should probably remain untouched though, I think it's > > > > correct to document the string. > > > > > > That seems to be cpu_arm710_name, __arm710_setup, and everything called > > > by __arm710_setup. Cleaning that up (as a separate patch) appears to be > > > trivial. If I do that it would be (sort of educated) guesswork. But I > > > don't mind doing it. What do you prefer? > > > > I think that would be great. For the first patch, please add > > > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > > > Once the second patch is reviewed, please add them both to Russell's > > patch tracker. > > Well, at least that second patch triggered a nice conversation. So I > should now add the first patch (with your ACK) to the tracker? Yes, please do that. Arnd
diff --git a/arch/arm/include/asm/glue-df.h b/arch/arm/include/asm/glue-df.h index 6b70f1b46a6e..04e18b656659 100644 --- a/arch/arm/include/asm/glue-df.h +++ b/arch/arm/include/asm/glue-df.h @@ -31,14 +31,6 @@ #undef CPU_DABORT_HANDLER #undef MULTI_DABORT -#if defined(CONFIG_CPU_ARM710) -# ifdef CPU_DABORT_HANDLER -# define MULTI_DABORT 1 -# else -# define CPU_DABORT_HANDLER cpu_arm7_data_abort -# endif -#endif - #ifdef CONFIG_CPU_ABRT_EV4 # ifdef CPU_DABORT_HANDLER # define MULTI_DABORT 1
Support for ARM710 CPUs was removed in v3.5. Now remove the last code depending on its Kconfig macro. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- First submitted in March 2103. Still untested. Please note that cpu_arm7_data_abort was also removed in v3.5. arch/arm/include/asm/glue-df.h | 8 -------- 1 file changed, 8 deletions(-)