| Message ID | 1397454507-10273-4-git-send-email-shobhit.kumar@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Apr 14, 2014 at 11:18:26AM +0530, Shobhit Kumar wrote: > Added as generic parameters which will be initialized in the panel > driver and are specific to panels. > > Backlight delays have also kept as placeholders and will be used used > once we have MIPI backlight enabling support > > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> Just a small note on patch ordering, You're using values that no code initializes yet, doesn't matter at all this time. Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
On Thu, May 15, 2014 at 04:06:56PM +0100, Damien Lespiau wrote: > On Mon, Apr 14, 2014 at 11:18:26AM +0530, Shobhit Kumar wrote: > > Added as generic parameters which will be initialized in the panel > > driver and are specific to panels. > > > > Backlight delays have also kept as placeholders and will be used used > > once we have MIPI backlight enabling support > > > > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> > > Just a small note on patch ordering, You're using values that no code > initializes yet, doesn't matter at all this time. > > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com> Merged up to this one here, thanks for patches&review. -Daniel
diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c index 09b9318..0d4dd54 100644 --- a/drivers/gpu/drm/i915/intel_dsi.c +++ b/drivers/gpu/drm/i915/intel_dsi.c @@ -185,6 +185,8 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder) /* put device in ready state */ intel_dsi_device_ready(encoder); + msleep(intel_dsi->panel_on_delay); + if (intel_dsi->dev.dev_ops->panel_reset) intel_dsi->dev.dev_ops->panel_reset(&intel_dsi->dev); @@ -301,6 +303,9 @@ static void intel_dsi_post_disable(struct intel_encoder *encoder) if (intel_dsi->dev.dev_ops->disable_panel_power) intel_dsi->dev.dev_ops->disable_panel_power(&intel_dsi->dev); + + msleep(intel_dsi->panel_off_delay); + msleep(intel_dsi->panel_pwr_cycle_delay); } static bool intel_dsi_get_hw_state(struct intel_encoder *encoder, diff --git a/drivers/gpu/drm/i915/intel_dsi.h b/drivers/gpu/drm/i915/intel_dsi.h index be132c5..e3f4e91 100644 --- a/drivers/gpu/drm/i915/intel_dsi.h +++ b/drivers/gpu/drm/i915/intel_dsi.h @@ -116,6 +116,13 @@ struct intel_dsi { u16 clk_hs_to_lp_count; u16 init_count; + + /* all delays in ms */ + u16 backlight_off_delay; + u16 backlight_on_delay; + u16 panel_on_delay; + u16 panel_off_delay; + u16 panel_pwr_cycle_delay; }; static inline struct intel_dsi *enc_to_intel_dsi(struct drm_encoder *encoder)
Added as generic parameters which will be initialized in the panel driver and are specific to panels. Backlight delays have also kept as placeholders and will be used used once we have MIPI backlight enabling support Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> --- drivers/gpu/drm/i915/intel_dsi.c | 5 +++++ drivers/gpu/drm/i915/intel_dsi.h | 7 +++++++ 2 files changed, 12 insertions(+)