| Message ID | 1401187986-11059-3-git-send-email-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e7d23c56f989201b9f73a44e8512fa0bc304eef1 |
| Headers | show |
On 05/27/2014 12:53 PM, Peter Ujfalusi wrote: > Commit "cf7c1de20c576 ASoC: dapm: Move 'value' field from widget to > control" changed the way how the 'value' has been stored for a widget. > Since the driver is not updated following the mentioned commit it is mostly > broken when we try to change mixers for Left/Right PGA since the value is > not going to be updated correctly. I don't think the mentioned commit is the cause. The driver didn't set widget->value either, so there is no change in behavior here. The commit only changed where the value is stored not how it is handled. This driver uses a custom put handler and the generic get handler. dapm_kcontrol_get_value() is used in the generic get handler, but only if reg equal to SND_SOC_NOPM. Which is not the case for this driver. And that's the only place where the value stored for the kcontrol is used. I don't see how calling dapm_kcontrol_set_value() or not calling dapm_kcontrol_set_value() changes anything. I might be missing something, but I think the issue is somewhere else. - Lars
On 05/27/2014 02:18 PM, Lars-Peter Clausen wrote: > On 05/27/2014 12:53 PM, Peter Ujfalusi wrote: >> Commit "cf7c1de20c576 ASoC: dapm: Move 'value' field from widget to >> control" changed the way how the 'value' has been stored for a widget. >> Since the driver is not updated following the mentioned commit it is mostly >> broken when we try to change mixers for Left/Right PGA since the value is >> not going to be updated correctly. > > I don't think the mentioned commit is the cause. The driver didn't set > widget->value either, so there is no change in behavior here. The commit only > changed where the value is stored not how it is handled. Yes, exactly. The driver has not been updated after the place where the value is stored, so it is not going to store it at all, which causes issues along the way. > This driver uses a custom put handler and the generic get handler. > dapm_kcontrol_get_value() is used in the generic get handler, but only if reg > equal to SND_SOC_NOPM. Which is not the case for this driver. The relevant code is this: if (dapm_kcontrol_is_powered(kcontrol) && reg != SND_SOC_NOPM) val = (snd_soc_read(codec, reg) >> shift) & mask; else val = dapm_kcontrol_get_value(kcontrol); and when the widget is not powered the code will try to get the value from the dapm_kcontrol_data, which is not even touched by the custom code in the driver. > And that's the > only place where the value stored for the kcontrol is used. I don't see how > calling dapm_kcontrol_set_value() or not calling dapm_kcontrol_set_value() > changes anything. When the widget is not powered the stored value is going to be used. The custom code in the driver should mimic the code from the core which it is set to replace/customize. > > I might be missing something, but I think the issue is somewhere else. > > - Lars
On 05/27/2014 01:41 PM, Peter Ujfalusi wrote: > On 05/27/2014 02:18 PM, Lars-Peter Clausen wrote: >> On 05/27/2014 12:53 PM, Peter Ujfalusi wrote: >>> Commit "cf7c1de20c576 ASoC: dapm: Move 'value' field from widget to >>> control" changed the way how the 'value' has been stored for a widget. >>> Since the driver is not updated following the mentioned commit it is mostly >>> broken when we try to change mixers for Left/Right PGA since the value is >>> not going to be updated correctly. >> >> I don't think the mentioned commit is the cause. The driver didn't set >> widget->value either, so there is no change in behavior here. The commit only >> changed where the value is stored not how it is handled. > > Yes, exactly. The driver has not been updated after the place where the value > is stored, so it is not going to store it at all, which causes issues along > the way. Before the patch the value was stored in widget->value, after the patch the value is stored in the kcontrol. The tlv320aic3x driver did not store anything in widget->value before the patch and neither does it store anything in the kcontrol after the patch. > >> This driver uses a custom put handler and the generic get handler. >> dapm_kcontrol_get_value() is used in the generic get handler, but only if reg >> equal to SND_SOC_NOPM. Which is not the case for this driver. > > The relevant code is this: > if (dapm_kcontrol_is_powered(kcontrol) && reg != SND_SOC_NOPM) > val = (snd_soc_read(codec, reg) >> shift) & mask; > else > val = dapm_kcontrol_get_value(kcontrol); > > and when the widget is not powered the code will try to get the value from the > dapm_kcontrol_data, which is not even touched by the custom code in the driver. dapm_kcontrol_is_powered() always returns true if the control is not a auto-muted control. And there are no auto-muted controls in the tlv320aix3c driver. There are two cases where dapm_kcontrol_get_value() can be called a) The control is a virtual control b) The control is a auto-muted control Neither is the case here, which is why I expect that the real issue is something else and it is just shadowed by this patch. - Lars
On 05/27/2014 01:54 PM, Lars-Peter Clausen wrote: > On 05/27/2014 01:41 PM, Peter Ujfalusi wrote: >> On 05/27/2014 02:18 PM, Lars-Peter Clausen wrote: >>> On 05/27/2014 12:53 PM, Peter Ujfalusi wrote: >>>> Commit "cf7c1de20c576 ASoC: dapm: Move 'value' field from widget to >>>> control" changed the way how the 'value' has been stored for a widget. >>>> Since the driver is not updated following the mentioned commit it is mostly >>>> broken when we try to change mixers for Left/Right PGA since the value is >>>> not going to be updated correctly. >>> >>> I don't think the mentioned commit is the cause. The driver didn't set >>> widget->value either, so there is no change in behavior here. The commit >>> only >>> changed where the value is stored not how it is handled. >> >> Yes, exactly. The driver has not been updated after the place where the value >> is stored, so it is not going to store it at all, which causes issues along >> the way. > > Before the patch the value was stored in widget->value, after the patch the > value is stored in the kcontrol. The tlv320aic3x driver did not store > anything in widget->value before the patch and neither does it store > anything in the kcontrol after the patch. > >> >>> This driver uses a custom put handler and the generic get handler. >>> dapm_kcontrol_get_value() is used in the generic get handler, but only if >>> reg >>> equal to SND_SOC_NOPM. Which is not the case for this driver. >> >> The relevant code is this: >> if (dapm_kcontrol_is_powered(kcontrol) && reg != SND_SOC_NOPM) >> val = (snd_soc_read(codec, reg) >> shift) & mask; >> else >> val = dapm_kcontrol_get_value(kcontrol); >> >> and when the widget is not powered the code will try to get the value from >> the >> dapm_kcontrol_data, which is not even touched by the custom code in the >> driver. > > dapm_kcontrol_is_powered() always returns true if the control is not a > auto-muted control. And there are no auto-muted controls in the tlv320aix3c > driver. > > There are two cases where dapm_kcontrol_get_value() can be called > a) The control is a virtual control > b) The control is a auto-muted control > > Neither is the case here, which is why I expect that the real issue is > something else and it is just shadowed by this patch. Picking up on that. What you changed in the patch is that you no longer return the return value of snd_soc_test_bits() to the upper layers. amixer will print "Invalid command!" if it got a error code. So I'd expect that snd_soc_test_bits() returns a error code, can you check that? - Lars
On 05/27/2014 02:54 PM, Lars-Peter Clausen wrote: > On 05/27/2014 01:41 PM, Peter Ujfalusi wrote: >> On 05/27/2014 02:18 PM, Lars-Peter Clausen wrote: >>> On 05/27/2014 12:53 PM, Peter Ujfalusi wrote: >>>> Commit "cf7c1de20c576 ASoC: dapm: Move 'value' field from widget to >>>> control" changed the way how the 'value' has been stored for a widget. >>>> Since the driver is not updated following the mentioned commit it is mostly >>>> broken when we try to change mixers for Left/Right PGA since the value is >>>> not going to be updated correctly. >>> >>> I don't think the mentioned commit is the cause. The driver didn't set >>> widget->value either, so there is no change in behavior here. The commit only >>> changed where the value is stored not how it is handled. >> >> Yes, exactly. The driver has not been updated after the place where the value >> is stored, so it is not going to store it at all, which causes issues along >> the way. > > Before the patch the value was stored in widget->value, after the patch the > value is stored in the kcontrol. The tlv320aic3x driver did not store anything > in widget->value before the patch and neither does it store anything in the > kcontrol after the patch. Sure it is not doing itself. When this custom function has been added it was essentially a copy of the snd_soc_dapm_put_volsw() - stripped down a bit copy. But it has not been updated for a long time to follow what is happening the the core underneath. I believe not many people uses these paths with the codec and this is why it has gone unnoticed. I might attempt to bisect this, but not really sure from which point this is broken (3.14, 3.12?). >>> This driver uses a custom put handler and the generic get handler. >>> dapm_kcontrol_get_value() is used in the generic get handler, but only if reg >>> equal to SND_SOC_NOPM. Which is not the case for this driver. >> >> The relevant code is this: >> if (dapm_kcontrol_is_powered(kcontrol) && reg != SND_SOC_NOPM) >> val = (snd_soc_read(codec, reg) >> shift) & mask; >> else >> val = dapm_kcontrol_get_value(kcontrol); >> >> and when the widget is not powered the code will try to get the value from the >> dapm_kcontrol_data, which is not even touched by the custom code in the driver. > > dapm_kcontrol_is_powered() always returns true if the control is not a > auto-muted control. And there are no auto-muted controls in the tlv320aix3c > driver. dapm_kcontrol_is_powered() returns the data->widget->power, which is not the automute state. Widgets do turn off when they are not in use, like in my system: # cat tlv320aic3x-codec.0-001b/dapm/Left\ PGA\ Mixer Left PGA Mixer: Off in 0 out 0 out "static" "Left ADC" So the widget's power is off. > > There are two cases where dapm_kcontrol_get_value() can be called > a) The control is a virtual control > b) The control is a auto-muted control > > Neither is the case here, which is why I expect that the real issue is > something else and it is just shadowed by this patch. > > - Lars
[...] >>>> This driver uses a custom put handler and the generic get handler. >>>> dapm_kcontrol_get_value() is used in the generic get handler, but only if reg >>>> equal to SND_SOC_NOPM. Which is not the case for this driver. >>> >>> The relevant code is this: >>> if (dapm_kcontrol_is_powered(kcontrol) && reg != SND_SOC_NOPM) >>> val = (snd_soc_read(codec, reg) >> shift) & mask; >>> else >>> val = dapm_kcontrol_get_value(kcontrol); >>> >>> and when the widget is not powered the code will try to get the value from the >>> dapm_kcontrol_data, which is not even touched by the custom code in the driver. >> >> dapm_kcontrol_is_powered() always returns true if the control is not a >> auto-muted control. And there are no auto-muted controls in the tlv320aix3c >> driver. > > dapm_kcontrol_is_powered() returns the data->widget->power, which is not the > automute state. Widgets do turn off when they are not in use, like in my system: > > # cat tlv320aic3x-codec.0-001b/dapm/Left\ PGA\ Mixer > Left PGA Mixer: Off in 0 out 0 > out "static" "Left ADC" > > So the widget's power is off. The widget that data->widget points to is not the mixer widget. It is the widget that is created for auto-mute handling if the control is auto-muted. It will be NULL in your case, which means dapm_kcontrol_is_powered() return true. - Lars
diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c index d7349bc89ad3..167c95bdf289 100644 --- a/sound/soc/codecs/tlv320aic3x.c +++ b/sound/soc/codecs/tlv320aic3x.c @@ -156,21 +156,21 @@ static int snd_soc_dapm_put_volsw_aic3x(struct snd_kcontrol *kcontrol, int connect, change; val = (ucontrol->value.integer.value[0] & mask); + connect = !!val; + + if (invert) + val = max - val; + + change = dapm_kcontrol_set_value(kcontrol, val); mask = 0xf; if (val) val = mask; - connect = !!val; - - if (invert) - val = mask - val; - mask <<= shift; val <<= shift; - change = snd_soc_test_bits(codec, val, mask, reg); - if (change) { + if (change && snd_soc_test_bits(codec, val, mask, reg)) { update.kcontrol = kcontrol; update.reg = reg; update.mask = mask;
Commit "cf7c1de20c576 ASoC: dapm: Move 'value' field from widget to control" changed the way how the 'value' has been stored for a widget. Since the driver is not updated following the mentioned commit it is mostly broken when we try to change mixers for Left/Right PGA since the value is not going to be updated correctly. This can be seen when trying to switch of one of the routes for the first time (the second try will succeed): amixer sset 'Left PGA Mixer Line1L' off amixer: Invalid command! Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- sound/soc/codecs/tlv320aic3x.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)