diff mbox

[v3,1/2] dmaengine: s3c24xx-dma: Process whole SG chain

Message ID 1400617382-7051-1-git-send-email-anarsoul@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Vasily Khoruzhick May 20, 2014, 8:23 p.m. UTC 
Due to redundant 'break' in loop driver processed only first chunk.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
v2: No changes
v3: No changes

 drivers/dma/s3c24xx-dma.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Heiko Stübner May 28, 2014, 8:03 p.m. UTC | #1 
Am Dienstag, 20. Mai 2014, 23:23:01 schrieb Vasily Khoruzhick:
> Due to redundant 'break' in loop driver processed only first chunk.
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>

I think I wrote this for v1 already, but here it is again.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
> v2: No changes
> v3: No changes
> 
>  drivers/dma/s3c24xx-dma.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c
> index 4eddedb..2167608 100644
> --- a/drivers/dma/s3c24xx-dma.c
> +++ b/drivers/dma/s3c24xx-dma.c
> @@ -961,7 +961,6 @@ static struct dma_async_tx_descriptor
> *s3c24xx_dma_prep_slave_sg( dsg->src_addr = slave_addr;
>  			dsg->dst_addr = sg_dma_address(sg);
>  		}
> -		break;
>  	}
> 
>  	return vchan_tx_prep(&s3cchan->vc, &txd->vd, flags);
Vinod Koul June 1, 2014, 3:47 p.m. UTC | #2 
On Tue, May 20, 2014 at 11:23:01PM +0300, Vasily Khoruzhick wrote:
> Due to redundant 'break' in loop driver processed only first chunk.
> 
Applied both, thanks
diff mbox

Patch

diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c
index 4eddedb..2167608 100644
--- a/drivers/dma/s3c24xx-dma.c
+++ b/drivers/dma/s3c24xx-dma.c
@@ -961,7 +961,6 @@  static struct dma_async_tx_descriptor *s3c24xx_dma_prep_slave_sg(
 			dsg->src_addr = slave_addr;
 			dsg->dst_addr = sg_dma_address(sg);
 		}
-		break;
 	}
 
 	return vchan_tx_prep(&s3cchan->vc, &txd->vd, flags);