| Message ID | 1402673558-15618-1-git-send-email-jbarnes@virtuousgeek.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jun 13, 2014 at 08:32:38AM -0700, Jesse Barnes wrote: > Early revs didn't have PPGTT support, so disable there. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=79669 > References: https://bugs.freedesktop.org/show_bug.cgi?id=79670 > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c > index 8b3cde7..01287d9 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) > } > #endif > > + /* Early VLV doesn't have this */ > + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc) Did you mean < 0xb? > + return 0; > + > return HAS_ALIASING_PPGTT(dev) ? 1 : 0; > } > > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Jun 13, 2014 at 06:54:02PM +0300, Ville Syrjälä wrote: > On Fri, Jun 13, 2014 at 08:32:38AM -0700, Jesse Barnes wrote: > > Early revs didn't have PPGTT support, so disable there. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=79669 > > References: https://bugs.freedesktop.org/show_bug.cgi?id=79670 > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > > --- > > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c > > index 8b3cde7..01287d9 100644 > > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > > @@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) > > } > > #endif > > > > + /* Early VLV doesn't have this */ > > + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc) > > Did you mean < 0xb? Also some log message is required. -Chris
On Fri, 13 Jun 2014 18:54:02 +0300 Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > On Fri, Jun 13, 2014 at 08:32:38AM -0700, Jesse Barnes wrote: > > Early revs didn't have PPGTT support, so disable there. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=79669 > > References: https://bugs.freedesktop.org/show_bug.cgi?id=79670 > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > > --- > > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c > > index 8b3cde7..01287d9 100644 > > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > > @@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) > > } > > #endif > > > > + /* Early VLV doesn't have this */ > > + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc) > > Did you mean < 0xb? No, unless you tested on 0xb...
On Fri, 13 Jun 2014 17:02:10 +0100 Chris Wilson <chris@chris-wilson.co.uk> wrote: > On Fri, Jun 13, 2014 at 06:54:02PM +0300, Ville Syrjälä wrote: > > On Fri, Jun 13, 2014 at 08:32:38AM -0700, Jesse Barnes wrote: > > > Early revs didn't have PPGTT support, so disable there. > > > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=79669 > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=79670 > > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > > > --- > > > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c > > > index 8b3cde7..01287d9 100644 > > > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > > > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > > > @@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) > > > } > > > #endif > > > > > > + /* Early VLV doesn't have this */ > > > + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc) > > > > Did you mean < 0xb? > > Also some log message is required. Ok, added.
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 8b3cde7..01287d9 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt) } #endif + /* Early VLV doesn't have this */ + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc) + return 0; + return HAS_ALIASING_PPGTT(dev) ? 1 : 0; }
Early revs didn't have PPGTT support, so disable there. References: https://bugs.freedesktop.org/show_bug.cgi?id=79669 References: https://bugs.freedesktop.org/show_bug.cgi?id=79670 Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++ 1 file changed, 4 insertions(+)