diff mbox

OMAP: PM: warn if CONFIG_CPU_IDLE is not enabled

Message ID alpine.DEB.2.00.0908030138020.19529@utopia.booyaka.com (mailing list archive)
State Accepted
Delegated to: Kevin Hilman
Headers show

Commit Message

Paul Walmsley Aug. 3, 2009, 7:39 a.m. UTC
For MPU latency constraints to work, CONFIG_CPU_IDLE must be enabled,
since CPUIdle is where the constraints are evaluated.  Warn during
compilation if CONFIG_CPU_IDLE is not defined.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
 arch/arm/mach-omap2/resource34xx.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Comments

Kevin Hilman Aug. 5, 2009, 3:33 p.m. UTC | #1
Paul Walmsley <paul@pwsan.com> writes:

> For MPU latency constraints to work, CONFIG_CPU_IDLE must be enabled,
> since CPUIdle is where the constraints are evaluated.  Warn during
> compilation if CONFIG_CPU_IDLE is not defined.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>

Thanks, pushing to PM branch.

Kevin

> ---
>  arch/arm/mach-omap2/resource34xx.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/resource34xx.c b/arch/arm/mach-omap2/resource34xx.c
> index 25535a3..1693e9b 100644
> --- a/arch/arm/mach-omap2/resource34xx.c
> +++ b/arch/arm/mach-omap2/resource34xx.c
> @@ -28,6 +28,10 @@
>  #include "cm.h"
>  #include "cm-regbits-34xx.h"
>  
> +#ifndef CONFIG_CPU_IDLE
> +#warning MPU latency constraints require CONFIG_CPU_IDLE to function!
> +#endif
> +
>  /**
>   * init_latency - Initializes the mpu/core latency resource.
>   * @resp: Latency resource to be initalized
> -- 
> 1.6.3.GIT
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/resource34xx.c b/arch/arm/mach-omap2/resource34xx.c
index 25535a3..1693e9b 100644
--- a/arch/arm/mach-omap2/resource34xx.c
+++ b/arch/arm/mach-omap2/resource34xx.c
@@ -28,6 +28,10 @@ 
 #include "cm.h"
 #include "cm-regbits-34xx.h"
 
+#ifndef CONFIG_CPU_IDLE
+#warning MPU latency constraints require CONFIG_CPU_IDLE to function!
+#endif
+
 /**
  * init_latency - Initializes the mpu/core latency resource.
  * @resp: Latency resource to be initalized