| Message ID | 1403146231-28970-1-git-send-email-Ying.Liu@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 19, 2014 at 10:50:31AM +0800, Liu Ying wrote: > The return type of drm_fb_helper_debug_enter() is int, so we should return '0' > instead of 'false'. > > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > --- > drivers/gpu/drm/drm_fb_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index d5d8cea..8daa4ad 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -200,7 +200,7 @@ int drm_fb_helper_debug_enter(struct fb_info *info) > int i; > > if (list_empty(&kernel_fb_helper_list)) > - return false; > + return 0; Actually we can remove the entire if check since list_for_each_entry is a no-op on an empty list, and then we'll fall right through to the return 0; at the end of the function. Care to respin your patch? -Daniel > > list_for_each_entry(helper, &kernel_fb_helper_list, kernel_fb_list) { > for (i = 0; i < helper->crtc_count; i++) { > -- > 1.7.9.5 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
On 06/19/2014 03:01 PM, Daniel Vetter wrote: > On Thu, Jun 19, 2014 at 10:50:31AM +0800, Liu Ying wrote: >> The return type of drm_fb_helper_debug_enter() is int, so we should return '0' >> instead of 'false'. >> >> Signed-off-by: Liu Ying <Ying.Liu@freescale.com> >> --- >> drivers/gpu/drm/drm_fb_helper.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c >> index d5d8cea..8daa4ad 100644 >> --- a/drivers/gpu/drm/drm_fb_helper.c >> +++ b/drivers/gpu/drm/drm_fb_helper.c >> @@ -200,7 +200,7 @@ int drm_fb_helper_debug_enter(struct fb_info *info) >> int i; >> >> if (list_empty(&kernel_fb_helper_list)) >> - return false; >> + return 0; > > Actually we can remove the entire if check since list_for_each_entry is a > no-op on an empty list, and then we'll fall right through to the return 0; > at the end of the function. Care to respin your patch? > -Daniel Ok, I will respin my patch. Thanks. Liu Ying > >> >> list_for_each_entry(helper, &kernel_fb_helper_list, kernel_fb_list) { >> for (i = 0; i < helper->crtc_count; i++) { >> -- >> 1.7.9.5 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel >
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index d5d8cea..8daa4ad 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -200,7 +200,7 @@ int drm_fb_helper_debug_enter(struct fb_info *info) int i; if (list_empty(&kernel_fb_helper_list)) - return false; + return 0; list_for_each_entry(helper, &kernel_fb_helper_list, kernel_fb_list) { for (i = 0; i < helper->crtc_count; i++) {
The return type of drm_fb_helper_debug_enter() is int, so we should return '0' instead of 'false'. Signed-off-by: Liu Ying <Ying.Liu@freescale.com> --- drivers/gpu/drm/drm_fb_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)