| Message ID | 1403016777-15121-17-git-send-email-wens@csie.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> The Allwinner A23 SoC has a PRCM unit like the previous A31 SoC. > The differences are the AR100 clock can no longer be modified, > the APB0 clock has different divisors, and some clock gates are > gone. > > This patch adds a compatible with a modified subdevice list for > the A23. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > .../devicetree/bindings/mfd/sun6i-prcm.txt | 2 +- > drivers/mfd/sun6i-prcm.c | 30 ++++++++++++++++++++++ > 2 files changed, 31 insertions(+), 1 deletion(-) The patch looks fine to me, but I'm concerned about the size of the patch set and the amount of subsystems it touches. I am guessing that this patch can just be taken independently though. Please correct me if I'm wrong.
On Wed, Jun 18, 2014 at 09:29:53AM +0100, Lee Jones wrote: > > The Allwinner A23 SoC has a PRCM unit like the previous A31 SoC. > > The differences are the AR100 clock can no longer be modified, > > the APB0 clock has different divisors, and some clock gates are > > gone. > > > > This patch adds a compatible with a modified subdevice list for > > the A23. > > > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > --- > > .../devicetree/bindings/mfd/sun6i-prcm.txt | 2 +- > > drivers/mfd/sun6i-prcm.c | 30 ++++++++++++++++++++++ > > 2 files changed, 31 insertions(+), 1 deletion(-) > > The patch looks fine to me, but I'm concerned about the size of the > patch set and the amount of subsystems it touches. > > I am guessing that this patch can just be taken independently though. > Please correct me if I'm wrong. I have a bit of the same concern. We have several comments on the previous patches, so I'm not even sure this patch can go as is. It would be much easier if you (ChenYu) could introduce first a very basic with just the UART support, and then, as separate series, clocks, PRCM, MMC, and so on. Maxime
On Wed, Jun 18, 2014 at 8:24 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Wed, Jun 18, 2014 at 09:29:53AM +0100, Lee Jones wrote: >> > The Allwinner A23 SoC has a PRCM unit like the previous A31 SoC. >> > The differences are the AR100 clock can no longer be modified, >> > the APB0 clock has different divisors, and some clock gates are >> > gone. >> > >> > This patch adds a compatible with a modified subdevice list for >> > the A23. >> > >> > Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> > --- >> > .../devicetree/bindings/mfd/sun6i-prcm.txt | 2 +- >> > drivers/mfd/sun6i-prcm.c | 30 ++++++++++++++++++++++ >> > 2 files changed, 31 insertions(+), 1 deletion(-) >> >> The patch looks fine to me, but I'm concerned about the size of the >> patch set and the amount of subsystems it touches. >> >> I am guessing that this patch can just be taken independently though. >> Please correct me if I'm wrong. > > I have a bit of the same concern. We have several comments on the > previous patches, so I'm not even sure this patch can go as is. > > It would be much easier if you (ChenYu) could introduce first a very > basic with just the UART support, and then, as separate series, > clocks, PRCM, MMC, and so on. OK. I will do that. I'll also try to send some of the independent fixes separately. ChenYu
diff --git a/Documentation/devicetree/bindings/mfd/sun6i-prcm.txt b/Documentation/devicetree/bindings/mfd/sun6i-prcm.txt index 1f5a31f..03c5a55 100644 --- a/Documentation/devicetree/bindings/mfd/sun6i-prcm.txt +++ b/Documentation/devicetree/bindings/mfd/sun6i-prcm.txt @@ -4,7 +4,7 @@ PRCM is an MFD device exposing several Power Management related devices (like clks and reset controllers). Required properties: - - compatible: "allwinner,sun6i-a31-prcm" + - compatible: "allwinner,sun6i-a31-prcm" or "allwinner,sun8i-a23-prcm" - reg: The PRCM registers range The prcm node may contain several subdevices definitions: diff --git a/drivers/mfd/sun6i-prcm.c b/drivers/mfd/sun6i-prcm.c index 718fc4d..7a198d3 100644 --- a/drivers/mfd/sun6i-prcm.c +++ b/drivers/mfd/sun6i-prcm.c @@ -76,16 +76,46 @@ static const struct mfd_cell sun6i_a31_prcm_subdevs[] = { }, }; +static const struct mfd_cell sun8i_a23_prcm_subdevs[] = { + { + .name = "sun6i-a31-apb0-clk", + .of_compatible = "allwinner,sun8i-a23-apb0-clk", + .num_resources = ARRAY_SIZE(sun6i_a31_apb0_clk_res), + .resources = sun6i_a31_apb0_clk_res, + }, + { + .name = "sun6i-a31-apb0-gates-clk", + .of_compatible = "allwinner,sun8i-a23-apb0-gates-clk", + .num_resources = ARRAY_SIZE(sun6i_a31_apb0_gates_clk_res), + .resources = sun6i_a31_apb0_gates_clk_res, + }, + { + .name = "sun6i-a31-apb0-clock-reset", + .of_compatible = "allwinner,sun6i-a31-clock-reset", + .num_resources = ARRAY_SIZE(sun6i_a31_apb0_rstc_res), + .resources = sun6i_a31_apb0_rstc_res, + }, +}; + static const struct prcm_data sun6i_a31_prcm_data = { .nsubdevs = ARRAY_SIZE(sun6i_a31_prcm_subdevs), .subdevs = sun6i_a31_prcm_subdevs, }; +static const struct prcm_data sun8i_a23_prcm_data = { + .nsubdevs = ARRAY_SIZE(sun8i_a23_prcm_subdevs), + .subdevs = sun8i_a23_prcm_subdevs, +}; + static const struct of_device_id sun6i_prcm_dt_ids[] = { { .compatible = "allwinner,sun6i-a31-prcm", .data = &sun6i_a31_prcm_data, }, + { + .compatible = "allwinner,sun8i-a23-prcm", + .data = &sun8i_a23_prcm_data, + }, { /* sentinel */ }, };
The Allwinner A23 SoC has a PRCM unit like the previous A31 SoC. The differences are the AR100 clock can no longer be modified, the APB0 clock has different divisors, and some clock gates are gone. This patch adds a compatible with a modified subdevice list for the A23. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- .../devicetree/bindings/mfd/sun6i-prcm.txt | 2 +- drivers/mfd/sun6i-prcm.c | 30 ++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-)