| Message ID | 20140620071901.GA22779@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jun 20, 2014 at 10:19:01AM +0300, Dan Carpenter wrote: > The debug printk says that 8bit is always true because of a '|' vs '&' > typo. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Matt Porter <mporter@linaro.org> > > diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c > index dd780c3..2d3f3c0 100644 > --- a/drivers/mmc/host/sdhci-bcm-kona.c > +++ b/drivers/mmc/host/sdhci-bcm-kona.c > @@ -290,7 +290,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev) > host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; > > dev_dbg(dev, "is_8bit=%c\n", > - (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N'); > + (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N'); > > ret = sdhci_bcm_kona_sd_reset(host); > if (ret) -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c index dd780c3..2d3f3c0 100644 --- a/drivers/mmc/host/sdhci-bcm-kona.c +++ b/drivers/mmc/host/sdhci-bcm-kona.c @@ -290,7 +290,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev) host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; dev_dbg(dev, "is_8bit=%c\n", - (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N'); + (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N'); ret = sdhci_bcm_kona_sd_reset(host); if (ret)
The debug printk says that 8bit is always true because of a '|' vs '&' typo. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html