[RFC,1/4] drm/i915: Implement a framework for batch buffer pools

Message ID	1403109376-23452-2-git-send-email-bradley.d.volkin@intel.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <intel-gfx-bounces@lists.freedesktop.org> From: bradley.d.volkin@intel.com To: intel-gfx@lists.freedesktop.org Date: Wed, 18 Jun 2014 09:36:13 -0700 Message-Id: <1403109376-23452-2-git-send-email-bradley.d.volkin@intel.com> In-Reply-To: <1403109376-23452-1-git-send-email-bradley.d.volkin@intel.com> References: <1403109376-23452-1-git-send-email-bradley.d.volkin@intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [RFC 1/4] drm/i915: Implement a framework for batch buffer pools Precedence: list Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>

diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl index 7df3134..fcc0a1c 100644 --- a/Documentation/DocBook/drm.tmpl +++ b/Documentation/DocBook/drm.tmpl @@ -3939,6 +3939,11 @@ int num_ioctls;</synopsis> !Pdrivers/gpu/drm/i915/i915_cmd_parser.c batch buffer command parser !Idrivers/gpu/drm/i915/i915_cmd_parser.c </sect2> + <sect2> + <title>Batchbuffer Pools</title> +!Pdrivers/gpu/drm/i915/i915_gem_batch_pool.c batch pool +!Idrivers/gpu/drm/i915/i915_gem_batch_pool.c + </sect2> </sect1> </chapter> </part> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index cad1683..b92fbe6 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -17,6 +17,7 @@ i915-$(CONFIG_DEBUG_FS) += i915_debugfs.o # GEM code i915-y += i915_cmd_parser.o \ + i915_gem_batch_pool.o \ i915_gem_context.o \ i915_gem_render_state.o \ i915_gem_debug.o \ diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 0640071..2a88b5e 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -1610,6 +1610,8 @@ struct drm_i915_gem_object { /** Used in execbuf to temporarily hold a ref */ struct list_head obj_exec_link; + struct list_head batch_pool_list; + /** * This is set if the object is on the active lists (has pending * rendering and so a non-zero seqno), and is not set if it i s on @@ -1727,6 +1729,14 @@ struct drm_i915_gem_object { }; #define to_intel_bo(x) container_of(x, struct drm_i915_gem_object, base) +struct i915_gem_batch_pool { + struct drm_device *dev; + struct list_head active_list; + struct list_head inactive_list; + int count; + int max_count; +}; + /** * Request queue structure. * @@ -2508,6 +2518,15 @@ void i915_destroy_error_state(struct drm_device *dev); void i915_get_extra_instdone(struct drm_device *dev, uint32_t *instdone); const char *i915_cache_level_str(int type); +/* i915_gem_batch_pool.c */ +struct i915_gem_batch_pool *i915_gem_batch_pool_alloc(struct drm_device *dev, + int max_count); +void i915_gem_batch_pool_free(struct i915_gem_batch_pool *pool); +struct drm_i915_gem_object* +i915_gem_batch_pool_get(struct i915_gem_batch_pool *pool, size_t size); +void i915_gem_batch_pool_put(struct i915_gem_batch_pool *pool, + struct drm_i915_gem_object *obj); + /* i915_cmd_parser.c */ int i915_cmd_parser_get_version(void); int i915_cmd_parser_init_ring(struct intel_engine_cs *ring); diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index d857f58..d5e3001 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -4324,6 +4324,7 @@ void i915_gem_object_init(struct drm_i915_gem_object *obj, INIT_LIST_HEAD(&obj->ring_list); INIT_LIST_HEAD(&obj->obj_exec_link); INIT_LIST_HEAD(&obj->vma_list); + INIT_LIST_HEAD(&obj->batch_pool_list); obj->ops = ops; diff --git a/drivers/gpu/drm/i915/i915_gem_batch_pool.c b/drivers/gpu/drm/i915/i915_gem_batch_pool.c new file mode 100644 index 0000000..37cec7d --- /dev/null +++ b/drivers/gpu/drm/i915/i915_gem_batch_pool.c @@ -0,0 +1,151 @@ +/* + * Copyright © 2014 Intel Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + */ + +#include "i915_drv.h" + +/** + * DOC: batch pool + * + * In order to submit batch buffers as 'secure', the software command parser + * must ensure that a batch buffer cannot be modified after parsing. It does + * this by copying the user provided batch buffer contents to a kernel owned + * buffer from which the hardware will actually execute, and by carefully + * managing the address space bindings for such buffers. + * + * The batch pool framework provides a mechanism for the driver to manage a + * set of scratch buffers to use for this purpose. The framework can be + * extended to support other uses cases should they arise. + */ + +/** + * i915_gem_batch_pool_alloc() - allocate and initialize a batch buffer pool + * @dev: the drm device + * @max_count: the maximum number of buffers allowed in the pool + * + * Return: the new batch buffer pool + */ +struct i915_gem_batch_pool *i915_gem_batch_pool_alloc(struct drm_device *dev, + int max_count) +{ + struct i915_gem_batch_pool *pool; + + pool = kmalloc(sizeof(*pool), GFP_KERNEL); + if (!pool) + return ERR_PTR(-ENOMEM); + + pool->dev = dev; + INIT_LIST_HEAD(&pool->active_list); + INIT_LIST_HEAD(&pool->inactive_list); + pool->count = 0; + pool->max_count = max_count; + + return pool; +} + +/** + * i915_gem_batch_pool_free() - clean up a batch buffer pool + * @pool: the pool to clean up + * + * Note: Callers must hold the struct_mutex. Callers must also ensure + * that all buffers have been returned to the pool. + */ +void i915_gem_batch_pool_free(struct i915_gem_batch_pool *pool) +{ + struct drm_i915_gem_object *obj, *next; + + BUG_ON(!mutex_is_locked(&pool->dev->struct_mutex)); + BUG_ON(!list_empty(&pool->active_list)); + + list_for_each_entry_safe(obj, next, + &pool->inactive_list, batch_pool_list) { + list_del(&obj->batch_pool_list); + drm_gem_object_unreference(&obj->base); + } + + kfree(pool); +} + +/** + * i915_gem_batch_pool_get() - select a buffer from the pool + * @pool: the batch buffer pool + * @size: the minimum desired size of the returned buffer + * + * Finds or allocates a batch buffer in the pool with at least the requested + * size. The buffer will not be used to satisfy further + * i915_gem_batch_pool_get() requests until the corresponding + * i915_gem_batch_pool_put() call. The caller is responsible for any domain or + * active/inactive management for the returned buffer. + * + * Note: Callers must hold the struct_mutex + * + * Return: the selected batch buffer object; -EAGAIN if the pool is at capacity + */ +struct drm_i915_gem_object * +i915_gem_batch_pool_get(struct i915_gem_batch_pool *pool, + size_t size) +{ + struct drm_i915_gem_object *obj = NULL; + struct drm_i915_gem_object *tmp; + + BUG_ON(!mutex_is_locked(&pool->dev->struct_mutex)); + + list_for_each_entry(tmp, &pool->inactive_list, batch_pool_list) { + if (tmp->base.size >= size) { + obj = tmp; + break; + } + } + + if (!obj) { + if (pool->count == pool->max_count) + return ERR_PTR(-EAGAIN); + + obj = i915_gem_alloc_object(pool->dev, size); + if (!obj) + return ERR_PTR(-ENOMEM); + + list_add_tail(&obj->batch_pool_list, &pool->inactive_list); + pool->count++; + } + + obj->madv = I915_MADV_WILLNEED; + list_move_tail(&obj->batch_pool_list, &pool->active_list); + + return obj; +} + +/** + * i915_gem_batch_pool_put() - return a buffer to the pool + * @pool: the batch buffer pool + * @obj: the batch buffer object + * + * Note: Callers must hold the struct_mutex + */ +void i915_gem_batch_pool_put(struct i915_gem_batch_pool *pool, + struct drm_i915_gem_object *obj) +{ + BUG_ON(!mutex_is_locked(&pool->dev->struct_mutex)); + obj->madv = I915_MADV_DONTNEED; + list_move_tail(&obj->batch_pool_list, &pool->inactive_list); +}

[RFC,1/4] drm/i915: Implement a framework for batch buffer pools

Commit Message

Comments

Patch