| Message ID | 1404367277-12003-3-git-send-email-gshark.jeong@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jul 03, 2014 at 07:01:17AM +0100, Daniel Jeong wrote: > This commit is about tps611xx device tree documentation. > > Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com> > --- > .../video/backlight/tps611xx-backlight.txt | 24 ++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/backlight/tps611xx-backlight.txt > > diff --git a/Documentation/devicetree/bindings/video/backlight/tps611xx-backlight.txt b/Documentation/devicetree/bindings/video/backlight/tps611xx-backlight.txt > new file mode 100644 > index 0000000..7af8182 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/backlight/tps611xx-backlight.txt > @@ -0,0 +1,24 @@ > +TPS611xx family of backlight driver based on EasyScale. > + > +EasyScale is a simple but flexible one pin interface to configure the current. > + > +Required properties: > +- compatible: should contain at least one of > + "ti,tps61158_bl" > + "ti,tps61161_bl" > + "ti,tps61163_bl" > + "ti,tps61165_bl" In v3 I asked you to get rid of the "_bl" suffix. > +- rfa-enable: enable request for acknowledge. > + If RFA is enabled, the data byte includes the RFA bit and device will wait > + and check acknowledge from device. You didn't answer my question as to why this should be in the DT. > +- es-gpio : GPIO for easy-scale communication.(see GPIO binding[0]) > + > +[0]: Documentation/devicetree/bindings/gpio/gpio.txt > + > +Example: > + > + backlight { > + compatible = "ti,tps61163"; This now doesn't match the Documentation above. Thanks, Mark. > + rfa-enable; > + es-gpio = <&gpio 45 0>; > + }; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> > +- rfa-enable: enable request for acknowledge. > > + If RFA is enabled, the data byte includes the RFA bit and device will > wait > > + and check acknowledge from device. > > You didn't answer my question as to why this should be in the DT. > > > According to the RFA enable, the easy scale pin works differently. > This value should be set before the first data transfer. Sure, things works differently if this is set. That I understood. What I haven't heard is a rationale as to why this configuration option shuold be in the DT. Can I enable this on all implementations, or not? When would I enable this and when would I not? The property reads like a switch to turn a feature on, rather than the description of the presence of a feature. Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/video/backlight/tps611xx-backlight.txt b/Documentation/devicetree/bindings/video/backlight/tps611xx-backlight.txt new file mode 100644 index 0000000..7af8182 --- /dev/null +++ b/Documentation/devicetree/bindings/video/backlight/tps611xx-backlight.txt @@ -0,0 +1,24 @@ +TPS611xx family of backlight driver based on EasyScale. + +EasyScale is a simple but flexible one pin interface to configure the current. + +Required properties: +- compatible: should contain at least one of + "ti,tps61158_bl" + "ti,tps61161_bl" + "ti,tps61163_bl" + "ti,tps61165_bl" +- rfa-enable: enable request for acknowledge. + If RFA is enabled, the data byte includes the RFA bit and device will wait + and check acknowledge from device. +- es-gpio : GPIO for easy-scale communication.(see GPIO binding[0]) + +[0]: Documentation/devicetree/bindings/gpio/gpio.txt + +Example: + + backlight { + compatible = "ti,tps61163"; + rfa-enable; + es-gpio = <&gpio 45 0>; + };
This commit is about tps611xx device tree documentation. Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com> --- .../video/backlight/tps611xx-backlight.txt | 24 ++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/backlight/tps611xx-backlight.txt