diff mbox

[v2,10/8] ARM: sun7i: cubietruck: add an SPIdev device for testing

Message ID 1404619518-7592-11-git-send-email-emilio@elopez.com.ar (mailing list archive)
State New, archived
Headers show

Commit Message

Emilio López July 6, 2014, 4:05 a.m. UTC 
---
 arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Sergei Shtylyov July 6, 2014, 3:21 p.m. UTC | #1 
Hello.

On 07/06/2014 08:05 AM, Emilio López wrote:

    You need to sign off on your patches, else they couldn't be applied.

> ---
>   arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 12 ++++++++++++
>   1 file changed, 12 insertions(+)

> diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> index b87fea9..4ef421f 100644
> --- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> @@ -66,6 +66,18 @@
>   			status = "okay";
>   		};
>
> +		spi2: spi@01c17000 {
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&spi2_pins_a>;
> +			status = "okay";
> +
> +			dac0: dh2228@2 {

    The ePAPR standard [1] says:

The name of a node should be somewhat generic, reflecting the function of the 
device and not its precise programming model.

> +				compatible = "rohm,dh2228fv";
> +				reg = <2>;
> +				spi-max-frequency = <100000>;
> +			};
> +		};
> +

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei
Emilio López July 6, 2014, 5:30 p.m. UTC | #2 
Hi,

El 06/07/14 12:21, Sergei Shtylyov escribió:
> Hello.
>
> On 07/06/2014 08:05 AM, Emilio López wrote:
>
>     You need to sign off on your patches, else they couldn't be applied.

That's kind of the point here. These patches are just intended for 
testing. From the cover letter:

"""Patches nine, ten and eleven are *only intended
for testing*, and add a dummy SPIdev device to cubieboard, cubietruck
and A10S-OLinuXino to facilitate testing with spidev_test."""

Cheers,

Emilio
Maxime Ripard July 7, 2014, 9:39 a.m. UTC | #3 
Hi Emilio,

On Sun, Jul 06, 2014 at 02:30:54PM -0300, Emilio López wrote:
> Hi,
> 
> El 06/07/14 12:21, Sergei Shtylyov escribió:
> >Hello.
> >
> >On 07/06/2014 08:05 AM, Emilio López wrote:
> >
> >    You need to sign off on your patches, else they couldn't be applied.
> 
> That's kind of the point here. These patches are just intended for
> testing. From the cover letter:
> 
> """Patches nine, ten and eleven are *only intended
> for testing*, and add a dummy SPIdev device to cubieboard, cubietruck
> and A10S-OLinuXino to facilitate testing with spidev_test."""

Then stop posting them. It just confuses every one here.

Maxime
diff mbox

Patch

diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
index b87fea9..4ef421f 100644
--- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
+++ b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
@@ -66,6 +66,18 @@ 
 			status = "okay";
 		};
 
+		spi2: spi@01c17000 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&spi2_pins_a>;
+			status = "okay";
+
+			dac0: dh2228@2 {
+				compatible = "rohm,dh2228fv";
+				reg = <2>;
+				spi-max-frequency = <100000>;
+			};
+		};
+
 		pinctrl@01c20800 {
 			mmc3_pins_a: mmc3@0 {
 				/* AP6210 requires pull-up */