| Message ID | 1404670906-17335-1-git-send-email-rickard_strandqvist@spectrumdigital.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > drivers/video/backlight/jornada720_lcd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Solve it the other way around. Add a check and return the value if an error is returned. > diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c > index da3876c..b304319 100644 > --- a/drivers/video/backlight/jornada720_lcd.c > +++ b/drivers/video/backlight/jornada720_lcd.c > @@ -56,12 +56,10 @@ static int jornada_lcd_get_contrast(struct lcd_device *ld) > > static int jornada_lcd_set_contrast(struct lcd_device *ld, int value) > { > - int ret; > - > jornada_ssp_start(); > > /* start by sending our set contrast cmd to mcu */ > - ret = jornada_ssp_byte(SETCONTRAST); > + jornada_ssp_byte(SETCONTRAST); > > /* push the new value */ > if (jornada_ssp_byte(value) != TXDUMMY) {
2014-07-07 12:46 GMT+02:00 Lee Jones <lee.jones@linaro.org>: >> Variable ar assigned a value that is never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> >> --- >> drivers/video/backlight/jornada720_lcd.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) > > Solve it the other way around. > > Add a check and return the value if an error is returned. Hi Ok, I take the opportunity to make a bigger change to clarify the similarities in function. Hope you like it, otherwise I can make the minor change instead. Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c index da3876c..b304319 100644 --- a/drivers/video/backlight/jornada720_lcd.c +++ b/drivers/video/backlight/jornada720_lcd.c @@ -56,12 +56,10 @@ static int jornada_lcd_get_contrast(struct lcd_device *ld) static int jornada_lcd_set_contrast(struct lcd_device *ld, int value) { - int ret; - jornada_ssp_start(); /* start by sending our set contrast cmd to mcu */ - ret = jornada_ssp_byte(SETCONTRAST); + jornada_ssp_byte(SETCONTRAST); /* push the new value */ if (jornada_ssp_byte(value) != TXDUMMY) {
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> --- drivers/video/backlight/jornada720_lcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)