| Message ID | CAFquV7W-aDs=1R=aYOFzWw8rYiqiVNpQ-8T_wWHwvdh-u_wHWA@mail.gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Tuesday, July 08, 2014 10:14:59 AM Yidi Lin wrote: > With win8 capability, the ACPI backlight control is broken on this model. > The system also loses backlight setting when resuming from S3. > > Add this model to the the ACPI video detect blacklist to make backlight > functionality work. > > Although backlight functionality works via video.use_native_backlight=1, > this approach may be safer. > > Signed-off-by: Edward Lin <yidi.lin@canonical.com> I've applied this patch already it seems, haven't I? > --- > drivers/acpi/video_detect.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c > index 33e3db5..c42feb2 100644 > --- a/drivers/acpi/video_detect.c > +++ b/drivers/acpi/video_detect.c > @@ -166,6 +166,14 @@ static struct dmi_system_id video_detect_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"), > }, > }, > + { > + .callback = video_detect_force_vendor, > + .ident = "Dell Inspiron 5737", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5737"), > + }, > + }, > { }, > }; > > -- > 1.7.9.5 > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, This patch is for win8 backlight issue on Dell Inspiron 5737. Do you mix up with the patch [1] which is for Dell Inspiron 7737 ? [1] http://marc.info/?l=linux-acpi&m=139950526523173&w=2 On Tue, Jul 8, 2014 at 9:31 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > On Tuesday, July 08, 2014 10:14:59 AM Yidi Lin wrote: >> With win8 capability, the ACPI backlight control is broken on this model. >> The system also loses backlight setting when resuming from S3. >> >> Add this model to the the ACPI video detect blacklist to make backlight >> functionality work. >> >> Although backlight functionality works via video.use_native_backlight=1, >> this approach may be safer. >> >> Signed-off-by: Edward Lin <yidi.lin@canonical.com> > > I've applied this patch already it seems, haven't I? > >> --- >> drivers/acpi/video_detect.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c >> index 33e3db5..c42feb2 100644 >> --- a/drivers/acpi/video_detect.c >> +++ b/drivers/acpi/video_detect.c >> @@ -166,6 +166,14 @@ static struct dmi_system_id video_detect_dmi_table[] = { >> DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"), >> }, >> }, >> + { >> + .callback = video_detect_force_vendor, >> + .ident = "Dell Inspiron 5737", >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), >> + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5737"), >> + }, >> + }, >> { }, >> }; >> >> -- >> 1.7.9.5 >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, July 08, 2014 11:04:32 PM Yidi Lin wrote: > Hi, > This patch is for win8 backlight issue on Dell Inspiron 5737. Yes. > Do you mix up with the patch [1] which is for Dell Inspiron 7737 ? > > [1] http://marc.info/?l=linux-acpi&m=139950526523173&w=2 No. Please check the linux-next branch of linux-pm.git. > On Tue, Jul 8, 2014 at 9:31 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > On Tuesday, July 08, 2014 10:14:59 AM Yidi Lin wrote: > >> With win8 capability, the ACPI backlight control is broken on this model. > >> The system also loses backlight setting when resuming from S3. > >> > >> Add this model to the the ACPI video detect blacklist to make backlight > >> functionality work. > >> > >> Although backlight functionality works via video.use_native_backlight=1, > >> this approach may be safer. > >> > >> Signed-off-by: Edward Lin <yidi.lin@canonical.com> > > > > I've applied this patch already it seems, haven't I? > > > >> --- > >> drivers/acpi/video_detect.c | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c > >> index 33e3db5..c42feb2 100644 > >> --- a/drivers/acpi/video_detect.c > >> +++ b/drivers/acpi/video_detect.c > >> @@ -166,6 +166,14 @@ static struct dmi_system_id video_detect_dmi_table[] = { > >> DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"), > >> }, > >> }, > >> + { > >> + .callback = video_detect_force_vendor, > >> + .ident = "Dell Inspiron 5737", > >> + .matches = { > >> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > >> + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5737"), > >> + }, > >> + }, > >> { }, > >> }; > >> > >> -- > >> 1.7.9.5 > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > > I speak only for myself. > > Rafael J. Wysocki, Intel Open Source Technology Center.
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index 33e3db5..c42feb2 100644 --- a/drivers/acpi/video_detect.c +++ b/drivers/acpi/video_detect.c @@ -166,6 +166,14 @@ static struct dmi_system_id video_detect_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"), }, }, + { + .callback = video_detect_force_vendor, + .ident = "Dell Inspiron 5737", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5737"), + }, + }, { }, };
With win8 capability, the ACPI backlight control is broken on this model. The system also loses backlight setting when resuming from S3. Add this model to the the ACPI video detect blacklist to make backlight functionality work. Although backlight functionality works via video.use_native_backlight=1, this approach may be safer. Signed-off-by: Edward Lin <yidi.lin@canonical.com> --- drivers/acpi/video_detect.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html