| Message ID | 2866950.oXmKFGy9mh@diego (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Heiko, On Tue, Jul 15, 2014 at 4:00 PM, Heiko Stübner <heiko@sntech.de> wrote: > The uarts on rk3288 are still compatible with the dw_8250, but located > at a different position and need DEBUG_UART_8250_WORD enabled. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > arch/arm/Kconfig.debug | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index 8f90595..f68def0 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -613,6 +613,14 @@ choice > Say Y here if you want kernel low-level debugging support > on Rockchip based platforms. > > + config DEBUG_RK32_UART2 It's slightly confusing that you didn't rename the old "DEBUG_RK3X_UART2". Other than that: Reviewed-by: Doug Anderson <dianders@chromium.org> Tested-by: Doug Anderson <dianders@chromium.org>
Am Dienstag, 15. Juli 2014, 21:13:10 schrieb Doug Anderson: > Heiko, > > On Tue, Jul 15, 2014 at 4:00 PM, Heiko Stübner <heiko@sntech.de> wrote: > > The uarts on rk3288 are still compatible with the dw_8250, but located > > at a different position and need DEBUG_UART_8250_WORD enabled. > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > --- > > > > arch/arm/Kconfig.debug | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > > index 8f90595..f68def0 100644 > > --- a/arch/arm/Kconfig.debug > > +++ b/arch/arm/Kconfig.debug > > @@ -613,6 +613,14 @@ choice > > > > Say Y here if you want kernel low-level debugging > > support > > on Rockchip based platforms. > > > > + config DEBUG_RK32_UART2 > > It's slightly confusing that you didn't rename the old "DEBUG_RK3X_UART2". My problem is, to what :-) ... DEBUG_RK30_UART2 ? RK30xx and RK31xx share these, but I guess at least the description should be adapted. > > Other than that: > > Reviewed-by: Doug Anderson <dianders@chromium.org> > Tested-by: Doug Anderson <dianders@chromium.org>
Heiko, On Wed, Jul 16, 2014 at 2:11 AM, Heiko Stübner <heiko@sntech.de> wrote: > Am Dienstag, 15. Juli 2014, 21:13:10 schrieb Doug Anderson: >> Heiko, >> >> On Tue, Jul 15, 2014 at 4:00 PM, Heiko Stübner <heiko@sntech.de> wrote: >> > The uarts on rk3288 are still compatible with the dw_8250, but located >> > at a different position and need DEBUG_UART_8250_WORD enabled. >> > >> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> >> > --- >> > >> > arch/arm/Kconfig.debug | 12 +++++++++++- >> > 1 file changed, 11 insertions(+), 1 deletion(-) >> > >> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug >> > index 8f90595..f68def0 100644 >> > --- a/arch/arm/Kconfig.debug >> > +++ b/arch/arm/Kconfig.debug >> > @@ -613,6 +613,14 @@ choice >> > >> > Say Y here if you want kernel low-level debugging >> > support >> > on Rockchip based platforms. >> > >> > + config DEBUG_RK32_UART2 >> >> It's slightly confusing that you didn't rename the old "DEBUG_RK3X_UART2". > > My problem is, to what :-) ... DEBUG_RK30_UART2 ? > > RK30xx and RK31xx share these, but I guess at least the description should be > adapted. Yeah, trying to get these things right is an impossible task. The only thing I've ever seen that's sane is to just name things after the first person in the code base to use them rather than trying to guess ahead of time how similar products with similar marketing name will be in the future. ...agree that even if you don't do the rename here that updating the description would be nice. -Doug
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 8f90595..f68def0 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -613,6 +613,14 @@ choice Say Y here if you want kernel low-level debugging support on Rockchip based platforms. + config DEBUG_RK32_UART2 + bool "Kernel low-level debugging messages via Rockchip RK32 UART2" + depends on ARCH_ROCKCHIP + select DEBUG_UART_8250 + help + Say Y here if you want kernel low-level debugging support + on Rockchip RK32xx based platforms. + config DEBUG_S3C_UART0 depends on PLAT_SAMSUNG select DEBUG_EXYNOS_UART if ARCH_EXYNOS @@ -1096,6 +1104,7 @@ config DEBUG_UART_PHYS default 0xf991e000 if DEBUG_QCOM_UARTDM default 0xfcb00000 if DEBUG_HI3620_UART default 0xfe800000 if ARCH_IOP32X + default 0xff690000 if DEBUG_RK32_UART2 default 0xffc02000 if DEBUG_SOCFPGA_UART default 0xffd82340 if ARCH_IOP13XX default 0xfff36000 if DEBUG_HIGHBANK_UART @@ -1152,6 +1161,7 @@ config DEBUG_UART_VIRT default 0xfec02000 if DEBUG_SOCFPGA_UART default 0xfec12000 if DEBUG_MVEBU_UART || DEBUG_MVEBU_UART_ALTERNATE default 0xfec20000 if DEBUG_DAVINCI_DMx_UART0 + default 0xfec90000 if DEBUG_RK32_UART2 default 0xfed0c000 if DEBUG_DAVINCI_DA8XX_UART1 default 0xfed0d000 if DEBUG_DAVINCI_DA8XX_UART2 default 0xfed12000 if ARCH_KIRKWOOD @@ -1186,7 +1196,7 @@ config DEBUG_UART_8250_WORD ARCH_KEYSTONE || \ DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \ DEBUG_DAVINCI_DA8XX_UART2 || \ - DEBUG_BCM_KONA_UART + DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2 config DEBUG_UART_8250_FLOW_CONTROL bool "Enable flow control for 8250 UART"
The uarts on rk3288 are still compatible with the dw_8250, but located at a different position and need DEBUG_UART_8250_WORD enabled. Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/arm/Kconfig.debug | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)