Message ID | 4A8151A1.2020103@gmail.com (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Douglas Landgraf |
Headers | show |
Hi, You are right, thanks for fixing this bug. I have pushed your patch to my tree. Best regards, Antoine Roel Kluin wrote: > The order of indexes is reversed > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > Right? > > diff --git a/drivers/media/video/zr364xx.c b/drivers/media/video/zr364xx.c > index fc976f4..2622a6e 100644 > --- a/drivers/media/video/zr364xx.c > +++ b/drivers/media/video/zr364xx.c > @@ -695,7 +695,7 @@ static int zr364xx_release(struct file *file) > for (i = 0; i < 2; i++) { > err = > send_control_msg(udev, 1, init[cam->method][i].value, > - 0, init[i][cam->method].bytes, > + 0, init[cam->method][i].bytes, > init[cam->method][i].size); > if (err < 0) { > dev_err(&udev->dev, "error during release sequence\n"); > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/video/zr364xx.c b/drivers/media/video/zr364xx.c index fc976f4..2622a6e 100644 --- a/drivers/media/video/zr364xx.c +++ b/drivers/media/video/zr364xx.c @@ -695,7 +695,7 @@ static int zr364xx_release(struct file *file) for (i = 0; i < 2; i++) { err = send_control_msg(udev, 1, init[cam->method][i].value, - 0, init[i][cam->method].bytes, + 0, init[cam->method][i].bytes, init[cam->method][i].size); if (err < 0) { dev_err(&udev->dev, "error during release sequence\n");
The order of indexes is reversed Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- Right? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html