| Message ID | 1405480243-25915-1-git-send-email-skannan@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jul 15, 2014 at 08:10:43PM -0700, Saravana Kannan wrote: > From: Suman Tatiraju <sumant@codeaurora.org> > > Long and int have different sizes on a 64-bit machine. Allocate > memory for the time_in_state table using the right data type. > > Change-Id: I335277674018c0ea759aa0996309d52578ea1fd5 Please don't put this crud in patches you submit upstream. It means nothing to us. > Signed-off-by: Suman Tatiraju <sumant@codeaurora.org> > Reviewed-by: Saravana Kannan <skannan@codeaurora.org> > Signed-off-by: Saravana Kannan <skannan@codeaurora.org> > --- > drivers/devfreq/devfreq.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. </formletter>
On 07/15/14 20:10, Saravana Kannan wrote: > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index 65eed38..349e28ea 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -483,9 +483,10 @@ struct devfreq *devfreq_add_device(struct device *dev, > devfreq->profile->max_state * > devfreq->profile->max_state, > GFP_KERNEL); > - devfreq->time_in_state = devm_kzalloc(dev, sizeof(unsigned int) * > - devfreq->profile->max_state, > - GFP_KERNEL); > + devfreq->time_in_state = devm_kzalloc(dev, > + sizeof(*(devfreq->time_in_state)) * > + devfreq->profile->max_state, > + GFP_KERNEL); We could use devm_kcalloc() here too.
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 65eed38..349e28ea 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -483,9 +483,10 @@ struct devfreq *devfreq_add_device(struct device *dev, devfreq->profile->max_state * devfreq->profile->max_state, GFP_KERNEL); - devfreq->time_in_state = devm_kzalloc(dev, sizeof(unsigned int) * - devfreq->profile->max_state, - GFP_KERNEL); + devfreq->time_in_state = devm_kzalloc(dev, + sizeof(*(devfreq->time_in_state)) * + devfreq->profile->max_state, + GFP_KERNEL); devfreq->last_stat_updated = jiffies; dev_set_name(&devfreq->dev, "%s", dev_name(dev));