diff mbox

[2/3] ARM: dts: nitrogen6x: add hdmi

Message ID 1406285393-23545-2-git-send-email-l.stach@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Lucas Stach July 25, 2014, 10:49 a.m. UTC
From: Michael Olbrich <m.olbrich@pengutronix.de>

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Fabio Estevam July 25, 2014, 1:48 p.m. UTC | #1
Hi Lucas,

On Fri, Jul 25, 2014 at 7:49 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> From: Michael Olbrich <m.olbrich@pengutronix.de>
>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> index 3362d2600d85..4e27cf9f3d2e 100644
> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> @@ -174,6 +174,12 @@
>         status = "okay";
>  };
>
> +&hdmi {
> +       ddc-i2c-bus = <&i2c2>;
> +       hpd-unreliable;

I don't see this property available in linux-next yet. Are we missing
the patch that adds it?
Lucas Stach July 25, 2014, 1:55 p.m. UTC | #2
Am Freitag, den 25.07.2014, 10:48 -0300 schrieb Fabio Estevam:
> Hi Lucas,
> 
> On Fri, Jul 25, 2014 at 7:49 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > From: Michael Olbrich <m.olbrich@pengutronix.de>
> >
> > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > index 3362d2600d85..4e27cf9f3d2e 100644
> > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > @@ -174,6 +174,12 @@
> >         status = "okay";
> >  };
> >
> > +&hdmi {
> > +       ddc-i2c-bus = <&i2c2>;
> > +       hpd-unreliable;
> 
> I don't see this property available in linux-next yet. Are we missing
> the patch that adds it?
> 
Right, we are missing a patch here. It already has been posted to the
list long time ago, but obviously fell through the cracks. Thanks for
spotting.

Regards,
Lucas
Shawn Guo July 29, 2014, 7:48 a.m. UTC | #3
On Fri, Jul 25, 2014 at 03:55:28PM +0200, Lucas Stach wrote:
> Am Freitag, den 25.07.2014, 10:48 -0300 schrieb Fabio Estevam:
> > Hi Lucas,
> > 
> > On Fri, Jul 25, 2014 at 7:49 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > > From: Michael Olbrich <m.olbrich@pengutronix.de>
> > >
> > > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > ---
> > >  arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > > index 3362d2600d85..4e27cf9f3d2e 100644
> > > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > > @@ -174,6 +174,12 @@
> > >         status = "okay";
> > >  };
> > >
> > > +&hdmi {
> > > +       ddc-i2c-bus = <&i2c2>;
> > > +       hpd-unreliable;
> > 
> > I don't see this property available in linux-next yet. Are we missing
> > the patch that adds it?
> > 
> Right, we are missing a patch here. It already has been posted to the
> list long time ago, but obviously fell through the cracks. Thanks for
> spotting.

So should I drop the property and apply the patches or just ignore the
series?

Shawn
Lucas Stach July 29, 2014, 8:14 a.m. UTC | #4
Am Dienstag, den 29.07.2014, 15:48 +0800 schrieb Shawn Guo:
> On Fri, Jul 25, 2014 at 03:55:28PM +0200, Lucas Stach wrote:
> > Am Freitag, den 25.07.2014, 10:48 -0300 schrieb Fabio Estevam:
> > > Hi Lucas,
> > > 
> > > On Fri, Jul 25, 2014 at 7:49 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > > > From: Michael Olbrich <m.olbrich@pengutronix.de>
> > > >
> > > > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > > ---
> > > >  arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 6 ++++++
> > > >  1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > > > index 3362d2600d85..4e27cf9f3d2e 100644
> > > > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > > > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> > > > @@ -174,6 +174,12 @@
> > > >         status = "okay";
> > > >  };
> > > >
> > > > +&hdmi {
> > > > +       ddc-i2c-bus = <&i2c2>;
> > > > +       hpd-unreliable;
> > > 
> > > I don't see this property available in linux-next yet. Are we missing
> > > the patch that adds it?
> > > 
> > Right, we are missing a patch here. It already has been posted to the
> > list long time ago, but obviously fell through the cracks. Thanks for
> > spotting.
> 
> So should I drop the property and apply the patches or just ignore the
> series?
> 
Please drop the property and apply. I'll take care of re-adding this
when the relevant imx-drm patches are in.

Regards,
Lucas
Shawn Guo July 29, 2014, 8:59 a.m. UTC | #5
On Tue, Jul 29, 2014 at 10:14:51AM +0200, Lucas Stach wrote:
> Please drop the property and apply. I'll take care of re-adding this
> when the relevant imx-drm patches are in.

Done.

Shawn
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index 3362d2600d85..4e27cf9f3d2e 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -174,6 +174,12 @@ 
 	status = "okay";
 };
 
+&hdmi {
+	ddc-i2c-bus = <&i2c2>;
+	hpd-unreliable;
+	status = "okay";
+};
+
 &i2c1 {
 	clock-frequency = <100000>;
 	pinctrl-names = "default";