diff mbox

[06/15] drm/exynos: dpi: Add support for panel prepare and unprepare routines

Message ID 1406828534-10072-7-git-send-email-ajaykumar.rs@samsung.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Ajay Kumar July 31, 2014, 5:42 p.m. UTC
Modify exynos_dpi driver to support the new panel calls:
prepare and unprepare.

Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_dpi.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Thierry Reding Aug. 1, 2014, 9:04 a.m. UTC | #1
On Thu, Jul 31, 2014 at 11:12:05PM +0530, Ajay Kumar wrote:
> Modify exynos_dpi driver to support the new panel calls:
> prepare and unprepare.
> 
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_dpi.c |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Looks good to me. Inki, can I have your Acked-by to take this through
the panel tree?

Thierry
Inki Dae Aug. 1, 2014, 9:24 a.m. UTC | #2
On 2014? 08? 01? 18:04, Thierry Reding wrote:
> On Thu, Jul 31, 2014 at 11:12:05PM +0530, Ajay Kumar wrote:
>> Modify exynos_dpi driver to support the new panel calls:
>> prepare and unprepare.
>>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> ---
>>  drivers/gpu/drm/exynos/exynos_drm_dpi.c |    8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> Looks good to me. Inki, can I have your Acked-by to take this through
> the panel tree?

Of course.

Acked-by: Inki Dae <inki.dae@samsung.com>

Thanks,
Inki Dae

> 
> Thierry
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thierry Reding Aug. 1, 2014, 10:22 a.m. UTC | #3
On Fri, Aug 01, 2014 at 06:24:42PM +0900, Inki Dae wrote:
> On 2014? 08? 01? 18:04, Thierry Reding wrote:
> > On Thu, Jul 31, 2014 at 11:12:05PM +0530, Ajay Kumar wrote:
> >> Modify exynos_dpi driver to support the new panel calls:
> >> prepare and unprepare.
> >>
> >> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> >> ---
> >>  drivers/gpu/drm/exynos/exynos_drm_dpi.c |    8 ++++++--
> >>  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > Looks good to me. Inki, can I have your Acked-by to take this through
> > the panel tree?
> 
> Of course.
> 
> Acked-by: Inki Dae <inki.dae@samsung.com>

I'll take it that this Acked-by applies also to patch 07/15?

Thierry
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
index 3aa1c7e..fa08f05 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
@@ -125,14 +125,18 @@  static int exynos_dpi_create_connector(struct exynos_drm_display *display,
 
 static void exynos_dpi_poweron(struct exynos_dpi *ctx)
 {
-	if (ctx->panel)
+	if (ctx->panel) {
+		drm_panel_prepare(ctx->panel);
 		drm_panel_enable(ctx->panel);
+	}
 }
 
 static void exynos_dpi_poweroff(struct exynos_dpi *ctx)
 {
-	if (ctx->panel)
+	if (ctx->panel) {
 		drm_panel_disable(ctx->panel);
+		drm_panel_unprepare(ctx->panel);
+	}
 }
 
 static void exynos_dpi_dpms(struct exynos_drm_display *display, int mode)