diff mbox

ASoC: Intel: Don't issue ipc when processing response

Message ID 1406905784-31182-1-git-send-email-yang.jie@intel.com (mailing list archive)
State Accepted
Commit 94ce33456dbada5cb6ae1e10bd8895f034de731d
Headers show

Commit Message

Jie, Yang Aug. 1, 2014, 3:09 p.m. UTC 
From: Pawe? Piskorski <pawel.piskorski@intel.com>

Make sure we dont issue IPC when we are processing a response.

Signed-off-by: Pawe? Piskorski <pawel.piskorski@intel.com>
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Signed-off-by: Jie Yang <yang.jie@intel.com>
---
 sound/soc/intel/sst-haswell-ipc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Mark Brown Aug. 1, 2014, 6:12 p.m. UTC | #1 
On Fri, Aug 01, 2014 at 11:09:44PM +0800, Jie Yang wrote:
> From: Pawe? Piskorski <pawel.piskorski@intel.com>
> 
> Make sure we dont issue IPC when we are processing a response.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/intel/sst-haswell-ipc.c b/sound/soc/intel/sst-haswell-ipc.c
index 5a607ab..0fec686 100644
--- a/sound/soc/intel/sst-haswell-ipc.c
+++ b/sound/soc/intel/sst-haswell-ipc.c
@@ -457,9 +457,10 @@  static void ipc_tx_msgs(struct kthread_work *work)
 		return;
 	}
 
-	/* if the DSP is busy we will TX messages after IRQ */
+	/* if the DSP is busy, we will TX messages after IRQ.
+	 * also postpone if we are in the middle of procesing completion irq*/
 	ipcx = sst_dsp_shim_read_unlocked(hsw->dsp, SST_IPCX);
-	if (ipcx & SST_IPCX_BUSY) {
+	if (ipcx & (SST_IPCX_BUSY | SST_IPCX_DONE)) {
 		spin_unlock_irqrestore(&hsw->dsp->spinlock, flags);
 		return;
 	}