| Message ID | 1407344128-9754-1-git-send-email-xerofoiffy@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Wed, Aug 6, 2014 at 6:55 PM, Nick Krause <xerofoiffy@gmail.com> wrote: > Fix the following warnings about redefining READ and write > > drivers/spi/spi-omap-100k.c:73:0: warning: "WRITE" redefined [enabled by default] > include/linux/fs.h:193:0: note: this is the location of the previous definition > drivers/spi/spi-omap-100k.c:74:0: warning: "READ" redefined [enabled by default] > include/linux/fs.h:192:0: note: this is the location of the previous definition > > Signed-off-by: Nick Krause <xerofoiffy@gmail.com> > --- > drivers/spi/spi-omap-100k.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c > index 5e91858..eb8ae4e 100644 > --- a/drivers/spi/spi-omap-100k.c > +++ b/drivers/spi/spi-omap-100k.c > @@ -70,6 +70,12 @@ > #define SPI_STATUS_WE (1UL << 1) > #define SPI_STATUS_RD (1UL << 0) > > +#ifdef WRITE > +#undef WRITE > +#endif > +#ifdef READ > +#undef READ > +#endif > #define WRITE 0 > #define READ 1 Are these symbols even in use? > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
On Wed, Aug 06, 2014 at 12:55:28PM -0400, Nick Krause wrote: > +#ifdef WRITE > +#undef WRITE > +#endif > +#ifdef READ > +#undef READ > +#endif > #define WRITE 0 > #define READ 1 Please think about what the effect of doing this is and look at how other similar problems have been addressed - the goal isn't to shut up the warning, it's to fix the problem the compiler is trying to tell you about.
diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c index 5e91858..eb8ae4e 100644 --- a/drivers/spi/spi-omap-100k.c +++ b/drivers/spi/spi-omap-100k.c @@ -70,6 +70,12 @@ #define SPI_STATUS_WE (1UL << 1) #define SPI_STATUS_RD (1UL << 0) +#ifdef WRITE +#undef WRITE +#endif +#ifdef READ +#undef READ +#endif #define WRITE 0 #define READ 1
Fix the following warnings about redefining READ and write drivers/spi/spi-omap-100k.c:73:0: warning: "WRITE" redefined [enabled by default] include/linux/fs.h:193:0: note: this is the location of the previous definition drivers/spi/spi-omap-100k.c:74:0: warning: "READ" redefined [enabled by default] include/linux/fs.h:192:0: note: this is the location of the previous definition Signed-off-by: Nick Krause <xerofoiffy@gmail.com> --- drivers/spi/spi-omap-100k.c | 6 ++++++ 1 file changed, 6 insertions(+)