diff mbox

[v4,4/4] ARM: dts: Enable USB otg and host1(dwc) on rk3288-evb

Message ID 1407404095-3265-5-git-send-email-kever.yang@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kever Yang Aug. 7, 2014, 9:34 a.m. UTC
USB otg port is the usb3.0 b-port on the board.
USB host1 port is the host A port nearby the otg port.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>

---

Changes in v4: None
Changes in v3:
- Rebase

Changes in v2:
- evb patch added in version 2

 arch/arm/boot/dts/rk3288-evb.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Doug Anderson Aug. 7, 2014, 9:23 p.m. UTC | #1
Kever,

On Thu, Aug 7, 2014 at 2:34 AM, Kever Yang <kever.yang@rock-chips.com> wrote:
> USB otg port is the usb3.0 b-port on the board.
> USB host1 port is the host A port nearby the otg port.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>
> ---
>
> Changes in v4: None
> Changes in v3:
> - Rebase
>
> Changes in v2:
> - evb patch added in version 2
>
>  arch/arm/boot/dts/rk3288-evb.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
> index 4f57209..a322100 100644
> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
> @@ -94,3 +94,9 @@
>  &usb_host0_ehci {
>         status = "okay";
>  };
> +&usb_host1 {
> +       status = "okay";
> +};
> +&usb_otg {
> +       status = "okay";
> +};

Do you really want to enable "usb_otg" on EVB?  I think you have a
rework on your board to enable vbus on this port, but I don't think
it's applicable to anyone else, is it?

I'm told that on some boards you can turn on GPIO0_12 to get vbus, but
I don't have a board like that so I can't really test.  Even so,
before enabling the otg port we should probably put something in the
dts file that would turn on that vbus...

Unless you've somehow gotten gadget mode to work on the OTG port, my
vote would be to leave it disabled for the EVB for now.


NOTE: keeping the otg definition in the main "r3288.dtsi" (patch 3/4)
still makes sense because other boards may have the OTG port hooked
up.


-Doug
diff mbox

Patch

diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
index 4f57209..a322100 100644
--- a/arch/arm/boot/dts/rk3288-evb.dtsi
+++ b/arch/arm/boot/dts/rk3288-evb.dtsi
@@ -94,3 +94,9 @@ 
 &usb_host0_ehci {
 	status = "okay";
 };
+&usb_host1 {
+	status = "okay";
+};
+&usb_otg {
+	status = "okay";
+};