| Message ID | 1407511136-26477-2-git-send-email-ezequiel.garcia@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dear Ezequiel Garcia,
On Fri, 8 Aug 2014 12:18:51 -0300, Ezequiel Garcia wrote:
> + ge0_pins: ge0_pins {
Would it make sense to name that ge0_rgmii_pins ? And ditto for ge1 ?
Thomas
On 09 Aug 05:19 PM, Thomas Petazzoni wrote: > Dear Ezequiel Garcia, > > On Fri, 8 Aug 2014 12:18:51 -0300, Ezequiel Garcia wrote: > > > + ge0_pins: ge0_pins { > > Would it make sense to name that ge0_rgmii_pins ? And ditto for ge1 ? > Yup, I think it does.
On 08/08/2014 05:18 PM, Ezequiel Garcia wrote: > This commit adds the required pin muxing for the two network interfaces > and the MDIO interface, to the Armada 370 SoC. > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > --- > arch/arm/boot/dts/armada-370.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi > index 21b588b..b0700bf6 100644 > --- a/arch/arm/boot/dts/armada-370.dtsi > +++ b/arch/arm/boot/dts/armada-370.dtsi > @@ -151,6 +151,25 @@ > "mpp62", "mpp60", "mpp58"; > marvell,function = "audio"; > }; > + > + mdio_pins: mdio_pins { Ezequiel, please keep me posted next time ;) Above should be: mdio_pins: mdio-pins { same for the ones below. > + marvell,pins = "mpp17", "mpp18"; > + marvell,function = "ge"; As we haven't used it before, we could still rename "ge" function to more approprate "mdio"... but it is ok. Besides the comments, Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > + }; > + > + ge0_pins: ge0_pins { > + marvell,pins = "mpp5", "mpp6", "mpp7", "mpp8", > + "mpp9", "mpp10", "mpp11", "mpp12", > + "mpp13", "mpp14", "mpp15", "mpp16"; > + marvell,function = "ge0"; > + }; > + > + ge1_pins: ge1_pins { > + marvell,pins = "mpp19", "mpp20", "mpp21", "mpp22", > + "mpp23", "mpp24", "mpp25", "mpp26", > + "mpp27", "mpp28", "mpp29", "mpp30"; > + marvell,function = "ge1"; > + }; > }; > > gpio0: gpio@18100 { >
On 08/08/2014 05:18 PM, Ezequiel Garcia wrote: > This commit adds the required pin muxing for the two network interfaces > and the MDIO interface, to the Armada 370 SoC. > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > --- > arch/arm/boot/dts/armada-370.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi > index 21b588b..b0700bf6 100644 > --- a/arch/arm/boot/dts/armada-370.dtsi > +++ b/arch/arm/boot/dts/armada-370.dtsi > @@ -151,6 +151,25 @@ > "mpp62", "mpp60", "mpp58"; > marvell,function = "audio"; > }; > + > + mdio_pins: mdio_pins { > + marvell,pins = "mpp17", "mpp18"; > + marvell,function = "ge"; > + }; > + > + ge0_pins: ge0_pins { More nitpicking, as stated by others it should be "ge{0,1]_rgmii_pins" not only because it is rgmii, but because a370 also supports gmii for ge0. Sebastian > + marvell,pins = "mpp5", "mpp6", "mpp7", "mpp8", > + "mpp9", "mpp10", "mpp11", "mpp12", > + "mpp13", "mpp14", "mpp15", "mpp16"; > + marvell,function = "ge0"; > + }; > + > + ge1_pins: ge1_pins { > + marvell,pins = "mpp19", "mpp20", "mpp21", "mpp22", > + "mpp23", "mpp24", "mpp25", "mpp26", > + "mpp27", "mpp28", "mpp29", "mpp30"; > + marvell,function = "ge1"; > + }; > }; > > gpio0: gpio@18100 { >
On 10 Aug 02:16 PM, Sebastian Hesselbarth wrote: > On 08/08/2014 05:18 PM, Ezequiel Garcia wrote: > > This commit adds the required pin muxing for the two network interfaces > > and the MDIO interface, to the Armada 370 SoC. > > > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > > --- > > arch/arm/boot/dts/armada-370.dtsi | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi > > index 21b588b..b0700bf6 100644 > > --- a/arch/arm/boot/dts/armada-370.dtsi > > +++ b/arch/arm/boot/dts/armada-370.dtsi > > @@ -151,6 +151,25 @@ > > "mpp62", "mpp60", "mpp58"; > > marvell,function = "audio"; > > }; > > + > > + mdio_pins: mdio_pins { > > Ezequiel, > > please keep me posted next time ;) > Ouch... > Above should be: mdio_pins: mdio-pins { > same for the ones below. > OK. > > + marvell,pins = "mpp17", "mpp18"; > > + marvell,function = "ge"; > > As we haven't used it before, we could still rename "ge" function to > more approprate "mdio"... but it is ok. > FWIW, I'd rather leave it as it is. If we change the function name, we would make backporting a PITA, just because of a nitpick. > Besides the comments, > > Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > Thanks,
diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi index 21b588b..b0700bf6 100644 --- a/arch/arm/boot/dts/armada-370.dtsi +++ b/arch/arm/boot/dts/armada-370.dtsi @@ -151,6 +151,25 @@ "mpp62", "mpp60", "mpp58"; marvell,function = "audio"; }; + + mdio_pins: mdio_pins { + marvell,pins = "mpp17", "mpp18"; + marvell,function = "ge"; + }; + + ge0_pins: ge0_pins { + marvell,pins = "mpp5", "mpp6", "mpp7", "mpp8", + "mpp9", "mpp10", "mpp11", "mpp12", + "mpp13", "mpp14", "mpp15", "mpp16"; + marvell,function = "ge0"; + }; + + ge1_pins: ge1_pins { + marvell,pins = "mpp19", "mpp20", "mpp21", "mpp22", + "mpp23", "mpp24", "mpp25", "mpp26", + "mpp27", "mpp28", "mpp29", "mpp30"; + marvell,function = "ge1"; + }; }; gpio0: gpio@18100 {
This commit adds the required pin muxing for the two network interfaces and the MDIO interface, to the Armada 370 SoC. Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> --- arch/arm/boot/dts/armada-370.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)