[v3,0/4] pci-dra7xx: Enable errata i870 workaround for RC mode
mbox series

Message ID 20180724173150.2701-1-vigneshr@ti.com
Headers show
Series
  • pci-dra7xx: Enable errata i870 workaround for RC mode
Related show

Message

Vignesh Raghavendra July 24, 2018, 5:31 p.m. UTC
Make workaround for errata i870 applicable in Host mode as
well(previously it was enabled only for EP mode) as per errata
documentation: http://www.ti.com/lit/er/sprz450/sprz450.pdf

Tested on DRA72 EVM

Tony,

If you are okay with the series, could you pick this via omap tree?
All ACKs are in place and Lorenzo is okay with PCIe bits to go along with
rest of DTS changes.

Regards
Vignesh


Changes since v2:
Reorder patch 2 to appear at the last.
Collect all the ACKs

Changes since v1:
Drop IRQ handling rework (will be sent out separately)

v2: https://patchwork.ozlabs.org/cover/935454/
v1: https://lkml.org/lkml/2017/12/1/59


Vignesh R (4):
  dt-bindings: PCI: dra7xx: Add bindings for unaligned access in host
    mode
  ARM: dts: dra7: Enable workaround for errata i870 in PCIe host mode
  ARM: dts: dra7: Fix up unaligned access setting for PCIe EP
  pci: dwc: pci-dra7xx: Enable errata i870 for both EP and RC mode

 Documentation/devicetree/bindings/pci/ti-pci.txt |  5 +++++
 arch/arm/boot/dts/dra7.dtsi                      |  4 +++-
 drivers/pci/controller/dwc/pci-dra7xx.c          | 12 ++++++------
 3 files changed, 14 insertions(+), 7 deletions(-)

Comments

Lorenzo Pieralisi Aug. 8, 2018, 4:57 p.m. UTC | #1
On Tue, Jul 24, 2018 at 11:01:46PM +0530, Vignesh R wrote:
> Make workaround for errata i870 applicable in Host mode as
> well(previously it was enabled only for EP mode) as per errata
> documentation: http://www.ti.com/lit/er/sprz450/sprz450.pdf
> 
> Tested on DRA72 EVM
> 
> Tony,
> 
> If you are okay with the series, could you pick this via omap tree?
> All ACKs are in place and Lorenzo is okay with PCIe bits to go along with
> rest of DTS changes.

I think we have missed the v4.19 merge window by now - please let me
know if I can drop this series from the PCI patch queue.

Thanks,
Lorenzo

> Regards
> Vignesh
> 
> 
> Changes since v2:
> Reorder patch 2 to appear at the last.
> Collect all the ACKs
> 
> Changes since v1:
> Drop IRQ handling rework (will be sent out separately)
> 
> v2: https://patchwork.ozlabs.org/cover/935454/
> v1: https://lkml.org/lkml/2017/12/1/59
> 
> 
> Vignesh R (4):
>   dt-bindings: PCI: dra7xx: Add bindings for unaligned access in host
>     mode
>   ARM: dts: dra7: Enable workaround for errata i870 in PCIe host mode
>   ARM: dts: dra7: Fix up unaligned access setting for PCIe EP
>   pci: dwc: pci-dra7xx: Enable errata i870 for both EP and RC mode
> 
>  Documentation/devicetree/bindings/pci/ti-pci.txt |  5 +++++
>  arch/arm/boot/dts/dra7.dtsi                      |  4 +++-
>  drivers/pci/controller/dwc/pci-dra7xx.c          | 12 ++++++------
>  3 files changed, 14 insertions(+), 7 deletions(-)
> 
> -- 
> 2.18.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vignesh Raghavendra Aug. 10, 2018, 10:07 a.m. UTC | #2
On Wednesday 08 August 2018 10:27 PM, Lorenzo Pieralisi wrote:
> On Tue, Jul 24, 2018 at 11:01:46PM +0530, Vignesh R wrote:
>> Make workaround for errata i870 applicable in Host mode as
>> well(previously it was enabled only for EP mode) as per errata
>> documentation: http://www.ti.com/lit/er/sprz450/sprz450.pdf
>>
>> Tested on DRA72 EVM
>>
>> Tony,
>>
>> If you are okay with the series, could you pick this via omap tree?
>> All ACKs are in place and Lorenzo is okay with PCIe bits to go along with
>> rest of DTS changes.
> 
> I think we have missed the v4.19 merge window by now - 

Right. I didn't get any response from Tony.

> please let me know if I can drop this series from the PCI patch queue.
> 

Ok, I will resend the patch after 4.19-rc. Thanks!

Regards
Vignesh


> Thanks,
> Lorenzo
> 
>> Regards
>> Vignesh
>>
>>
>> Changes since v2:
>> Reorder patch 2 to appear at the last.
>> Collect all the ACKs
>>
>> Changes since v1:
>> Drop IRQ handling rework (will be sent out separately)
>>
>> v2: https://patchwork.ozlabs.org/cover/935454/
>> v1: https://lkml.org/lkml/2017/12/1/59
>>
>>
>> Vignesh R (4):
>>   dt-bindings: PCI: dra7xx: Add bindings for unaligned access in host
>>     mode
>>   ARM: dts: dra7: Enable workaround for errata i870 in PCIe host mode
>>   ARM: dts: dra7: Fix up unaligned access setting for PCIe EP
>>   pci: dwc: pci-dra7xx: Enable errata i870 for both EP and RC mode
>>
>>  Documentation/devicetree/bindings/pci/ti-pci.txt |  5 +++++
>>  arch/arm/boot/dts/dra7.dtsi                      |  4 +++-
>>  drivers/pci/controller/dwc/pci-dra7xx.c          | 12 ++++++------
>>  3 files changed, 14 insertions(+), 7 deletions(-)
>>
>> -- 
>> 2.18.0
>>
Tony Lindgren Sept. 7, 2018, 5 p.m. UTC | #3
* Vignesh R <vigneshr@ti.com> [180810 10:10]:
> 
> 
> On Wednesday 08 August 2018 10:27 PM, Lorenzo Pieralisi wrote:
> > On Tue, Jul 24, 2018 at 11:01:46PM +0530, Vignesh R wrote:
> >> Make workaround for errata i870 applicable in Host mode as
> >> well(previously it was enabled only for EP mode) as per errata
> >> documentation: http://www.ti.com/lit/er/sprz450/sprz450.pdf
> >>
> >> Tested on DRA72 EVM
> >>
> >> Tony,
> >>
> >> If you are okay with the series, could you pick this via omap tree?
> >> All ACKs are in place and Lorenzo is okay with PCIe bits to go along with
> >> rest of DTS changes.
> > 
> > I think we have missed the v4.19 merge window by now - 
> 
> Right. I didn't get any response from Tony.

Sorry catching up with pending mails.. I try hard to not touch
anything except fixes around -rc6 time.

> > please let me know if I can drop this series from the PCI patch queue.
> > 
> 
> Ok, I will resend the patch after 4.19-rc. Thanks!

FYI, I'm untagging this thread too. Please post the dts
changes separately once the dependencies (if any) have
cleared.

Regards,

Tony
Lorenzo Pieralisi Sept. 17, 2018, 9:47 a.m. UTC | #4
On Fri, Sep 07, 2018 at 10:00:09AM -0700, Tony Lindgren wrote:
> * Vignesh R <vigneshr@ti.com> [180810 10:10]:
> > 
> > 
> > On Wednesday 08 August 2018 10:27 PM, Lorenzo Pieralisi wrote:
> > > On Tue, Jul 24, 2018 at 11:01:46PM +0530, Vignesh R wrote:
> > >> Make workaround for errata i870 applicable in Host mode as
> > >> well(previously it was enabled only for EP mode) as per errata
> > >> documentation: http://www.ti.com/lit/er/sprz450/sprz450.pdf
> > >>
> > >> Tested on DRA72 EVM
> > >>
> > >> Tony,
> > >>
> > >> If you are okay with the series, could you pick this via omap tree?
> > >> All ACKs are in place and Lorenzo is okay with PCIe bits to go along with
> > >> rest of DTS changes.
> > > 
> > > I think we have missed the v4.19 merge window by now - 
> > 
> > Right. I didn't get any response from Tony.
> 
> Sorry catching up with pending mails.. I try hard to not touch
> anything except fixes around -rc6 time.
> 
> > > please let me know if I can drop this series from the PCI patch queue.
> > > 
> > 
> > Ok, I will resend the patch after 4.19-rc. Thanks!
> 
> FYI, I'm untagging this thread too. Please post the dts
> changes separately once the dependencies (if any) have
> cleared.

Ok, Vignesh: I shall drop this series from the PCI patches queue,
waiting for your new version, let me know how you want to handle this
then please.

Thanks,
Lorenzo
Vignesh Raghavendra Sept. 17, 2018, 6:12 p.m. UTC | #5
Hi Lorenzo,

On 17-Sep-18 3:17 PM, Lorenzo Pieralisi wrote:
> On Fri, Sep 07, 2018 at 10:00:09AM -0700, Tony Lindgren wrote:
>> * Vignesh R <vigneshr@ti.com> [180810 10:10]:
>>>
[...]
>>>>> Tony,
>>>>>
>>>>> If you are okay with the series, could you pick this via omap tree?
>>>>> All ACKs are in place and Lorenzo is okay with PCIe bits to go along with
>>>>> rest of DTS changes.
>>>>
>>>> I think we have missed the v4.19 merge window by now - 
>>>
>>> Right. I didn't get any response from Tony.
>>
>> Sorry catching up with pending mails.. I try hard to not touch
>> anything except fixes around -rc6 time.
>>
>>>> please let me know if I can drop this series from the PCI patch queue.
>>>>
>>>
>>> Ok, I will resend the patch after 4.19-rc. Thanks!
>>
>> FYI, I'm untagging this thread too. Please post the dts
>> changes separately once the dependencies (if any) have
>> cleared.
> 
> Ok, Vignesh: I shall drop this series from the PCI patches queue,
> waiting for your new version, let me know how you want to handle this
> then please.
> 

Thanks for the response!
I have sent v4 dropping DT changes (will send after driver patches have
made it upstream). If possible, consider the patches for next rc as they
are fixes.

Regards
Vignesh