[0/3] arm64: dts: allwinner: a64: pinmux cleanups
mbox series

Message ID 20180828100132.12975-1-wens@csie.org
Headers show
Series
  • arm64: dts: allwinner: a64: pinmux cleanups
Related show

Message

Chen-Yu Tsai (Moxa) Aug. 28, 2018, 10:01 a.m. UTC
Hi,

This series does some cleanup of the Allwinner A64 pinmux groups.

The first addresses a limitation on the A64 where we have the eMMC's
DS in always muxed in. The DS pin is shared with SPI0's MISO, thereby
preventing SPI0 from being used. In this patch we split out the DS
pin into a separate group for boards that actually utilize it to
select on their own.

The other two patches just rename pinmux group node names and labels
from <func>_pins_<[a-z]> to <func>_<pingroup/pin names>_pins. The latter
is the style we adopted later on, and is easier to know which pins they
correspond to, i.e. easier to review.

Please have a look.

While I want to do some more cleanup, I realized that the label and/or
node names might be used by distro (Armbian comes to mind) or personal
device tree overlay files. Do we need to have these remain fixed? Do
we or can we provide a fallback? (Is that even possible?)

Regards
ChenYu

Chen-Yu Tsai (3):
  arm64: dts: allwinner: a64: Split out data strobe pin from mmc2 pinmux
  arm64: dts: allwinner: a64: Rename uart0_pins_a label to uart0_pb_pins
  arm64: dts: allwinner: a64: Rename r_i2c_pins_a label to
    r_i2c_pl89_pins

 .../boot/dts/allwinner/sun50i-a64-amarula-relic.dts |  2 +-
 .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts  |  4 ++--
 .../boot/dts/allwinner/sun50i-a64-nanopi-a64.dts    |  2 +-
 .../boot/dts/allwinner/sun50i-a64-olinuxino.dts     |  2 +-
 .../boot/dts/allwinner/sun50i-a64-orangepi-win.dts  |  2 +-
 arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts |  2 +-
 .../boot/dts/allwinner/sun50i-a64-pinebook.dts      |  6 +++---
 .../dts/allwinner/sun50i-a64-sopine-baseboard.dts   |  2 +-
 .../arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts |  2 +-
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi       | 13 ++++++++++---
 10 files changed, 22 insertions(+), 15 deletions(-)

Comments

Maxime Ripard Aug. 28, 2018, 3:11 p.m. UTC | #1
On Tue, Aug 28, 2018 at 06:01:29PM +0800, Chen-Yu Tsai wrote:
> Hi,
> 
> This series does some cleanup of the Allwinner A64 pinmux groups.
> 
> The first addresses a limitation on the A64 where we have the eMMC's
> DS in always muxed in. The DS pin is shared with SPI0's MISO, thereby
> preventing SPI0 from being used. In this patch we split out the DS
> pin into a separate group for boards that actually utilize it to
> select on their own.
> 
> The other two patches just rename pinmux group node names and labels
> from <func>_pins_<[a-z]> to <func>_<pingroup/pin names>_pins. The latter
> is the style we adopted later on, and is easier to know which pins they
> correspond to, i.e. easier to review.
> 
> Please have a look.

Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

> While I want to do some more cleanup, I realized that the label and/or
> node names might be used by distro (Armbian comes to mind) or personal
> device tree overlay files. Do we need to have these remain fixed? Do
> we or can we provide a fallback? (Is that even possible?)

I wouldn't worry too much about this. We broke it a number of times
already, and we probably will in the future for other stuff, I'm not
sure we have to provide any guarantee there, as long as the old,
compiled, dt still works.

Maxime
Chen-Yu Tsai (Moxa) Sept. 3, 2018, 3 a.m. UTC | #2
n Tue, Aug 28, 2018 at 11:12 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Tue, Aug 28, 2018 at 06:01:29PM +0800, Chen-Yu Tsai wrote:
> > Hi,
> >
> > This series does some cleanup of the Allwinner A64 pinmux groups.
> >
> > The first addresses a limitation on the A64 where we have the eMMC's
> > DS in always muxed in. The DS pin is shared with SPI0's MISO, thereby
> > preventing SPI0 from being used. In this patch we split out the DS
> > pin into a separate group for boards that actually utilize it to
> > select on their own.
> >
> > The other two patches just rename pinmux group node names and labels
> > from <func>_pins_<[a-z]> to <func>_<pingroup/pin names>_pins. The latter
> > is the style we adopted later on, and is easier to know which pins they
> > correspond to, i.e. easier to review.
> >
> > Please have a look.
>
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

Applied.

> > While I want to do some more cleanup, I realized that the label and/or
> > node names might be used by distro (Armbian comes to mind) or personal
> > device tree overlay files. Do we need to have these remain fixed? Do
> > we or can we provide a fallback? (Is that even possible?)
>
> I wouldn't worry too much about this. We broke it a number of times
> already, and we probably will in the future for other stuff, I'm not
> sure we have to provide any guarantee there, as long as the old,
> compiled, dt still works.

OK :)