[0/6] Some trivail cleanup about dealyed-refs
mbox series

Message ID 20181011054038.5428-1-lufq.fnst@cn.fujitsu.com
Headers show
Series
  • Some trivail cleanup about dealyed-refs
Related show

Message

Lu Fengqi Oct. 11, 2018, 5:40 a.m. UTC
There is no functional change. Just improve readablity.

PATCH 1-4 parameter cleanup patches
PATCH 5 cleanup about btrfs_select_ref_head
PATCH 6 switch int to bool; add some comment

Lu Fengqi (6):
  btrfs: delayed-ref: pass delayed_refs directly to
    btrfs_select_ref_head()
  btrfs: delayed-ref: pass delayed_refs directly to
    btrfs_delayed_ref_lock()
  btrfs: remove fs_info from btrfs_check_space_for_delayed_refs
  btrfs: remove fs_info from btrfs_should_throttle_delayed_refs
  btrfs: simplify btrfs_select_ref_head and cleanup some local variables
  btrfs: switch return_bigger to bool in find_ref_head

 fs/btrfs/ctree.h       |  6 ++----
 fs/btrfs/delayed-ref.c | 35 ++++++++++-------------------------
 fs/btrfs/delayed-ref.h |  4 ++--
 fs/btrfs/extent-tree.c | 15 +++++++--------
 fs/btrfs/inode.c       |  7 +++----
 fs/btrfs/transaction.c |  4 ++--
 6 files changed, 26 insertions(+), 45 deletions(-)

Comments

Nikolay Borisov Oct. 11, 2018, 6:41 a.m. UTC | #1
On 11.10.2018 08:40, Lu Fengqi wrote:
> There is no functional change. Just improve readablity.
> 
> PATCH 1-4 parameter cleanup patches
> PATCH 5 cleanup about btrfs_select_ref_head
> PATCH 6 switch int to bool; add some comment
> 
> Lu Fengqi (6):
>   btrfs: delayed-ref: pass delayed_refs directly to
>     btrfs_select_ref_head()
>   btrfs: delayed-ref: pass delayed_refs directly to
>     btrfs_delayed_ref_lock()
>   btrfs: remove fs_info from btrfs_check_space_for_delayed_refs
>   btrfs: remove fs_info from btrfs_should_throttle_delayed_refs
>   btrfs: simplify btrfs_select_ref_head and cleanup some local variables
>   btrfs: switch return_bigger to bool in find_ref_head

For patches 1-4 and 6:

Reviewed-by: Nikolay Borisov <nborisov@suse.com>


> 
>  fs/btrfs/ctree.h       |  6 ++----
>  fs/btrfs/delayed-ref.c | 35 ++++++++++-------------------------
>  fs/btrfs/delayed-ref.h |  4 ++--
>  fs/btrfs/extent-tree.c | 15 +++++++--------
>  fs/btrfs/inode.c       |  7 +++----
>  fs/btrfs/transaction.c |  4 ++--
>  6 files changed, 26 insertions(+), 45 deletions(-)
>
David Sterba Oct. 11, 2018, 11:51 a.m. UTC | #2
On Thu, Oct 11, 2018 at 01:40:32PM +0800, Lu Fengqi wrote:
> There is no functional change. Just improve readablity.
> 
> PATCH 1-4 parameter cleanup patches
> PATCH 5 cleanup about btrfs_select_ref_head
> PATCH 6 switch int to bool; add some comment
> 
> Lu Fengqi (6):
>   btrfs: delayed-ref: pass delayed_refs directly to
>     btrfs_select_ref_head()
>   btrfs: delayed-ref: pass delayed_refs directly to
>     btrfs_delayed_ref_lock()
>   btrfs: remove fs_info from btrfs_check_space_for_delayed_refs
>   btrfs: remove fs_info from btrfs_should_throttle_delayed_refs
>   btrfs: simplify btrfs_select_ref_head and cleanup some local variables
>   btrfs: switch return_bigger to bool in find_ref_head

1-4 and 6 added to misc-next, thanks.
Lu Fengqi Oct. 15, 2018, 2:39 a.m. UTC | #3
On Thu, Oct 11, 2018 at 01:51:37PM +0200, David Sterba wrote:
>On Thu, Oct 11, 2018 at 01:40:32PM +0800, Lu Fengqi wrote:
>> There is no functional change. Just improve readablity.
>> 
>> PATCH 1-4 parameter cleanup patches
>> PATCH 5 cleanup about btrfs_select_ref_head
>> PATCH 6 switch int to bool; add some comment
>> 
>> Lu Fengqi (6):
>>   btrfs: delayed-ref: pass delayed_refs directly to
>>     btrfs_select_ref_head()
>>   btrfs: delayed-ref: pass delayed_refs directly to
>>     btrfs_delayed_ref_lock()
>>   btrfs: remove fs_info from btrfs_check_space_for_delayed_refs
>>   btrfs: remove fs_info from btrfs_should_throttle_delayed_refs
>>   btrfs: simplify btrfs_select_ref_head and cleanup some local variables
>>   btrfs: switch return_bigger to bool in find_ref_head
>
>1-4 and 6 added to misc-next, thanks.

There is not patch 2 at the misc-next branch. So it was forgotten?
David Sterba Oct. 15, 2018, 1:26 p.m. UTC | #4
On Mon, Oct 15, 2018 at 10:39:19AM +0800, Lu Fengqi wrote:
> On Thu, Oct 11, 2018 at 01:51:37PM +0200, David Sterba wrote:
> >On Thu, Oct 11, 2018 at 01:40:32PM +0800, Lu Fengqi wrote:
> >> There is no functional change. Just improve readablity.
> >> 
> >> PATCH 1-4 parameter cleanup patches
> >> PATCH 5 cleanup about btrfs_select_ref_head
> >> PATCH 6 switch int to bool; add some comment
> >> 
> >> Lu Fengqi (6):
> >>   btrfs: delayed-ref: pass delayed_refs directly to
> >>     btrfs_select_ref_head()
> >>   btrfs: delayed-ref: pass delayed_refs directly to
> >>     btrfs_delayed_ref_lock()
> >>   btrfs: remove fs_info from btrfs_check_space_for_delayed_refs
> >>   btrfs: remove fs_info from btrfs_should_throttle_delayed_refs
> >>   btrfs: simplify btrfs_select_ref_head and cleanup some local variables
> >>   btrfs: switch return_bigger to bool in find_ref_head
> >
> >1-4 and 6 added to misc-next, thanks.
> 
> There is not patch 2 at the misc-next branch. So it was forgotten?

You're right, got lost somewhere, now in misc-next. Thanks for checking.