mbox series

[0/2] vfs: Fix crashes when reading /proc/mounts

Message ID 20181018131709.11976-1-jack@suse.cz (mailing list archive)
Headers show
Series vfs: Fix crashes when reading /proc/mounts | expand

Message

Jan Kara Oct. 18, 2018, 1:17 p.m. UTC
Hello,

this patch series aims at fixing possible races between functions formatting
output for /proc/mounts and friends and remount. Especially ->show_options
functions of filesystems are not counting with the fact that options can
change under them and thus races can result in bogus output or outright
crashes (like was the case with ext4 handling of quota mount option, or udf
could crash when printing charset name, or xfs when printing log device name
etc.).

Admittedly the patch 2/2 is somewhat ugly because namespace_sem ranks below
sb->s_umount semaphore but I think it is bearable. Al, what do you think?

								Honza