mbox series

[RFC,0/2] explicitly support or not support --exclude-promisor-objects

Message ID cover.1540256910.git.matvore@google.com (mailing list archive)
Headers show
Series explicitly support or not support --exclude-promisor-objects | expand

Message

Matthew DeVore Oct. 23, 2018, 1:13 a.m. UTC 
This patch set fixes incorrect parsing of the --exclude-promisor-objects
option that I found while working on:

  https://public-inbox.org/git/cover.1539298957.git.matvore@google.com/

Thank you,

Matthew DeVore (2):
  Documentation/git-log.txt: do not show --exclude-promisor-objects
  exclude-promisor-objects: declare when option is allowed

 Documentation/rev-list-options.txt | 2 +-
 builtin/pack-objects.c             | 1 +
 builtin/prune.c                    | 1 +
 builtin/rev-list.c                 | 1 +
 revision.c                         | 3 ++-
 revision.h                         | 1 +
 t/t4202-log.sh                     | 4 ++++
 t/t8002-blame.sh                   | 4 ++++
 8 files changed, 15 insertions(+), 2 deletions(-)

Comments

Matthew DeVore Oct. 23, 2018, 1:18 a.m. UTC | #1 
On Mon, 22 Oct 2018, Matthew DeVore wrote:

> This patch set fixes incorrect parsing of the --exclude-promisor-objects
> option that I found while working on:
>

Somehow I sent two copies of every message in the patchset. I'm sorry
for the mess.
Junio C Hamano Oct. 23, 2018, 4:48 a.m. UTC | #2 
Matthew DeVore <matvore@google.com> writes:

> This patch set fixes incorrect parsing of the --exclude-promisor-objects
> option that I found while working on:
>
>   https://public-inbox.org/git/cover.1539298957.git.matvore@google.com/
>

Thanks; both patches make sense.  

As the problematic feature appeared in 2.17.x track, I'll see if I
can easily make it ready to be merged down to maint-2.17 track later
when somebody wants to.

> Matthew DeVore (2):
>   Documentation/git-log.txt: do not show --exclude-promisor-objects
>   exclude-promisor-objects: declare when option is allowed
>
>  Documentation/rev-list-options.txt | 2 +-
>  builtin/pack-objects.c             | 1 +
>  builtin/prune.c                    | 1 +
>  builtin/rev-list.c                 | 1 +
>  revision.c                         | 3 ++-
>  revision.h                         | 1 +
>  t/t4202-log.sh                     | 4 ++++
>  t/t8002-blame.sh                   | 4 ++++
>  8 files changed, 15 insertions(+), 2 deletions(-)
Matthew DeVore Oct. 23, 2018, 5:09 p.m. UTC | #3 
On Tue, 23 Oct 2018, Junio C Hamano wrote:

> Thanks; both patches make sense.
>
> As the problematic feature appeared in 2.17.x track, I'll see if I
> can easily make it ready to be merged down to maint-2.17 track later
> when somebody wants to.
>

Great. Thank you for the review.