[0/5] virgl: fence fd support
mbox series

Message ID 20181025183739.9375-1-robert.foss@collabora.com
Headers show
Series
  • virgl: fence fd support
Related show

Message

Robert Foss Oct. 25, 2018, 6:37 p.m. UTC
This series implements fence support for drm/virtio and
has been tested using qemu, kmscube and the below branches.

Rob Herring solved a reference counting issue and
suggested a context check for the execbuf ioctl, his
changes have been included in the below commits to
keep the tree working at all commits.


The linux series can be found here:
https://gitlab.collabora.com/robertfoss/linux/commits/virtio_fences_v3

As for mesa, the branch can be found here:
https://gitlab.collabora.com/robertfoss/mesa/commits/virtio_fences_v3


Changes since v2:
 - drm/virtio: add virtio_gpu_alloc_fence()
   - Forward port and fix compilation issues
 - drm/virtio: add uapi for in and out explicit fences
   - Check exbuf->flags for unsupported flags


Gustavo Padovan (4):
  drm/virtio: add virtio_gpu_alloc_fence()
  drm/virtio: add in-fences support for explicit synchronization
  drm/virtio: add out-fences support for explicit synchronization
  drm/virtio: bump driver version after explicit synchronization
    addition

Robert Foss (1):
  drm/virtio: add uapi for in and out explicit fences

 drivers/gpu/drm/virtio/virtgpu_drv.h   |  22 +++--
 drivers/gpu/drm/virtio/virtgpu_fence.c |  41 ++++++---
 drivers/gpu/drm/virtio/virtgpu_ioctl.c | 118 +++++++++++++++++++++----
 drivers/gpu/drm/virtio/virtgpu_plane.c |  46 ++++++++--
 drivers/gpu/drm/virtio/virtgpu_vq.c    |  16 ++--
 include/uapi/drm/virtgpu_drm.h         |  13 ++-
 6 files changed, 201 insertions(+), 55 deletions(-)

Comments

Emil Velikov Oct. 31, 2018, 9:45 a.m. UTC | #1
Hi Rob,

On Thu, 25 Oct 2018 at 19:37, Robert Foss <robert.foss@collabora.com> wrote:
>
> This series implements fence support for drm/virtio and
> has been tested using qemu, kmscube and the below branches.
>
> Rob Herring solved a reference counting issue and
> suggested a context check for the execbuf ioctl, his
> changes have been included in the below commits to
> keep the tree working at all commits.
>
I've put forward some mostly minor suggestions.
The patches look pretty good but there's one piece missing:

>
> The linux series can be found here:
> https://gitlab.collabora.com/robertfoss/linux/commits/virtio_fences_v3
>
> As for mesa, the branch can be found here:
> https://gitlab.collabora.com/robertfoss/mesa/commits/virtio_fences_v3
>
Namely: This should be out for review. The kernel and userspace side
of IOCTLs should happen roughly at the same time.
Otherwise, there's a huge chance of merging one side of the component,
while the other needs architectural changes.

HTH
Emil