| Message ID | 20181028123514.12660-1-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | meson6_timer: dt-bindings updates | expand |
On Sun, Oct 28, 2018 at 7:35 AM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > The dt-bindings don't match the actual IP block implementation: > - each timer has four IRQ lines (Timer A, B, C and D) > - the IP block has internal dividers which use XTAL as parent clock. > the result can then be used as timebase for Timers A, B, C, D and E. > internal dividers are (XTAL is running at 24MHz): 24 for 1us, 240 for > 10us, 2400 for 100us and 24000 for 1ms. > - Timer E can use the "system clock" (clk81) as timebase > > I'm not sure whether these patches will go through tip.git or Kevin's > linux-amlogic tree. Daniel, Thomas: please let Kevin know if he should > take these through his drivers branch Normally would be the subsystem tree, but I'm happy to take binding only changes thru the DT tree. We just can't have them go thru a mixture of trees if you have further changes. Are these fixes to reflect what the dts files and timers already expect? If so, they should be applied for 4.20. If not, you should have one series with all the updates. > Martin Blumenstingl (2): > dt-bindings: timer: meson6_timer: document all interrupts > dt-bindings: timer: meson6_timer: document the clock inputs Resend to the DT list if you want me to apply. Otherwise, Reviewed-by: Rob Herring <robh@kernel.org>
Hi Rob, On Mon, Oct 29, 2018 at 9:09 PM Rob Herring <robh+dt@kernel.org> wrote: > > On Sun, Oct 28, 2018 at 7:35 AM Martin Blumenstingl > <martin.blumenstingl@googlemail.com> wrote: > > > > The dt-bindings don't match the actual IP block implementation: > > - each timer has four IRQ lines (Timer A, B, C and D) > > - the IP block has internal dividers which use XTAL as parent clock. > > the result can then be used as timebase for Timers A, B, C, D and E. > > internal dividers are (XTAL is running at 24MHz): 24 for 1us, 240 for > > 10us, 2400 for 100us and 24000 for 1ms. > > - Timer E can use the "system clock" (clk81) as timebase > > > > I'm not sure whether these patches will go through tip.git or Kevin's > > linux-amlogic tree. Daniel, Thomas: please let Kevin know if he should > > take these through his drivers branch > > Normally would be the subsystem tree, but I'm happy to take binding > only changes thru the DT tree. We just can't have them go thru a > mixture of trees if you have further changes. > > Are these fixes to reflect what the dts files and timers already > expect? If so, they should be applied for 4.20. If not, you should > have one series with all the updates. both the meson6_timer driver and the .dts currently only specify one interrupt and nothing else I have .dts patches in my tree which add the missing interrupts and the clocks however, I prefer to send the .dts patches later as I have two other pending patch series which are modifying the same .dts files thus I'd like to re-send the two patches from this series (with your Reviewed-by) together with the .dts changes can you please confirm that Kevin can take everything through his linux-amlogic tree (dt-bindings patches probably in his drivers branch, .dts patches in his dt branch) if the clocksource maintainers don't care either? Regards Martin
On Mon, Oct 29, 2018 at 4:23 PM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > Hi Rob, > > On Mon, Oct 29, 2018 at 9:09 PM Rob Herring <robh+dt@kernel.org> wrote: > > > > On Sun, Oct 28, 2018 at 7:35 AM Martin Blumenstingl > > <martin.blumenstingl@googlemail.com> wrote: > > > > > > The dt-bindings don't match the actual IP block implementation: > > > - each timer has four IRQ lines (Timer A, B, C and D) > > > - the IP block has internal dividers which use XTAL as parent clock. > > > the result can then be used as timebase for Timers A, B, C, D and E. > > > internal dividers are (XTAL is running at 24MHz): 24 for 1us, 240 for > > > 10us, 2400 for 100us and 24000 for 1ms. > > > - Timer E can use the "system clock" (clk81) as timebase > > > > > > I'm not sure whether these patches will go through tip.git or Kevin's > > > linux-amlogic tree. Daniel, Thomas: please let Kevin know if he should > > > take these through his drivers branch > > > > Normally would be the subsystem tree, but I'm happy to take binding > > only changes thru the DT tree. We just can't have them go thru a > > mixture of trees if you have further changes. > > > > Are these fixes to reflect what the dts files and timers already > > expect? If so, they should be applied for 4.20. If not, you should > > have one series with all the updates. > both the meson6_timer driver and the .dts currently only specify one > interrupt and nothing else > > I have .dts patches in my tree which add the missing interrupts and the clocks > however, I prefer to send the .dts patches later as I have two other > pending patch series which are modifying the same .dts files > thus I'd like to re-send the two patches from this series (with your > Reviewed-by) together with the .dts changes > > can you please confirm that Kevin can take everything through his > linux-amlogic tree (dt-bindings patches probably in his drivers > branch, .dts patches in his dt branch) if the clocksource maintainers > don't care either? Yeah, that should be fine. Rob
Rob Herring <robh+dt@kernel.org> writes: > On Mon, Oct 29, 2018 at 4:23 PM Martin Blumenstingl > <martin.blumenstingl@googlemail.com> wrote: >> >> Hi Rob, >> >> On Mon, Oct 29, 2018 at 9:09 PM Rob Herring <robh+dt@kernel.org> wrote: >> > >> > On Sun, Oct 28, 2018 at 7:35 AM Martin Blumenstingl >> > <martin.blumenstingl@googlemail.com> wrote: >> > > >> > > The dt-bindings don't match the actual IP block implementation: >> > > - each timer has four IRQ lines (Timer A, B, C and D) >> > > - the IP block has internal dividers which use XTAL as parent clock. >> > > the result can then be used as timebase for Timers A, B, C, D and E. >> > > internal dividers are (XTAL is running at 24MHz): 24 for 1us, 240 for >> > > 10us, 2400 for 100us and 24000 for 1ms. >> > > - Timer E can use the "system clock" (clk81) as timebase >> > > >> > > I'm not sure whether these patches will go through tip.git or Kevin's >> > > linux-amlogic tree. Daniel, Thomas: please let Kevin know if he should >> > > take these through his drivers branch >> > >> > Normally would be the subsystem tree, but I'm happy to take binding >> > only changes thru the DT tree. We just can't have them go thru a >> > mixture of trees if you have further changes. >> > >> > Are these fixes to reflect what the dts files and timers already >> > expect? If so, they should be applied for 4.20. If not, you should >> > have one series with all the updates. >> both the meson6_timer driver and the .dts currently only specify one >> interrupt and nothing else >> >> I have .dts patches in my tree which add the missing interrupts and the clocks >> however, I prefer to send the .dts patches later as I have two other >> pending patch series which are modifying the same .dts files >> thus I'd like to re-send the two patches from this series (with your >> Reviewed-by) together with the .dts changes >> >> can you please confirm that Kevin can take everything through his >> linux-amlogic tree (dt-bindings patches probably in his drivers >> branch, .dts patches in his dt branch) if the clocksource maintainers >> don't care either? > > Yeah, that should be fine. Queued for v4.21 (in branch v4.21/dt) Kevin